Bug 1829225 - Make BeforeSetAttr take the parsed nsAttrValue. r=smaug

ParseAttribute ideally would be const (see bug 1829138), but the SVG and
SMIL code is rather messy. Still, now that BeforeSetAttr can't really
fail, swapping the order of ParseAttribute and BeforeSetAttr shouldn't
really change behavior.

Sorry for the extra `virtual` keyword removal and such. I had to do this
one by hand unlike the dependent bugs, and I went a bit drive-by, lmk if
you want me to split those changes.

Differential Revision: https://phabricator.services.mozilla.com/D176086
This commit is contained in:
Emilio Cobos Álvarez
2023-04-21 09:25:17 +00:00
parent dc08c242b1
commit c1c1e7460b
38 changed files with 295 additions and 377 deletions

View File

@@ -823,7 +823,7 @@ void HTMLTextAreaElement::UnbindFromTree(bool aNullParent) {
}
void HTMLTextAreaElement::BeforeSetAttr(int32_t aNameSpaceID, nsAtom* aName,
const nsAttrValueOrString* aValue,
const nsAttrValue* aValue,
bool aNotify) {
if (aNotify && aName == nsGkAtoms::disabled &&
aNameSpaceID == kNameSpaceID_None) {