corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1587973 - Part 4: Rename GetTargetSize with CalculateBoxSize. r=emilio

Browse Source 
Use the same name as the spec title for better readability:
https://www.w3.org/TR/resize-observer-1/#calculate-box-size

Differential Revision: https://phabricator.services.mozilla.com/D121158
This commit is contained in:
Boris Chiou
2021-08-10 21:03:31 +00:00
parent 83303355be
commit c108083168
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
dom/base/ResizeObserver.cpp
View File

@@ -48,8 +48,10 @@ static uint32_t GetNodeDepth(nsINode* aNode) {
/** /**
* Returns |aTarget|'s size in the form of gfx::Size (in pixels). * Returns |aTarget|'s size in the form of gfx::Size (in pixels).
* If the target is SVG, width and height are determined from bounding box. * If the target is SVG, width and height are determined from bounding box.
*
* https://www.w3.org/TR/resize-observer-1/#calculate-box-size
*/ */
static gfx::Size GetTargetSize(Element* aTarget, static gfx::Size CalculateBoxSize(Element* aTarget,
ResizeObserverBoxOptions aBox) { ResizeObserverBoxOptions aBox) {
gfx::Size size; gfx::Size size;
nsIFrame* frame = aTarget->GetPrimaryFrame(); nsIFrame* frame = aTarget->GetPrimaryFrame();
@@ -155,7 +157,7 @@ void ResizeObservation::Unlink(RemoveFromObserver aRemoveFromObserver) {
bool ResizeObservation::IsActive() const { bool ResizeObservation::IsActive() const {
nsIFrame* frame = mTarget->GetPrimaryFrame(); nsIFrame* frame = mTarget->GetPrimaryFrame();
const WritingMode wm = frame ? frame->GetWritingMode() : WritingMode(); const WritingMode wm = frame ? frame->GetWritingMode() : WritingMode();
const LogicalPixelSize size(wm, GetTargetSize(mTarget, mObservedBox)); const LogicalPixelSize size(wm, CalculateBoxSize(mTarget, mObservedBox));
return mLastReportedSize != size; return mLastReportedSize != size;
} }
@@ -317,10 +319,10 @@ uint32_t ResizeObserver::BroadcastActiveObservations() {
Element* target = observation->Target(); Element* target = observation->Target();
gfx::Size borderBoxSize = gfx::Size borderBoxSize =
GetTargetSize(target, ResizeObserverBoxOptions::Border_box); CalculateBoxSize(target, ResizeObserverBoxOptions::Border_box);
gfx::Size contentBoxSize = gfx::Size contentBoxSize =
GetTargetSize(target, ResizeObserverBoxOptions::Content_box); CalculateBoxSize(target, ResizeObserverBoxOptions::Content_box);
gfx::Size devicePixelContentBoxSize = GetTargetSize( gfx::Size devicePixelContentBoxSize = CalculateBoxSize(
target, ResizeObserverBoxOptions::Device_pixel_content_box); target, ResizeObserverBoxOptions::Device_pixel_content_box);
RefPtr<ResizeObserverEntry> entry = RefPtr<ResizeObserverEntry> entry =
new ResizeObserverEntry(this, *target, borderBoxSize, contentBoxSize, new ResizeObserverEntry(this, *target, borderBoxSize, contentBoxSize,