corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1460092: Add ESLint rule to enforce use of ChromeUtils.generateQI. r=Gijs

Browse Source 
Also fixes existing code which fails the rule.

MozReview-Commit-ID: CkLFgsspGMU
This commit is contained in:
Kris Maglione
2018-05-08 18:36:22 -07:00
parent f45e53c27b
commit c03fa450d6
84 changed files with 328 additions and 564 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
toolkit/components/url-classifier/tests/browser/classifierHelper.js
View File

@@ -46,12 +46,7 @@ classifierHelper.waitForInit = function() {
}, "mozentries-update-finished");
let listener = {
QueryInterface(iid) {
if (iid.equals(Ci.nsISupports) ||
iid.equals(Ci.nsIUrlClassifierUpdateObserver))
return this;
throw Cr.NS_ERROR_NO_INTERFACE;
},
QueryInterface: ChromeUtils.generateQI(["nsIUrlClassifierUpdateObserver"]),
handleEvent(value) {
if (value === table) {
@@ -137,13 +132,7 @@ classifierHelper._update = function(update) {
try {
await new Promise((resolve, reject) => {
let listener = {
QueryInterface(iid) {
if (iid.equals(Ci.nsISupports) ||
iid.equals(Ci.nsIUrlClassifierUpdateObserver))
return this;
throw Cr.NS_ERROR_NO_INTERFACE;
},
QueryInterface: ChromeUtils.generateQI(["nsIUrlClassifierUpdateObserver"]),
updateUrlRequested(url) { },
streamFinished(status) { },
updateError(errorCode) {