corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1846407 - Use enum class for Task::Run return value. r=bas,win-reviewers,rkraesig

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D185043
This commit is contained in:
Tooru Fujisawa
2023-10-18 01:54:43 +00:00
parent 59a0285adf
commit bebceb1b21
9 changed files with 41 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
dom/script/ScriptLoader.cpp
View File

@@ -1606,14 +1606,14 @@ class OffThreadCompilationCompleteTask : public Task {
}
#endif
bool Run() override {
TaskResult Run() override {
MOZ_ASSERT(NS_IsMainThread());
RefPtr<ScriptLoadContext> context = mRequest->GetScriptLoadContext();
if (!context->mCompileOrDecodeTask) {
// Request has been cancelled by MaybeCancelOffThreadScript.
return true;
return TaskResult::Complete;
}
RecordStopTime();
@@ -1638,7 +1638,7 @@ class OffThreadCompilationCompleteTask : public Task {
mRequest = nullptr;
mLoader = nullptr;
return true;
return TaskResult::Complete;
}
private:
@@ -1857,17 +1857,17 @@ class ScriptOrModuleCompileTask final : public CompileOrDecodeTask {
return NS_OK;
}
bool Run() override {
TaskResult Run() override {
MutexAutoLock lock(mMutex);
if (IsCancelled(lock)) {
return true;
return TaskResult::Complete;
}
RefPtr<JS::Stencil> stencil = Compile();
DidRunTask(lock, std::move(stencil));
return true;
return TaskResult::Complete;
}
private:
@@ -1932,11 +1932,11 @@ class ScriptDecodeTask final : public CompileOrDecodeTask {
return NS_OK;
}
bool Run() override {
TaskResult Run() override {
MutexAutoLock lock(mMutex);
if (IsCancelled(lock)) {
return true;
return TaskResult::Complete;
}
RefPtr<JS::Stencil> stencil = Decode();
@@ -1946,7 +1946,7 @@ class ScriptDecodeTask final : public CompileOrDecodeTask {
mOptions.steal(std::move(mDecodeOptions));
DidRunTask(lock, std::move(stencil));
return true;
return TaskResult::Complete;
}
private: