corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1248695 - Check for null browser app object when handling UI telemetry events; r=snorp

Browse Source 
The nsAppShell mBrowserApp object may not have been initialized when
handling UI telemetry events. In that case, we should bail instead of
crashing.
This commit is contained in:
Jim Chen
2016-02-16 16:57:49 -05:00
parent 1e895cd657
commit beab71e409
1 changed files with 6 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
widget/android/nsAppShell.cpp
View File

@@ -655,6 +655,8 @@ nsAppShell::LegacyGeckoEvent::Run()
}
case AndroidGeckoEvent::TELEMETRY_UI_SESSION_STOP: {
if (!nsAppShell::Get()->mBrowserApp)
break;
if (curEvent->Characters().Length() == 0)
break;
@@ -672,6 +674,8 @@ nsAppShell::LegacyGeckoEvent::Run()
}
case AndroidGeckoEvent::TELEMETRY_UI_SESSION_START: {
if (!nsAppShell::Get()->mBrowserApp)
break;
if (curEvent->Characters().Length() == 0)
break;
@@ -688,6 +692,8 @@ nsAppShell::LegacyGeckoEvent::Run()
}
case AndroidGeckoEvent::TELEMETRY_UI_EVENT: {
if (!nsAppShell::Get()->mBrowserApp)
break;
if (curEvent->Data().Length() == 0)
break;