From bcd9cd6b58c6deabdaf0c96c0dd1a2225ed3fc7e Mon Sep 17 00:00:00 2001
From: Tim Giles <tgiles@mozilla.com>
Date: Wed, 18 Jan 2023 19:13:34 +0000
Subject: [PATCH] Bug 1801927 - refactor configure how firefox connects learn
 more link. r=mconley

Replaces the "Configure how Nightly connects to the internet" XUL label
with the moz-support-link element.

Differential Revision: https://phabricator.services.mozilla.com/D166468
---
 browser/components/preferences/main.inc.xhtml | 5 ++++-
 browser/components/preferences/main.js        | 7 -------
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/browser/components/preferences/main.inc.xhtml b/browser/components/preferences/main.inc.xhtml
index 713b8e3f2cc2..ba864a6fa5c6 100644
--- a/browser/components/preferences/main.inc.xhtml
+++ b/browser/components/preferences/main.inc.xhtml
@@ -776,7 +776,10 @@
       data-subcategory="netsettings">
     <description flex="1" control="connectionSettings">
       <html:span id="connectionSettingsDescription"/>
-      <label id="connectionSettingsLearnMore" class="learnMore" is="text-link" data-l10n-id="network-proxy-connection-learn-more"/>
+      <html:a is="moz-support-link"
+            data-l10n-id="network-proxy-connection-learn-more"
+            support-page="prefs-connection-settings"
+      />
     </description>
     <separator orient="vertical"/>
     <button id="connectionSettings"
diff --git a/browser/components/preferences/main.js b/browser/components/preferences/main.js
index 60c48eae57ad..4b6138089f8a 100644
--- a/browser/components/preferences/main.js
+++ b/browser/components/preferences/main.js
@@ -314,13 +314,6 @@ var gMainPane = {
     });
     this.updatePerformanceSettingsBox({ duringChangeEvent: false });
     this.displayUseSystemLocale();
-    let connectionSettingsLink = document.getElementById(
-      "connectionSettingsLearnMore"
-    );
-    let connectionSettingsUrl =
-      Services.urlFormatter.formatURLPref("app.support.baseURL") +
-      "prefs-connection-settings";
-    connectionSettingsLink.setAttribute("href", connectionSettingsUrl);
     this.updateProxySettingsUI();
     initializeProxyUI(gMainPane);