corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1287588 - Fix parameter ordering in embed tags; r=bsmedberg

Browse Source 
MozReview-Commit-ID: 75ferxsBTgs
This commit is contained in:
Kyle Machulis
2016-08-18 10:19:33 -07:00
parent e5e1d44094
commit bc30ae6af3
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
dom/plugins/ipc/PluginModuleParent.cpp
View File

@@ -2687,6 +2687,7 @@ PluginModuleParent::NPP_NewInternal(NPMIMEType pluginType, NPP instance,
InfallibleTArray<nsCString>& values,
NPSavedData* saved, NPError* error)
{
MOZ_ASSERT(names.Length() == values.Length());
if (mPluginName.IsEmpty()) {
GetPluginDetails();
InitQuirksModes(nsDependentCString(pluginType));
@@ -2712,6 +2713,18 @@ PluginModuleParent::NPP_NewInternal(NPMIMEType pluginType, NPP instance,
new PluginInstanceParent(this, instance, strPluginType, mNPNIface);
if (mIsFlashPlugin) {
// In Bug 1287588, we found out that if the salign attribute is before
// the scale attribute in embed parameters, flash objects render
// incorrectly. This is most likely due to an order of operations
// problem in the plugin itself. Bug 1264270 changes the order in which
// parameters were passed, causing this bug to trigger on pages that
// formerly worked. In order to keep things working the way they were in
// Firefox <= 48, we reverse the order of parameters, making sure it
// happens before we possibly appends more parameters. This should keep
// parameters in the same order as prior versions.
std::reverse(names.begin(), names.end());
std::reverse(values.begin(), values.end());
parentInstance->InitMetadata(strPluginType, srcAttribute);
#ifdef XP_WIN
bool supportsAsyncRender = false;