corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1949840 - Rename dropTab and dropTabs methods now that we use them not just for dropping. r=dwalker,tabbrowser-reviewers

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D239189
This commit is contained in:
Dão Gottwald
2025-02-21 21:23:27 +00:00
parent c7e8b2807a
commit bbf8ed375a
2 changed files with 61 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

46
browser/components/tabbrowser/content/tabbrowser.js
View File

@@ -5788,11 +5788,43 @@
/**
* @param {MozTabbrowserTab} tab
* @param {MozTabbrowserTab|MozTabbrowserTabGroup} targetElement
* @param {boolean} dropBefore
*/
dropTab(tab, targetElement, dropBefore) {
moveTabBefore(tab, targetElement) {
this.#moveTabNextTo(tab, targetElement, true);
}
/**
* @param {MozTabbrowserTab[]} tabs
* @param {MozTabbrowserTab|MozTabbrowserTabGroup} targetElement
*/
moveTabsBefore(tabs, targetElement) {
this.#moveTabsNextTo(tabs, targetElement, true);
}
/**
* @param {MozTabbrowserTab} tab
* @param {MozTabbrowserTab|MozTabbrowserTabGroup} targetElement
*/
moveTabAfter(tab, targetElement) {
this.#moveTabNextTo(tab, targetElement, false);
}
/**
* @param {MozTabbrowserTab[]} tabs
* @param {MozTabbrowserTab|MozTabbrowserTabGroup} targetElement
*/
moveTabsAfter(tabs, targetElement) {
this.#moveTabsNextTo(tabs, targetElement, false);
}
/**
* @param {MozTabbrowserTab} tab
* @param {MozTabbrowserTab|MozTabbrowserTabGroup} targetElement
* @param {boolean} moveBefore
*/
#moveTabNextTo(tab, targetElement, moveBefore = false) {
this._handleTabMove(tab, () => {
if (dropBefore) {
if (moveBefore) {
this.tabContainer.insertBefore(tab, targetElement);
} else if (targetElement) {
targetElement.after(tab);
@@ -5805,12 +5837,12 @@
/**
* @param {MozTabbrowserTab[]} tabs
* @param {MozTabbrowserTab|MozTabbrowserTabGroup} targetElement
* @param {dropBefore} dropBefore
* @param {boolean} moveBefore
*/
dropTabs(tabs, targetElement, dropBefore) {
this.dropTab(tabs[0], targetElement, dropBefore);
#moveTabsNextTo(tabs, targetElement, moveBefore = false) {
this.#moveTabNextTo(tabs[0], targetElement, moveBefore);
for (let i = 1; i < tabs.length; i++) {
this.dropTab(tabs[i], tabs[i - 1]);
this.#moveTabNextTo(tabs[i], tabs[i - 1]);
}
}