corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1955417 - feat(webgpu): add support for unimplemented subgroups feature r=webgpu-reviewers,webidl,teoxoy,smaug

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D242426
This commit is contained in:
Erich Gubler
2025-03-26 03:27:10 +00:00
parent ef61b7b4e7
commit bbbd1302b5
3 changed files with 46 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
dom/webgpu/Adapter.cpp
View File

@@ -21,6 +21,42 @@ namespace mozilla::webgpu {
GPU_IMPL_CYCLE_COLLECTION(AdapterInfo, mParent) GPU_IMPL_CYCLE_COLLECTION(AdapterInfo, mParent)
GPU_IMPL_JS_WRAP(AdapterInfo) GPU_IMPL_JS_WRAP(AdapterInfo)
uint32_t AdapterInfo::SubgroupMinSize() const {
// From the spec. at
// <https://www.w3.org/TR/2025/CRD-webgpu-20250319/#dom-gpuadapterinfo-subgroupminsize>:
//
// > If `["subgroups"](https://www.w3.org/TR/webgpu/#subgroups)` is supported,
// > set `subgroupMinSize` to the smallest supported subgroup size. Otherwise,
// > set this value to 4.
// >
// > Note: To preserve privacy, the user agent may choose to not support some
// > features or provide values for the property which do not distinguish
// > different devices, but are still usable (e.g. use the default value of
// > 4 for all devices).
// TODO: When we support `subgroups`, use the supported amount instead:
// <https://bugzilla.mozilla.org/show_bug.cgi?id=1955417>
return 4;
}
uint32_t AdapterInfo::SubgroupMaxSize() const {
// From the spec. at
// <https://www.w3.org/TR/2025/CRD-webgpu-20250319/#dom-gpuadapterinfo-subgroupmaxsize>:
//
// > If `["subgroups"](https://www.w3.org/TR/webgpu/#subgroups)` is supported,
// > set `subgroupMaxSize` to the largest supported subgroup size. Otherwise,
// > set this value to 128.
// >
// > Note: To preserve privacy, the user agent may choose to not support some
// > features or provide values for the property which do not distinguish
// > different devices, but are still usable (e.g. use the default value of
// > 128 for all devices).
// TODO: When we support `subgroups`, use the supported amount instead:
// <https://bugzilla.mozilla.org/show_bug.cgi?id=1955417>
return 128;
}
bool AdapterInfo::IsFallbackAdapter() const { bool AdapterInfo::IsFallbackAdapter() const {
if (GetParentObject()->ShouldResistFingerprinting( if (GetParentObject()->ShouldResistFingerprinting(
RFPTarget::WebGPUIsFallbackAdapter)) { RFPTarget::WebGPUIsFallbackAdapter)) {
@@ -183,6 +219,11 @@ struct FeatureImplementationStatus {
// return implemented(WGPUWEBGPU_FEATURE_DUAL_SOURCE_BLENDING); // return implemented(WGPUWEBGPU_FEATURE_DUAL_SOURCE_BLENDING);
return unimplemented( return unimplemented(
"https://bugzilla.mozilla.org/show_bug.cgi?id=1924328"); "https://bugzilla.mozilla.org/show_bug.cgi?id=1924328");
case dom::GPUFeatureName::Subgroups:
// return implemented(WGPUWEBGPU_FEATURE_SUBGROUPS);
return unimplemented(
"https://bugzilla.mozilla.org/show_bug.cgi?id=1955417");
} }
MOZ_CRASH("Bad GPUFeatureName."); MOZ_CRASH("Bad GPUFeatureName.");
} }

2
dom/webgpu/Adapter.h
View File

@@ -63,6 +63,8 @@ class AdapterInfo final : public nsWrapperCache, public ChildOf<Adapter> {
void GetArchitecture(nsString& s) const { s = nsString(); } void GetArchitecture(nsString& s) const { s = nsString(); }
void GetDevice(nsString& s) const { s = nsString(); } void GetDevice(nsString& s) const { s = nsString(); }
void GetDescription(nsString& s) const { s = nsString(); } void GetDescription(nsString& s) const { s = nsString(); }
uint32_t SubgroupMinSize() const;
uint32_t SubgroupMaxSize() const;
bool IsFallbackAdapter() const; bool IsFallbackAdapter() const;
// Non-standard field getters; see also TODO BUGZILLA LINK // Non-standard field getters; see also TODO BUGZILLA LINK

3
dom/webidl/WebGPU.webidl
View File

@@ -70,6 +70,8 @@ interface GPUAdapterInfo {
readonly attribute DOMString architecture; readonly attribute DOMString architecture;
readonly attribute DOMString device; readonly attribute DOMString device;
readonly attribute DOMString description; readonly attribute DOMString description;
readonly attribute unsigned long subgroupMinSize;
readonly attribute unsigned long subgroupMaxSize;
readonly attribute boolean isFallbackAdapter; readonly attribute boolean isFallbackAdapter;
// Non-standard; see <https://bugzilla.mozilla.org/show_bug.cgi?id=1831994>. // Non-standard; see <https://bugzilla.mozilla.org/show_bug.cgi?id=1831994>.
@@ -148,6 +150,7 @@ enum GPUFeatureName {
"float32-blendable", "float32-blendable",
"clip-distances", "clip-distances",
"dual-source-blending", "dual-source-blending",
"subgroups",
}; };
[Func="mozilla::webgpu::Instance::PrefEnabled", [Func="mozilla::webgpu::Instance::PrefEnabled",