corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 777174: Change CallNonGenericMethod to take the predicate and implementation as template arguments, not function arguments. r=luke

Browse Source 
On x86_64 Fedora 17, this patch yields an 8ms (1.6%) speedup on SunSpider compared to the tree just prior to the introduction of CallNonGenericMethod, or a ~12ms (2.8%) speedup compared to the tree just after the introduction.
This commit is contained in:
Jim Blandy
2012-08-16 11:40:05 -07:00
parent b30f825d85
commit ba67e59fc0
12 changed files with 231 additions and 216 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
js/src/jsweakmap.cpp
View File

@@ -118,13 +118,13 @@ GetKeyArg(JSContext *cx, CallArgs &args)
return JS_UnwrapObject(&key);
}
static bool
JS_ALWAYS_INLINE bool
IsWeakMap(const Value &v)
{
return v.isObject() && v.toObject().hasClass(&WeakMapClass);
}
static bool
JS_ALWAYS_INLINE bool
WeakMap_has_impl(JSContext *cx, CallArgs args)
{
JS_ASSERT(IsWeakMap(args.thisv()));
@@ -149,14 +149,14 @@ WeakMap_has_impl(JSContext *cx, CallArgs args)
return true;
}
static JSBool
JSBool
WeakMap_has(JSContext *cx, unsigned argc, Value *vp)
{
CallArgs args = CallArgsFromVp(argc, vp);
return CallNonGenericMethod(cx, IsWeakMap, WeakMap_has_impl, args);
return CallNonGenericMethod<IsWeakMap, WeakMap_has_impl>(cx, args);
}
static bool
JS_ALWAYS_INLINE bool
WeakMap_get_impl(JSContext *cx, CallArgs args)
{
JS_ASSERT(IsWeakMap(args.thisv()));
@@ -181,14 +181,14 @@ WeakMap_get_impl(JSContext *cx, CallArgs args)
return true;
}
static JSBool
JSBool
WeakMap_get(JSContext *cx, unsigned argc, Value *vp)
{
CallArgs args = CallArgsFromVp(argc, vp);
return CallNonGenericMethod(cx, IsWeakMap, WeakMap_get_impl, args);
return CallNonGenericMethod<IsWeakMap, WeakMap_get_impl>(cx, args);
}
static bool
JS_ALWAYS_INLINE bool
WeakMap_delete_impl(JSContext *cx, CallArgs args)
{
JS_ASSERT(IsWeakMap(args.thisv()));
@@ -214,14 +214,14 @@ WeakMap_delete_impl(JSContext *cx, CallArgs args)
return true;
}
static JSBool
JSBool
WeakMap_delete(JSContext *cx, unsigned argc, Value *vp)
{
CallArgs args = CallArgsFromVp(argc, vp);
return CallNonGenericMethod(cx, IsWeakMap, WeakMap_delete_impl, args);
return CallNonGenericMethod<IsWeakMap, WeakMap_delete_impl>(cx, args);
}
static bool
JS_ALWAYS_INLINE bool
WeakMap_set_impl(JSContext *cx, CallArgs args)
{
JS_ASSERT(IsWeakMap(args.thisv()));
@@ -266,11 +266,11 @@ WeakMap_set_impl(JSContext *cx, CallArgs args)
return true;
}
static JSBool
JSBool
WeakMap_set(JSContext *cx, unsigned argc, Value *vp)
{
CallArgs args = CallArgsFromVp(argc, vp);
return CallNonGenericMethod(cx, IsWeakMap, WeakMap_set_impl, args);
return CallNonGenericMethod<IsWeakMap, WeakMap_set_impl>(cx, args);
}
JS_FRIEND_API(JSBool)