Bug 1432410 - Add tests in tree to make sure we don't regress with clang-tidy on static-analisys. Tests wrote in part by :sylvestre. r=gps

MozReview-Commit-ID: IWxzKfWNIHG

tools/clang-tidy/test/misc-assert-side-effect.cpp

@@ -0,0 +1,9 @@
+
+#include "structures.h"
+
+// misc-assert-side-effect
+void misc_assert_side_effect() {
+  int X = 0;
+  assert(X == 1);
+  assert(X = 1);
+}