Bug 1117639 - Remove AbortFrame() because it is dead. r=bas.

This commit is contained in:
Nicholas Nethercote
2015-01-05 15:54:51 -08:00
parent e334c07ce4
commit b6036175c1
7 changed files with 1 additions and 38 deletions

View File

@@ -165,8 +165,6 @@ enum SurfaceInitMode
* construct an EffectChain for the quad,
* call DrawQuad,
* call EndFrame.
* If the user has to stop compositing at any point before EndFrame, call
* AbortFrame.
* If the compositor is usually used for compositing but compositing is
* temporarily done without the compositor, call EndFrameForExternalComposition
* after compositing each frame so the compositor can remain internally
@@ -355,11 +353,6 @@ public:
*/
virtual void EndFrameForExternalComposition(const gfx::Matrix& aTransform) = 0;
/**
* Tidy up if BeginFrame has been called, but EndFrame won't be.
*/
virtual void AbortFrame() = 0;
/**
* Setup the viewport and projection matrix for rendering to a target of the
* given dimensions. The size and transform here will override those set in

View File

@@ -501,14 +501,5 @@ BasicCompositor::EndFrame()
mRenderTarget = nullptr;
}
void
BasicCompositor::AbortFrame()
{
mRenderTarget->mDrawTarget->PopClip();
mRenderTarget->mDrawTarget->PopClip();
mDrawTarget = nullptr;
mRenderTarget = nullptr;
}
}
}

View File

@@ -100,7 +100,6 @@ public:
{
NS_RUNTIMEABORT("We shouldn't ever hit this");
}
virtual void AbortFrame() MOZ_OVERRIDE;
virtual bool SupportsPartialTextureUpdate() MOZ_OVERRIDE { return true; }
virtual bool CanUseCanvasLayerForSize(const gfx::IntSize &aSize) MOZ_OVERRIDE { return true; }

View File

@@ -124,11 +124,6 @@ public:
*/
virtual void EndFrameForExternalComposition(const gfx::Matrix& aTransform) MOZ_OVERRIDE {}
/**
* Tidy up if BeginFrame has been called, but EndFrame won't be
*/
virtual void AbortFrame() MOZ_OVERRIDE {}
/**
* Setup the viewport and projection matrix for rendering
* to a window of the given dimensions.

View File

@@ -69,8 +69,6 @@ public:
virtual void EndFrameForExternalComposition(const gfx::Matrix& aTransform) MOZ_OVERRIDE {}
virtual void AbortFrame() MOZ_OVERRIDE {}
virtual void PrepareViewport(const gfx::IntSize& aSize) MOZ_OVERRIDE;
virtual bool SupportsPartialTextureUpdate() MOZ_OVERRIDE{ return true; }

View File

@@ -576,7 +576,7 @@ CompositorOGL::BeginFrame(const nsIntRegion& aInvalidRegion,
PROFILER_LABEL("CompositorOGL", "BeginFrame",
js::ProfileEntry::Category::GRAPHICS);
MOZ_ASSERT(!mFrameInProgress, "frame still in progress (should have called EndFrame or AbortFrame");
MOZ_ASSERT(!mFrameInProgress, "frame still in progress (should have called EndFrame");
mFrameInProgress = true;
gfx::Rect rect;
@@ -1322,18 +1322,6 @@ CompositorOGL::EndFrameForExternalComposition(const gfx::Matrix& aTransform)
}
}
void
CompositorOGL::AbortFrame()
{
mGLContext->fBindBuffer(LOCAL_GL_ARRAY_BUFFER, 0);
mFrameInProgress = false;
mCurrentRenderTarget = nullptr;
if (mTexturePool) {
mTexturePool->EndFrame();
}
}
void
CompositorOGL::SetDestinationSurfaceSize(const gfx::IntSize& aSize)
{

View File

@@ -239,7 +239,6 @@ public:
virtual void SetFBAcquireFence(Layer* aLayer) MOZ_OVERRIDE;
virtual FenceHandle GetReleaseFence() MOZ_OVERRIDE;
virtual void EndFrameForExternalComposition(const gfx::Matrix& aTransform) MOZ_OVERRIDE;
virtual void AbortFrame() MOZ_OVERRIDE;
virtual bool SupportsPartialTextureUpdate() MOZ_OVERRIDE;