Bug 1118768 - Redundant PopupNotifications.transitionsEnabled code removed, r=gijs

browser/base/content/test/general/browser_bug553455.js

@@ -846,13 +846,10 @@ function test() {
   Services.obs.addObserver(XPInstallObserver, "addon-install-failed", false);
   Services.obs.addObserver(XPInstallObserver, "addon-install-complete", false);
 
-  PopupNotifications.transitionsEnabled = false;
-
   registerCleanupFunction(function() {
     // Make sure no more test parts run in case we were timed out
     TESTS = [];
     PopupNotifications.panel.removeEventListener("popupshown", check_notification, false);
-    PopupNotifications.transitionsEnabled = true;
 
     AddonManager.getAllInstalls(function(aInstalls) {
       aInstalls.forEach(function(aInstall) {

browser/base/content/test/popupNotifications/head.js

@@ -88,11 +88,9 @@ const PREF_SECURITY_DELAY_INITIAL = Services.prefs.getIntPref("security.notifica
 function setup() {
   // Disable transitions as they slow the test down and we want to click the
   // mouse buttons in a predictable location.
-  PopupNotifications.transitionsEnabled = false;
 
   registerCleanupFunction(() => {
     PopupNotifications.buttonDelay = PREF_SECURITY_DELAY_INITIAL;
-    PopupNotifications.transitionsEnabled = true;
   });
 }
 

browser/base/content/test/social/head.js

@@ -73,13 +73,11 @@ function checkProviderPrefsEmpty(isError) {
 }
 
 function defaultFinishChecks() {
-  PopupNotifications.transitionsEnabled = true;
   checkProviderPrefsEmpty(true);
   finish();
 }
 
 function runSocialTestWithProvider(manifest, callback, finishcallback) {
-  PopupNotifications.transitionsEnabled = false;
 
   let SocialService = Cu.import("resource://gre/modules/SocialService.jsm", {}).SocialService;
 
@@ -172,7 +170,6 @@ function runSocialTests(tests, cbPreTest, cbPostTest, cbFinish) {
   info("runSocialTests: start test run with " + providersAtStart + " providers");
   window.focus();
 
-  PopupNotifications.transitionsEnabled = false;
 
   if (cbPreTest === undefined) {
     cbPreTest = function(cb) {cb()};

browser/modules/test/browser_SignInToWebsite.js

@@ -277,7 +277,6 @@ function test() {
     return;
   }
 
-  PopupNotifications.transitionsEnabled = false;
 
   registerCleanupFunction(cleanUp);
 
@@ -316,7 +315,6 @@ function cleanUp() {
   info("cleanup");
   resetState();
 
-  PopupNotifications.transitionsEnabled = true;
 
   for (let topic in gActiveObservers)
     Services.obs.removeObserver(gActiveObservers[topic], topic);

dom/indexedDB/test/browser_permissionsPromptAllow.js

@@ -11,8 +11,6 @@ function test()
 {
   waitForExplicitFinish();
 
-  PopupNotifications.transitionsEnabled = false;
-
   // We want a prompt.
   removePermission(testPageURL, "indexedDB");
   executeSoon(test1);
@@ -72,7 +70,6 @@ function test2()
       gBrowser.removeCurrentTab();
       unregisterAllPopupEventHandlers();
       removePermission(testPageURL, "indexedDB");
-      PopupNotifications.transitionsEnabled = true;
       executeSoon(finish);
     });
 

dom/indexedDB/test/browser_permissionsPromptDeny.js

@@ -11,7 +11,6 @@ function test()
 {
   waitForExplicitFinish();
   // We want the prompt.
-  PopupNotifications.transitionsEnabled = false;
   removePermission(testPageURL, "indexedDB");
   executeSoon(test1);
 }
@@ -69,7 +68,6 @@ function test2()
       gBrowser.selectedBrowser.docShell.QueryInterface(Ci.nsILoadContext).usePrivateBrowsing = false;
       unregisterAllPopupEventHandlers();
       gBrowser.removeCurrentTab();
-      PopupNotifications.transitionsEnabled = true;
       executeSoon(test3);
     });
 

dom/indexedDB/test/browser_quotaPromptAllow.js

@@ -12,7 +12,6 @@ function test()
 {
   waitForExplicitFinish();
   requestLongerTimeout(10);
-  PopupNotifications.transitionsEnabled = false;
   setPermission(testPageURL, "indexedDB");
   removePermission(testPageURL, "indexedDB-unlimited");
   Services.prefs.setIntPref("dom.indexedDB.warningQuota", 2);
@@ -110,7 +109,6 @@ function test2()
             unregisterAllPopupEventHandlers();
             removePermission(testPageURL, "indexedDB");
             Services.prefs.clearUserPref("dom.indexedDB.warningQuota");
-            PopupNotifications.transitionsEnabled = true;
             executeSoon(finish);
           });
           executeSoon(function() { dispatchEvent("indexedDB-done"); });

dom/indexedDB/test/browser_quotaPromptDatabases.js

@@ -12,7 +12,6 @@ function test()
 {
   waitForExplicitFinish();
   requestLongerTimeout(10);
-  PopupNotifications.transitionsEnabled = false;
   setPermission(testPageURL, "indexedDB");
   removePermission(testPageURL, "indexedDB-unlimited");
   Services.prefs.setIntPref("dom.indexedDB.warningQuota", 2);
@@ -45,7 +44,6 @@ function test1()
             gBrowser.removeCurrentTab();
             unregisterAllPopupEventHandlers();
             addMoreTest1Count = seenPopupCount;
-            PopupNotifications.transitionsEnabled = true;
             executeSoon(finish);
           });
           executeSoon(function() { dispatchEvent("indexedDB-done"); });

dom/indexedDB/test/browser_quotaPromptDelete.js

@@ -12,7 +12,6 @@ function test()
 {
   waitForExplicitFinish();
   requestLongerTimeout(10);
-  PopupNotifications.transitionsEnabled = false;
   setPermission(testPageURL, "indexedDB");
   removePermission(testPageURL, "indexedDB-unlimited");
   Services.prefs.setIntPref("dom.indexedDB.warningQuota", 2);
@@ -56,7 +55,6 @@ function test1()
                      "Correct permission set");
                   gBrowser.removeCurrentTab();
                   unregisterAllPopupEventHandlers();
-                  PopupNotifications.transitionsEnabled = true;
                   executeSoon(finish);
                 });
                 executeSoon(function() { dispatchEvent("indexedDB-done"); });

dom/indexedDB/test/browser_quotaPromptDeny.js

@@ -12,7 +12,6 @@ function test()
 {
   waitForExplicitFinish();
   requestLongerTimeout(10);
-  PopupNotifications.transitionsEnabled = false;
   setPermission(testPageURL, "indexedDB");
   removePermission(testPageURL, "indexedDB-unlimited");
   Services.prefs.setIntPref("dom.indexedDB.warningQuota", 2);
@@ -50,7 +49,6 @@ function test1()
             gBrowser.removeCurrentTab();
             unregisterAllPopupEventHandlers();
             addMoreTest1Count = seenPopupCount;
-            PopupNotifications.transitionsEnabled = true;
             executeSoon(test2);
           });
           executeSoon(function() { dispatchEvent("indexedDB-done"); });