corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 852996 - MarkupView leaks the whole Inspector after being closed r=dcamp

Browse Source
This commit is contained in:
Michael Ratcliffe
2013-07-01 11:59:28 +01:00
parent 02e14ddd06
commit b3d88e520e
1 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
browser/devtools/markupview/markup-view.js
View File

@@ -312,11 +312,13 @@ MarkupView.prototype = {
} else {
var container = new RootContainer(this, aNode);
this._elt.appendChild(container.elt);
if (this._rootNode) {
this._rootNode.removeEventListener("load", this, true);
}
this._rootNode = aNode;
aNode.addEventListener("load", function MP_watch_contentLoaded(aEvent) {
// Fake a childList mutation here.
this._mutationObserver([{target: aEvent.target, type: "childList"}]);
}.bind(this), true);
aNode.addEventListener("load", this, true);
}
this._containers.set(aNode, container);
@@ -334,6 +336,11 @@ MarkupView.prototype = {
return container;
},
handleEvent: function MT_handleEvent(aEvent) {
// Fake a childList mutation here.
this._mutationObserver([{target: aEvent.target, type: "childList"}]);
},
/**
* Mutation observer used for included nodes.
*/
@@ -648,7 +655,7 @@ MarkupView.prototype = {
this._frame.contentWindow.removeEventListener("underflow", this._boundResizePreview, true);
delete this._boundUpdatePreview;
this._frame.contentWindow.removeEventListener("keydown", this._boundKeyDown, true);
this._frame.contentWindow.removeEventListener("keydown", this._boundKeyDown, false);
delete this._boundKeyDown;
this._inspector.selection.off("new-node", this._boundOnNewSelection);
@@ -659,6 +666,11 @@ MarkupView.prototype = {
delete this._containers;
this._observer.disconnect();
delete this._observer;
if (this._rootNode) {
this._rootNode.removeEventListener("load", this, true);
delete this._rootNode;
}
},
/**