corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1914244 - Move the allow in private browsing checkbox to the web extension permissions prompt. r=willdurand,zmckenney,geckoview-reviewers,owlish,android-reviewers

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D219839
This commit is contained in:
Arturo Mejia
2024-10-02 20:32:43 +00:00
parent 70a3e6e8d8
commit b210c87c25
26 changed files with 555 additions and 237 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
mobile/android/android-components/samples/browser/src/main/java/org/mozilla/samples/browser/addons/AddonsFragment.kt
View File

@@ -68,10 +68,6 @@ class AddonsFragment : Fragment(), AddonsManagerAdapterDelegate {
findPreviousPermissionDialogFragment()?.let { dialog ->
dialog.onPositiveButtonClicked = onConfirmPermissionButtonClicked
}
findPreviousInstallationDialogFragment()?.let { dialog ->
dialog.onConfirmButtonClicked = onConfirmInstallationButtonClicked
}
}
private fun bindRecyclerView(rootView: View) {
@@ -174,7 +170,6 @@ class AddonsFragment : Fragment(), AddonsManagerAdapterDelegate {
}
val dialog = AddonInstallationDialogFragment.newInstance(
addon = addon,
onConfirmButtonClicked = onConfirmInstallationButtonClicked,
)
if (!isAlreadyADialogCreated() && isAdded) {
@@ -182,16 +177,7 @@ class AddonsFragment : Fragment(), AddonsManagerAdapterDelegate {
}
}
private val onConfirmInstallationButtonClicked: ((Addon, Boolean) -> Unit) = { addon, allowInPrivateBrowsing ->
if (allowInPrivateBrowsing) {
requireContext().components.addonManager.setAddonAllowedInPrivateBrowsing(
addon,
allowInPrivateBrowsing,
)
}
}
private val onConfirmPermissionButtonClicked: ((Addon) -> Unit) = { addon ->
private val onConfirmPermissionButtonClicked: ((Addon, Boolean) -> Unit) = { addon, _ ->
val includedBinding = OverlayAddOnProgressBinding.bind(binding.addonProgressOverlay.addonProgressOverlay)
includedBinding.root.visibility = View.VISIBLE