diff --git a/accessible/atk/ApplicationAccessibleWrap.cpp b/accessible/atk/ApplicationAccessibleWrap.cpp index 78c7f6047dff..fa62ea06d1e3 100644 --- a/accessible/atk/ApplicationAccessibleWrap.cpp +++ b/accessible/atk/ApplicationAccessibleWrap.cpp @@ -17,8 +17,7 @@ using namespace mozilla::a11y; // ApplicationAccessibleWrap -ApplicationAccessibleWrap::ApplicationAccessibleWrap() - : ApplicationAccessible() {} +ApplicationAccessibleWrap::ApplicationAccessibleWrap() {} ApplicationAccessibleWrap::~ApplicationAccessibleWrap() { AccessibleWrap::ShutdownAtkObject(); diff --git a/accessible/atk/RootAccessibleWrap.cpp b/accessible/atk/RootAccessibleWrap.cpp index 7d5534c564aa..41916a005583 100644 --- a/accessible/atk/RootAccessibleWrap.cpp +++ b/accessible/atk/RootAccessibleWrap.cpp @@ -13,8 +13,7 @@ using namespace mozilla::a11y; -GtkWindowAccessible::GtkWindowAccessible(AtkObject* aAccessible) - : DummyAccessible() { +GtkWindowAccessible::GtkWindowAccessible(AtkObject* aAccessible) { g_object_ref(aAccessible); mAtkObject = aAccessible; } diff --git a/accessible/base/nsAccessibilityService.cpp b/accessible/base/nsAccessibilityService.cpp index 291118019a90..1f6a6ef3acac 100644 --- a/accessible/base/nsAccessibilityService.cpp +++ b/accessible/base/nsAccessibilityService.cpp @@ -397,9 +397,7 @@ xpcAccessibleApplication* nsAccessibilityService::gXPCApplicationAccessible = uint32_t nsAccessibilityService::gConsumers = 0; nsAccessibilityService::nsAccessibilityService() - : DocManager(), - FocusManager(), - mHTMLMarkupMap(ArrayLength(sHTMLMarkupMapList)), + : mHTMLMarkupMap(ArrayLength(sHTMLMarkupMapList)), mMathMLMarkupMap(ArrayLength(sMathMLMarkupMapList)), mXULMarkupMap(ArrayLength(sXULMarkupMapList)) {} diff --git a/accessible/generic/LocalAccessible.cpp b/accessible/generic/LocalAccessible.cpp index 8e0ae71e4901..1136efe42a87 100644 --- a/accessible/generic/LocalAccessible.cpp +++ b/accessible/generic/LocalAccessible.cpp @@ -101,12 +101,10 @@ NS_IMPL_CYCLE_COLLECTING_ADDREF(LocalAccessible) NS_IMPL_CYCLE_COLLECTING_RELEASE_WITH_DESTROY(LocalAccessible, LastRelease()) LocalAccessible::LocalAccessible(nsIContent* aContent, DocAccessible* aDoc) - : Accessible(), - mContent(aContent), + : mContent(aContent), mDoc(aDoc), mParent(nullptr), mIndexInParent(-1), - mBounds(), mFirstLineStart(-1), mStateFlags(0), mContextFlags(0), diff --git a/accessible/ipc/RemoteAccessible.h b/accessible/ipc/RemoteAccessible.h index ed8e88511f2c..9215fd7bc56b 100644 --- a/accessible/ipc/RemoteAccessible.h +++ b/accessible/ipc/RemoteAccessible.h @@ -413,8 +413,7 @@ class RemoteAccessible : public Accessible, public HyperTextAccessibleBase { } explicit RemoteAccessible(DocAccessibleParent* aThisAsDoc) - : Accessible(), - mParent(kNoParent), + : mParent(kNoParent), mDoc(aThisAsDoc), mWrapper(0), mID(0), diff --git a/devtools/shared/heapsnapshot/tests/gtest/DeserializedStackFrameUbiStackFrames.cpp b/devtools/shared/heapsnapshot/tests/gtest/DeserializedStackFrameUbiStackFrames.cpp index 272a41f2ca7b..52e896cb650f 100644 --- a/devtools/shared/heapsnapshot/tests/gtest/DeserializedStackFrameUbiStackFrames.cpp +++ b/devtools/shared/heapsnapshot/tests/gtest/DeserializedStackFrameUbiStackFrames.cpp @@ -18,7 +18,7 @@ using testing::ReturnRef; // A mock DeserializedStackFrame for testing. struct MockDeserializedStackFrame : public DeserializedStackFrame { - MockDeserializedStackFrame() : DeserializedStackFrame() {} + MockDeserializedStackFrame() {} }; DEF_TEST(DeserializedStackFrameUbiStackFrames, { diff --git a/devtools/shared/heapsnapshot/tests/gtest/DevTools.h b/devtools/shared/heapsnapshot/tests/gtest/DevTools.h index ffa28b2011ce..7da17eb9db3a 100644 --- a/devtools/shared/heapsnapshot/tests/gtest/DevTools.h +++ b/devtools/shared/heapsnapshot/tests/gtest/DevTools.h @@ -99,7 +99,7 @@ class MOZ_STACK_CLASS FakeNode { JS::Zone* zone; size_t size; - explicit FakeNode() : edges(), compartment(nullptr), zone(nullptr), size(1) {} + explicit FakeNode() : compartment(nullptr), zone(nullptr), size(1) {} }; namespace JS { diff --git a/docshell/base/nsDocShellLoadState.cpp b/docshell/base/nsDocShellLoadState.cpp index 95cbfbc8e321..3431c1e36fc7 100644 --- a/docshell/base/nsDocShellLoadState.cpp +++ b/docshell/base/nsDocShellLoadState.cpp @@ -222,7 +222,6 @@ nsDocShellLoadState::nsDocShellLoadState(nsIURI* aURI, uint64_t aLoadIdentifier) mOriginalFrameSrc(false), mIsFormSubmission(false), mLoadType(LOAD_NORMAL), - mTarget(), mSrcdocData(VoidString()), mLoadFlags(0), mInternalLoadFlags(0), diff --git a/dom/animation/Animation.cpp b/dom/animation/Animation.cpp index e75473d5bbf0..5acf566c1dfe 100644 --- a/dom/animation/Animation.cpp +++ b/dom/animation/Animation.cpp @@ -2051,7 +2051,7 @@ void Animation::UpdatePendingAnimationTracker(AnimationTimeline* aOldTimeline, class AsyncFinishNotification : public MicroTaskRunnable { public: explicit AsyncFinishNotification(Animation* aAnimation) - : MicroTaskRunnable(), mAnimation(aAnimation) {} + : mAnimation(aAnimation) {} virtual void Run(AutoSlowOperation& aAso) override { mAnimation->DoFinishNotificationImmediately(this); diff --git a/dom/base/FragmentOrElement.cpp b/dom/base/FragmentOrElement.cpp index 4c89ac1d0acf..029040d83f6b 100644 --- a/dom/base/FragmentOrElement.cpp +++ b/dom/base/FragmentOrElement.cpp @@ -559,8 +559,7 @@ size_t nsIContent::nsExtendedContentSlots::SizeOfExcludingThis( return 0; } -FragmentOrElement::nsDOMSlots::nsDOMSlots() - : nsIContent::nsContentSlots(), mDataset(nullptr) { +FragmentOrElement::nsDOMSlots::nsDOMSlots() : mDataset(nullptr) { MOZ_COUNT_CTOR(nsDOMSlots); } diff --git a/dom/base/ImageEncoder.cpp b/dom/base/ImageEncoder.cpp index cdc34f2cff73..7013e978a87d 100644 --- a/dom/base/ImageEncoder.cpp +++ b/dom/base/ImageEncoder.cpp @@ -84,7 +84,6 @@ class EncodingCompleteEvent final : public DiscardableRunnable { EncodeCompleteCallback* aEncodeCompleteCallback) : DiscardableRunnable("EncodingCompleteEvent"), mImgSize(0), - mType(), mImgData(nullptr), mEncodeCompleteCallback(aEncodeCompleteCallback), mFailed(false) { diff --git a/dom/base/InProcessBrowserChildMessageManager.cpp b/dom/base/InProcessBrowserChildMessageManager.cpp index 937372fcc24e..63d4ecef1610 100644 --- a/dom/base/InProcessBrowserChildMessageManager.cpp +++ b/dom/base/InProcessBrowserChildMessageManager.cpp @@ -66,7 +66,7 @@ class nsAsyncMessageToParent : public nsSameProcessAsyncMessageBase, public: explicit nsAsyncMessageToParent( InProcessBrowserChildMessageManager* aBrowserChild) - : nsSameProcessAsyncMessageBase(), mBrowserChild(aBrowserChild) {} + : mBrowserChild(aBrowserChild) {} virtual nsresult HandleMessage() override { RefPtr fl = mBrowserChild->GetFrameLoader(); diff --git a/dom/base/nsFrameLoader.cpp b/dom/base/nsFrameLoader.cpp index 9e5b6907b4d7..1ac806f3be70 100644 --- a/dom/base/nsFrameLoader.cpp +++ b/dom/base/nsFrameLoader.cpp @@ -2952,8 +2952,7 @@ class nsAsyncMessageToChild : public nsSameProcessAsyncMessageBase, public Runnable { public: explicit nsAsyncMessageToChild(nsFrameLoader* aFrameLoader) - : nsSameProcessAsyncMessageBase(), - mozilla::Runnable("nsAsyncMessageToChild"), + : mozilla::Runnable("nsAsyncMessageToChild"), mFrameLoader(aFrameLoader) {} NS_IMETHOD Run() override { diff --git a/dom/base/nsFrameMessageManager.cpp b/dom/base/nsFrameMessageManager.cpp index 29716c35dbe6..fb9467acea76 100644 --- a/dom/base/nsFrameMessageManager.cpp +++ b/dom/base/nsFrameMessageManager.cpp @@ -1403,8 +1403,7 @@ class nsAsyncMessageToSameProcessChild : public nsSameProcessAsyncMessageBase, public Runnable { public: nsAsyncMessageToSameProcessChild() - : nsSameProcessAsyncMessageBase(), - mozilla::Runnable("nsAsyncMessageToSameProcessChild") {} + : mozilla::Runnable("nsAsyncMessageToSameProcessChild") {} NS_IMETHOD Run() override { nsFrameMessageManager* ppm = nsFrameMessageManager::GetChildProcessManager(); @@ -1498,7 +1497,7 @@ class nsAsyncMessageToSameProcessParent : public nsSameProcessAsyncMessageBase, public SameProcessMessageQueue::Runnable { public: - nsAsyncMessageToSameProcessParent() : nsSameProcessAsyncMessageBase() {} + nsAsyncMessageToSameProcessParent() {} nsresult HandleMessage() override { nsFrameMessageManager* ppm = nsFrameMessageManager::sSameProcessParentManager; diff --git a/dom/base/nsGlobalWindowOuter.cpp b/dom/base/nsGlobalWindowOuter.cpp index f2ea19a78a60..0946fdd0f87e 100644 --- a/dom/base/nsGlobalWindowOuter.cpp +++ b/dom/base/nsGlobalWindowOuter.cpp @@ -1261,7 +1261,7 @@ const nsOuterWindowProxy nsOuterWindowProxy::singleton; class nsChromeOuterWindowProxy : public nsOuterWindowProxy { public: - constexpr nsChromeOuterWindowProxy() : nsOuterWindowProxy() {} + constexpr nsChromeOuterWindowProxy() {} const char* className(JSContext* cx, JS::Handle wrapper) const override; diff --git a/dom/base/nsIContent.h b/dom/base/nsIContent.h index ffafb532fb75..ef527d785f4a 100644 --- a/dom/base/nsIContent.h +++ b/dom/base/nsIContent.h @@ -661,7 +661,7 @@ class nsIContent : public nsINode { class nsContentSlots : public nsINode::nsSlots { public: - nsContentSlots() : nsINode::nsSlots(), mExtendedSlots(0) {} + nsContentSlots() : mExtendedSlots(0) {} ~nsContentSlots() { if (!(mExtendedSlots & sNonOwningExtendedSlotsFlag)) { diff --git a/dom/base/nsImageLoadingContent.cpp b/dom/base/nsImageLoadingContent.cpp index ab80f2df0b6d..53d66b305886 100644 --- a/dom/base/nsImageLoadingContent.cpp +++ b/dom/base/nsImageLoadingContent.cpp @@ -347,8 +347,7 @@ already_AddRefed nsImageLoadingContent::QueueDecodeAsync( public: QueueDecodeTask(nsImageLoadingContent* aOwner, Promise* aPromise, uint32_t aRequestGeneration) - : MicroTaskRunnable(), - mOwner(aOwner), + : mOwner(aOwner), mPromise(aPromise), mRequestGeneration(aRequestGeneration) {} diff --git a/dom/base/nsWindowSizes.h b/dom/base/nsWindowSizes.h index 1f8633ac7e58..aceabac99f9d 100644 --- a/dom/base/nsWindowSizes.h +++ b/dom/base/nsWindowSizes.h @@ -193,8 +193,6 @@ class nsWindowSizes { explicit nsWindowSizes(mozilla::SizeOfState& aState) : FOR_EACH_SIZE(ZERO_SIZE) mDOMEventTargetsCount(0), mDOMEventListenersCount(0), - mArenaSizes(), - mStyleSizes(), mState(aState) {} void addToTabSizes(nsTabSizes* aSizes) const { diff --git a/dom/bindings/nsScriptError.cpp b/dom/bindings/nsScriptError.cpp index 53c1ba04b747..c44ccaf39f25 100644 --- a/dom/bindings/nsScriptError.cpp +++ b/dom/bindings/nsScriptError.cpp @@ -21,16 +21,10 @@ #include "mozilla/BasePrincipal.h" nsScriptErrorBase::nsScriptErrorBase() - : mMessage(), - mMessageName(), - mSourceName(), - mCssSelectors(), - mSourceId(0), + : mSourceId(0), mLineNumber(0), - mSourceLine(), mColumnNumber(0), mFlags(0), - mCategory(), mOuterWindowID(0), mInnerWindowID(0), mMicroSecondTimeStamp(0), @@ -473,11 +467,7 @@ bool nsScriptErrorBase::ComputeIsFromChromeContext( NS_IMPL_ISUPPORTS(nsScriptError, nsIConsoleMessage, nsIScriptError) nsScriptErrorNote::nsScriptErrorNote() - : mMessage(), - mSourceName(), - mSourceId(0), - mLineNumber(0), - mColumnNumber(0) {} + : mSourceId(0), mLineNumber(0), mColumnNumber(0) {} nsScriptErrorNote::~nsScriptErrorNote() = default; diff --git a/dom/canvas/CanvasPattern.cpp b/dom/canvas/CanvasPattern.cpp index 9e3219b76e5d..5ecba1e17253 100644 --- a/dom/canvas/CanvasPattern.cpp +++ b/dom/canvas/CanvasPattern.cpp @@ -14,7 +14,6 @@ CanvasPattern::CanvasPattern(CanvasRenderingContext2D* aContext, : mContext(aContext), mSurface(aSurface), mPrincipal(principalForSecurityCheck), - mTransform(), mForceWriteOnly(forceWriteOnly), mCORSUsed(CORSUsed), mRepeat(aRepeat) {} diff --git a/dom/debugger/DebuggerNotificationManager.h b/dom/debugger/DebuggerNotificationManager.h index f68b2b3836ab..6f46f777ae59 100644 --- a/dom/debugger/DebuggerNotificationManager.h +++ b/dom/debugger/DebuggerNotificationManager.h @@ -37,7 +37,7 @@ class DebuggerNotificationManager final : public nsISupports { } explicit DebuggerNotificationManager(nsIGlobalObject* aDebuggeeGlobal) - : mDebuggeeGlobal(aDebuggeeGlobal), mNotificationObservers() {} + : mDebuggeeGlobal(aDebuggeeGlobal) {} bool Attach(DebuggerNotificationObserver* aObserver); bool Detach(DebuggerNotificationObserver* aObserver); diff --git a/dom/debugger/DebuggerNotificationObserver.cpp b/dom/debugger/DebuggerNotificationObserver.cpp index b8210030701d..94fa37251af6 100644 --- a/dom/debugger/DebuggerNotificationObserver.cpp +++ b/dom/debugger/DebuggerNotificationObserver.cpp @@ -39,7 +39,7 @@ DebuggerNotificationObserver::Constructor(GlobalObject& aGlobal, DebuggerNotificationObserver::DebuggerNotificationObserver( nsIGlobalObject* aOwnerGlobal) - : mEventListenerCallbacks(), mOwnerGlobal(aOwnerGlobal) {} + : mOwnerGlobal(aOwnerGlobal) {} JSObject* DebuggerNotificationObserver::WrapObject( JSContext* aCx, JS::Handle aGivenProto) { diff --git a/dom/events/EventListenerManager.cpp b/dom/events/EventListenerManager.cpp index d9482fbba390..025a29d9f751 100644 --- a/dom/events/EventListenerManager.cpp +++ b/dom/events/EventListenerManager.cpp @@ -134,7 +134,7 @@ EventListenerManagerBase::EventListenerManagerBase() } EventListenerManager::EventListenerManager(EventTarget* aTarget) - : EventListenerManagerBase(), mTarget(aTarget) { + : mTarget(aTarget) { NS_ASSERTION(aTarget, "unexpected null pointer"); if (mIsMainThreadELM) { diff --git a/dom/fs/api/FileSystemWritableFileStream.cpp b/dom/fs/api/FileSystemWritableFileStream.cpp index c3096deee9e7..cc06dc4a3d58 100644 --- a/dom/fs/api/FileSystemWritableFileStream.cpp +++ b/dom/fs/api/FileSystemWritableFileStream.cpp @@ -219,7 +219,6 @@ FileSystemWritableFileStream::FileSystemWritableFileStream( mManager(aManager), mActor(std::move(aActor)), mTaskQueue(aTaskQueue), - mWorkerRef(), mStreamParams(std::move(aStreamParams)), mMetadata(std::move(aMetadata)), mCloseHandler(MakeAndAddRef()), diff --git a/dom/fs/child/FileSystemDirectoryIteratorFactory.cpp b/dom/fs/child/FileSystemDirectoryIteratorFactory.cpp index 91cc3fc04238..5c9b9e60bc0e 100644 --- a/dom/fs/child/FileSystemDirectoryIteratorFactory.cpp +++ b/dom/fs/child/FileSystemDirectoryIteratorFactory.cpp @@ -81,7 +81,6 @@ class DoubleBufferQueueImpl using DataType = FileSystemEntryMetadata; explicit DoubleBufferQueueImpl(const FileSystemEntryMetadata& aMetadata) : mEntryId(aMetadata.entryId()), - mData(), mWithinPageEnd(0u), mWithinPageIndex(0u), mCurrentPageIsLastPage(true), diff --git a/dom/fs/test/gtest/FileSystemMocks.h b/dom/fs/test/gtest/FileSystemMocks.h index de30f7c53dbc..1926b2e86a64 100644 --- a/dom/fs/test/gtest/FileSystemMocks.h +++ b/dom/fs/test/gtest/FileSystemMocks.h @@ -127,10 +127,7 @@ class TestPromiseListener : public PromiseNativeHandler, public WaitablePromiseListener { public: TestPromiseListener() - : mIsDone(std::make_shared(false)), - mTimer(), - mOnSuccess(), - mOnError() { + : mIsDone(std::make_shared(false)), mOnSuccess(), mOnError() { ClearDone(); } diff --git a/dom/html/ConstraintValidation.cpp b/dom/html/ConstraintValidation.cpp index 096e401e82cc..7335be819405 100644 --- a/dom/html/ConstraintValidation.cpp +++ b/dom/html/ConstraintValidation.cpp @@ -56,7 +56,7 @@ bool ConstraintValidation::CheckValidity() { return nsIConstraintValidation::CheckValidity(*content); } -ConstraintValidation::ConstraintValidation() : nsIConstraintValidation() {} +ConstraintValidation::ConstraintValidation() {} void ConstraintValidation::SetCustomValidity(const nsAString& aError) { mCustomValidity.Assign(aError); diff --git a/dom/html/HTMLImageElement.cpp b/dom/html/HTMLImageElement.cpp index 9ff3d1cb9e40..64885e70c2de 100644 --- a/dom/html/HTMLImageElement.cpp +++ b/dom/html/HTMLImageElement.cpp @@ -84,8 +84,7 @@ class ImageLoadTask final : public MicroTaskRunnable { public: ImageLoadTask(HTMLImageElement* aElement, bool aAlwaysLoad, bool aUseUrgentStartForChannel) - : MicroTaskRunnable(), - mElement(aElement), + : mElement(aElement), mAlwaysLoad(aAlwaysLoad), mUseUrgentStartForChannel(aUseUrgentStartForChannel) { mDocument = aElement->OwnerDoc(); diff --git a/dom/html/ImageDocument.cpp b/dom/html/ImageDocument.cpp index 0809854304ee..e5dcc4351fed 100644 --- a/dom/html/ImageDocument.cpp +++ b/dom/html/ImageDocument.cpp @@ -122,8 +122,7 @@ ImageListener::OnStartRequest(nsIRequest* request) { } ImageDocument::ImageDocument() - : MediaDocument(), - mVisibleWidth(0.0), + : mVisibleWidth(0.0), mVisibleHeight(0.0), mImageWidth(0), mImageHeight(0), diff --git a/dom/html/MediaDocument.cpp b/dom/html/MediaDocument.cpp index 07ad412f363b..e59a5f35f18a 100644 --- a/dom/html/MediaDocument.cpp +++ b/dom/html/MediaDocument.cpp @@ -106,8 +106,7 @@ const char* const MediaDocument::sFormatNames[4] = { "" // eWithDimAndFile }; -MediaDocument::MediaDocument() - : nsHTMLDocument(), mDidInitialDocumentSetup(false) { +MediaDocument::MediaDocument() : mDidInitialDocumentSetup(false) { mCompatMode = eCompatibility_FullStandards; } MediaDocument::~MediaDocument() = default; diff --git a/dom/html/nsGenericHTMLFrameElement.h b/dom/html/nsGenericHTMLFrameElement.h index 72d785be24ba..28a333850515 100644 --- a/dom/html/nsGenericHTMLFrameElement.h +++ b/dom/html/nsGenericHTMLFrameElement.h @@ -46,7 +46,6 @@ class nsGenericHTMLFrameElement : public nsGenericHTMLElement, already_AddRefed&& aNodeInfo, mozilla::dom::FromParser aFromParser) : nsGenericHTMLElement(std::move(aNodeInfo)), - nsBrowserElement(), mSrcLoadHappened(false), mNetworkCreated(aFromParser == mozilla::dom::FROM_PARSER_NETWORK), mBrowserFrameListenersRegistered(false), diff --git a/dom/indexedDB/ActorsChild.cpp b/dom/indexedDB/ActorsChild.cpp index 00d1f63b01c1..03f89e2c485d 100644 --- a/dom/indexedDB/ActorsChild.cpp +++ b/dom/indexedDB/ActorsChild.cpp @@ -144,9 +144,7 @@ class MOZ_STACK_CLASS AutoSetCurrentTransaction final { AutoSetCurrentTransaction& operator=(AutoSetCurrentTransaction&&) = delete; explicit AutoSetCurrentTransaction(Maybe aTransaction) - : mTransaction(aTransaction), - mPreviousTransaction(), - mThreadLocal(nullptr) { + : mTransaction(aTransaction), mThreadLocal(nullptr) { if (aTransaction) { BackgroundChildImpl::ThreadLocal* threadLocal = BackgroundChildImpl::GetThreadLocalForCurrentThread(); diff --git a/dom/ipc/BrowserParent.cpp b/dom/ipc/BrowserParent.cpp index 0ff51987a35e..fdb56438da0a 100644 --- a/dom/ipc/BrowserParent.cpp +++ b/dom/ipc/BrowserParent.cpp @@ -284,8 +284,6 @@ BrowserParent::BrowserParent(ContentParent* aManager, const TabId& aTabId, mBrowserBridgeParent(nullptr), mBrowserHost(nullptr), mContentCache(*this), - mRemoteLayerTreeOwner{}, - mChildToParentConversionMatrix{}, mRect(0, 0, 0, 0), mDimensions(0, 0), mDPI(0), @@ -293,10 +291,7 @@ BrowserParent::BrowserParent(ContentParent* aManager, const TabId& aTabId, mDefaultScale(0), mUpdatedDimensions(false), mSizeMode(nsSizeMode_Normal), - mClientOffset{}, - mChromeOffset{}, mCreatingWindow(false), - mDelayedFrameScripts{}, mVsyncParent(nullptr), mMarkedDestroying(false), mIsDestroyed(false), diff --git a/dom/ipc/SharedMap.cpp b/dom/ipc/SharedMap.cpp index fcf5ed7da093..60c07a3c004e 100644 --- a/dom/ipc/SharedMap.cpp +++ b/dom/ipc/SharedMap.cpp @@ -39,7 +39,7 @@ static inline void AlignTo(size_t* aOffset, size_t aAlign) { } } -SharedMap::SharedMap() : DOMEventTargetHelper() {} +SharedMap::SharedMap() {} SharedMap::SharedMap(nsIGlobalObject* aGlobal, const FileDescriptor& aMapFile, size_t aMapSize, nsTArray>&& aBlobs) @@ -240,7 +240,7 @@ void SharedMap::MaybeRebuild() const { Unused << const_cast(this)->MaybeRebuild(); } -WritableSharedMap::WritableSharedMap() : SharedMap() { +WritableSharedMap::WritableSharedMap() { mWritable = true; // Serialize the initial empty contents of the map immediately so that we // always have a file descriptor to send to callers of CloneMapFile(). diff --git a/dom/media/ADTSDemuxer.cpp b/dom/media/ADTSDemuxer.cpp index eb78014b7370..29ea27046129 100644 --- a/dom/media/ADTSDemuxer.cpp +++ b/dom/media/ADTSDemuxer.cpp @@ -118,7 +118,7 @@ class FrameHeader { // header and side info. class Frame { public: - Frame() : mOffset(0), mHeader() {} + Frame() : mOffset(0) {} uint64_t Offset() const { return mOffset; } size_t Length() const { diff --git a/dom/media/CanvasCaptureMediaStream.cpp b/dom/media/CanvasCaptureMediaStream.cpp index a9d16b895ba6..377243540c22 100644 --- a/dom/media/CanvasCaptureMediaStream.cpp +++ b/dom/media/CanvasCaptureMediaStream.cpp @@ -23,9 +23,7 @@ namespace mozilla::dom { OutputStreamDriver::OutputStreamDriver(SourceMediaTrack* aSourceStream, const PrincipalHandle& aPrincipalHandle) - : FrameCaptureListener(), - mSourceStream(aSourceStream), - mPrincipalHandle(aPrincipalHandle) { + : mSourceStream(aSourceStream), mPrincipalHandle(aPrincipalHandle) { MOZ_ASSERT(NS_IsMainThread()); MOZ_ASSERT(mSourceStream); } diff --git a/dom/media/DeviceInputTrack.cpp b/dom/media/DeviceInputTrack.cpp index 5e67cd9b6c69..b1fcce3cd1b6 100644 --- a/dom/media/DeviceInputTrack.cpp +++ b/dom/media/DeviceInputTrack.cpp @@ -466,8 +466,7 @@ NonNativeInputTrack::NonNativeInputTrack( const PrincipalHandle& aPrincipalHandle) : DeviceInputTrack(aSampleRate, aDeviceId, aPrincipalHandle), mAudioSource(nullptr), - mSourceIdNumber(0), - mGraphDriverThreadId(std::thread::id()) {} + mSourceIdNumber(0) {} void NonNativeInputTrack::DestroyImpl() { MOZ_ASSERT(mGraph->OnGraphThreadOrNotRunning()); diff --git a/dom/media/gtest/TestWebMWriter.cpp b/dom/media/gtest/TestWebMWriter.cpp index ee1f38731110..da2189ea9818 100644 --- a/dom/media/gtest/TestWebMWriter.cpp +++ b/dom/media/gtest/TestWebMWriter.cpp @@ -66,7 +66,7 @@ const uint32_t FIXED_FRAMESIZE = 500; class TestWebMWriter : public WebMWriter { public: - TestWebMWriter() : WebMWriter() {} + TestWebMWriter() {} // When we append an I-Frame into WebM muxer, the muxer will treat previous // data as "a cluster". diff --git a/dom/media/mp4/SinfParser.cpp b/dom/media/mp4/SinfParser.cpp index f6da3b587daa..660bf3024622 100644 --- a/dom/media/mp4/SinfParser.cpp +++ b/dom/media/mp4/SinfParser.cpp @@ -11,7 +11,7 @@ namespace mozilla { -Sinf::Sinf(Box& aBox) : mDefaultIVSize(0), mDefaultEncryptionType() { +Sinf::Sinf(Box& aBox) : mDefaultIVSize(0) { SinfParser parser(aBox); if (parser.GetSinf().IsValid()) { *this = parser.GetSinf(); diff --git a/dom/media/mp4/SinfParser.h b/dom/media/mp4/SinfParser.h index 084892854c9a..d0a09a1d98dc 100644 --- a/dom/media/mp4/SinfParser.h +++ b/dom/media/mp4/SinfParser.h @@ -18,7 +18,7 @@ class Sinf : public Atom { public: Sinf() : mDefaultIVSize(0), - mDefaultEncryptionType(), + mDefaultCryptByteBlock(0), mDefaultSkipByteBlock(0) {} explicit Sinf(Box& aBox); diff --git a/dom/media/ogg/OggWriter.cpp b/dom/media/ogg/OggWriter.cpp index 6f29d441242c..f43ffcbb5dd7 100644 --- a/dom/media/ogg/OggWriter.cpp +++ b/dom/media/ogg/OggWriter.cpp @@ -10,8 +10,7 @@ namespace mozilla { -OggWriter::OggWriter() - : ContainerWriter(), mOggStreamState(), mOggPage(), mPacket() { +OggWriter::OggWriter() : mOggStreamState(), mOggPage(), mPacket() { if (NS_FAILED(Init())) { LOG("ERROR! Fail to initialize the OggWriter."); } diff --git a/dom/media/webaudio/AudioListener.cpp b/dom/media/webaudio/AudioListener.cpp index 2e00af976405..f9d5903c3d0d 100644 --- a/dom/media/webaudio/AudioListener.cpp +++ b/dom/media/webaudio/AudioListener.cpp @@ -15,7 +15,7 @@ namespace mozilla::dom { NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE(AudioListener, mContext) AudioListenerEngine::AudioListenerEngine() - : mPosition(), mFrontVector(0., 0., -1.), mRightVector(1., 0., 0.) {} + : mFrontVector(0., 0., -1.), mRightVector(1., 0., 0.) {} void AudioListenerEngine::RecvListenerEngineEvent( AudioListenerEngine::AudioListenerParameter aParameter, @@ -46,7 +46,7 @@ const ThreeDPoint& AudioListenerEngine::RightVector() const { AudioListener::AudioListener(AudioContext* aContext) : mContext(aContext), mEngine(new AudioListenerEngine()), - mPosition(), + mFrontVector(0., 0., -1.), mRightVector(1., 0., 0.) { MOZ_ASSERT(aContext); diff --git a/dom/media/webaudio/blink/ReverbConvolver.cpp b/dom/media/webaudio/blink/ReverbConvolver.cpp index 6965a285351d..dcaf6e746779 100644 --- a/dom/media/webaudio/blink/ReverbConvolver.cpp +++ b/dom/media/webaudio/blink/ReverbConvolver.cpp @@ -62,7 +62,6 @@ ReverbConvolver::ReverbConvolver(const float* impulseResponseData, bool useBackgroundThreads, bool* aAllocationFailure) : m_impulseResponseLength(impulseResponseLength), - m_accumulationBuffer(), m_inputBuffer(InputBufferSize), m_backgroundThread("ConvolverWorker"), m_backgroundThreadMonitor("ConvolverMonitor"), diff --git a/dom/media/webm/WebMWriter.cpp b/dom/media/webm/WebMWriter.cpp index 96c416909155..568c9b8e4dc5 100644 --- a/dom/media/webm/WebMWriter.cpp +++ b/dom/media/webm/WebMWriter.cpp @@ -10,8 +10,7 @@ namespace mozilla { -WebMWriter::WebMWriter() - : ContainerWriter(), mEbmlComposer(new EbmlComposer()) {} +WebMWriter::WebMWriter() : mEbmlComposer(new EbmlComposer()) {} WebMWriter::~WebMWriter() { // Out-of-line dtor so mEbmlComposer UniquePtr can delete a complete type. diff --git a/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp b/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp index ab2a1bdf7412..3689a5b4a0c1 100644 --- a/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp +++ b/dom/media/webrtc/jsapi/PeerConnectionImpl.cpp @@ -331,7 +331,6 @@ bool IsPrivateBrowsing(nsPIDOMWindowInner* aWindow) { PeerConnectionImpl::PeerConnectionImpl(const GlobalObject* aGlobal) : mTimeCard(MOZ_LOG_TEST(logModuleInfo, LogLevel::Error) ? create_timecard() : nullptr), - mJsConfiguration(), mSignalingState(RTCSignalingState::Stable), mIceConnectionState(RTCIceConnectionState::New), mIceGatheringState(RTCIceGatheringState::New), diff --git a/dom/media/webrtc/libwebrtcglue/AudioConduit.cpp b/dom/media/webrtc/libwebrtcglue/AudioConduit.cpp index 0c0ef835c4c1..49f049cd215c 100644 --- a/dom/media/webrtc/libwebrtcglue/AudioConduit.cpp +++ b/dom/media/webrtc/libwebrtcglue/AudioConduit.cpp @@ -156,7 +156,6 @@ WebrtcAudioConduit::WebrtcAudioConduit( : mCall(std::move(aCall)), mSendTransport(this), mRecvTransport(this), - mRecvStreamConfig(), mRecvStream(nullptr), mSendStreamConfig(&mSendTransport), mSendStream(nullptr), diff --git a/dom/media/webrtc/sdp/SdpAttribute.h b/dom/media/webrtc/sdp/SdpAttribute.h index 080d86953c51..0d0edf487890 100644 --- a/dom/media/webrtc/sdp/SdpAttribute.h +++ b/dom/media/webrtc/sdp/SdpAttribute.h @@ -738,7 +738,7 @@ class SdpImageattrAttributeList : public SdpAttribute { class Imageattr { public: - Imageattr() : pt(), sendAll(false), recvAll(false) {} + Imageattr() : sendAll(false), recvAll(false) {} void Serialize(std::ostream& os) const; // TODO: Remove this Bug 1469702 bool Parse(std::istream& is, std::string* error); diff --git a/dom/media/webrtc/transport/nricectx.cpp b/dom/media/webrtc/transport/nricectx.cpp index 697eecdb0736..a3520ca5083b 100644 --- a/dom/media/webrtc/transport/nricectx.cpp +++ b/dom/media/webrtc/transport/nricectx.cpp @@ -261,7 +261,6 @@ NrIceCtx::NrIceCtx(const std::string& name) gathering_state_(ICE_CTX_GATHER_INIT), name_(name), ice_controlling_set_(false), - streams_(), ctx_(nullptr), peer_(nullptr), ice_handler_vtbl_(nullptr), diff --git a/dom/media/webrtc/transport/nriceresolverfake.cpp b/dom/media/webrtc/transport/nriceresolverfake.cpp index 93ef37efc13d..f7e5920a4dfa 100644 --- a/dom/media/webrtc/transport/nriceresolverfake.cpp +++ b/dom/media/webrtc/transport/nriceresolverfake.cpp @@ -57,10 +57,7 @@ extern "C" { namespace mozilla { NrIceResolverFake::NrIceResolverFake() - : vtbl_(new nr_resolver_vtbl), - addrs_(), - delay_ms_(100), - allocated_resolvers_(0) { + : vtbl_(new nr_resolver_vtbl), delay_ms_(100), allocated_resolvers_(0) { vtbl_->destroy = &NrIceResolverFake::destroy; vtbl_->resolve = &NrIceResolverFake::resolve; vtbl_->cancel = &NrIceResolverFake::cancel; diff --git a/dom/media/webrtc/transport/nrinterfaceprioritizer.cpp b/dom/media/webrtc/transport/nrinterfaceprioritizer.cpp index f022f8c29a6d..76e2f00cb0a3 100644 --- a/dom/media/webrtc/transport/nrinterfaceprioritizer.cpp +++ b/dom/media/webrtc/transport/nrinterfaceprioritizer.cpp @@ -17,10 +17,7 @@ namespace { class LocalAddress { public: LocalAddress() - : ifname_(), - addr_(), - key_(), - is_vpn_(-1), + : is_vpn_(-1), estimated_speed_(-1), type_preference_(-1), ip_version_(-1) {} @@ -164,7 +161,7 @@ class LocalAddress { class InterfacePrioritizer { public: - InterfacePrioritizer() : local_addrs_(), preference_map_(), sorted_(false) {} + InterfacePrioritizer() : sorted_(false) {} int add(const nr_local_addr* iface) { LocalAddress addr; diff --git a/dom/media/webrtc/transport/stun_socket_filter.cpp b/dom/media/webrtc/transport/stun_socket_filter.cpp index b568f97a408b..9051582e454f 100644 --- a/dom/media/webrtc/transport/stun_socket_filter.cpp +++ b/dom/media/webrtc/transport/stun_socket_filter.cpp @@ -100,7 +100,7 @@ static std::ostream& operator<<(std::ostream& aStream, UINT12 aId) { class STUNUDPSocketFilter : public nsISocketFilter { public: - STUNUDPSocketFilter() : white_list_(), pending_requests_() {} + STUNUDPSocketFilter() {} // Allocated/freed and used on the PBackground IPC thread NS_DECL_ISUPPORTS @@ -287,8 +287,7 @@ class PendingSTUNId { class STUNTCPSocketFilter : public nsISocketFilter { public: - STUNTCPSocketFilter() - : white_listed_(false), pending_request_ids_(), response_allowed_ids_() {} + STUNTCPSocketFilter() : white_listed_(false) {} // Allocated/freed and used on the PBackground IPC thread NS_DECL_ISUPPORTS diff --git a/dom/media/webrtc/transport/test/buffered_stun_socket_unittest.cpp b/dom/media/webrtc/transport/test/buffered_stun_socket_unittest.cpp index e6a9cd38a2d3..37bd7dc02e56 100644 --- a/dom/media/webrtc/transport/test/buffered_stun_socket_unittest.cpp +++ b/dom/media/webrtc/transport/test/buffered_stun_socket_unittest.cpp @@ -33,8 +33,7 @@ static size_t kStunMessageLen = sizeof(kStunMessage); class BufferedStunSocketTest : public MtransportTest { public: - BufferedStunSocketTest() - : MtransportTest(), dummy_(nullptr), test_socket_(nullptr) {} + BufferedStunSocketTest() : dummy_(nullptr), test_socket_(nullptr) {} ~BufferedStunSocketTest() { nr_socket_destroy(&test_socket_); } diff --git a/dom/media/webrtc/transport/test/ice_unittest.cpp b/dom/media/webrtc/transport/test/ice_unittest.cpp index d87fa0b0da2d..d6b89ed3803a 100644 --- a/dom/media/webrtc/transport/test/ice_unittest.cpp +++ b/dom/media/webrtc/transport/test/ice_unittest.cpp @@ -115,7 +115,7 @@ static std::string Resolve(const std::string& fqdn, int address_family) { class StunTest : public MtransportTest { public: - StunTest() : MtransportTest() {} + StunTest() {} void SetUp() override { MtransportTest::SetUp(); @@ -353,7 +353,6 @@ class IceTestPeer : public sigslot::has_slots<> { : name_(name), ice_ctx_(NrIceCtx::Create(name)), offerer_(offerer), - candidates_(), stream_counter_(0), shutting_down_(false), gathering_complete_(false), @@ -363,7 +362,6 @@ class IceTestPeer : public sigslot::has_slots<> { ice_reached_checking_(false), received_(0), sent_(0), - fake_resolver_(), dns_resolver_(new NrIceResolver()), remote_(nullptr), candidate_filter_(nullptr), diff --git a/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp b/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp index d0c3ae6e5395..029cda34d42b 100644 --- a/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp +++ b/dom/media/webrtc/transport/test/multi_tcp_socket_unittest.cpp @@ -32,8 +32,7 @@ namespace { class MultiTcpSocketTest : public MtransportTest { public: - MultiTcpSocketTest() - : MtransportTest(), socks(3, nullptr), readable(false), ice_ctx_() {} + MultiTcpSocketTest() : socks(3, nullptr), readable(false) {} void SetUp() { MtransportTest::SetUp(); diff --git a/dom/media/webrtc/transport/test/nrappkit_unittest.cpp b/dom/media/webrtc/transport/test/nrappkit_unittest.cpp index 893bcb794aed..faebf79b9dea 100644 --- a/dom/media/webrtc/transport/test/nrappkit_unittest.cpp +++ b/dom/media/webrtc/transport/test/nrappkit_unittest.cpp @@ -26,7 +26,7 @@ namespace { class TimerTest : public MtransportTest { public: - TimerTest() : MtransportTest(), handle_(nullptr), fired_(false) {} + TimerTest() : handle_(nullptr), fired_(false) {} virtual ~TimerTest() = default; int ArmTimer(int timeout) { diff --git a/dom/media/webrtc/transport/test/runnable_utils_unittest.cpp b/dom/media/webrtc/transport/test/runnable_utils_unittest.cpp index 70707b148f40..b4d85029b55e 100644 --- a/dom/media/webrtc/transport/test/runnable_utils_unittest.cpp +++ b/dom/media/webrtc/transport/test/runnable_utils_unittest.cpp @@ -128,7 +128,7 @@ class TargetClass { class RunnableArgsTest : public MtransportTest { public: - RunnableArgsTest() : MtransportTest(), ran_(0), cl_(&ran_) {} + RunnableArgsTest() : ran_(0), cl_(&ran_) {} void Test1Arg() { Runnable* r = WrapRunnable(&cl_, &TargetClass::m1, 1); @@ -149,7 +149,7 @@ class RunnableArgsTest : public MtransportTest { class DispatchTest : public MtransportTest { public: - DispatchTest() : MtransportTest(), ran_(0), cl_(&ran_) {} + DispatchTest() : ran_(0), cl_(&ran_) {} void SetUp() { MtransportTest::SetUp(); diff --git a/dom/media/webrtc/transport/test/sockettransportservice_unittest.cpp b/dom/media/webrtc/transport/test/sockettransportservice_unittest.cpp index f9ac6832d2b2..dd5d9122414a 100644 --- a/dom/media/webrtc/transport/test/sockettransportservice_unittest.cpp +++ b/dom/media/webrtc/transport/test/sockettransportservice_unittest.cpp @@ -28,8 +28,7 @@ namespace { class SocketTransportServiceTest : public MtransportTest { public: SocketTransportServiceTest() - : MtransportTest(), - received_(0), + : received_(0), readpipe_(nullptr), writepipe_(nullptr), registered_(false) {} diff --git a/dom/media/webrtc/transport/test/stunserver.cpp b/dom/media/webrtc/transport/test/stunserver.cpp index b5fce21e19cd..8247d9f4abf7 100644 --- a/dom/media/webrtc/transport/test/stunserver.cpp +++ b/dom/media/webrtc/transport/test/stunserver.cpp @@ -386,7 +386,7 @@ void TestStunServer::ShutdownInstance() { struct DeferredStunOperation { DeferredStunOperation(TestStunServer* server, const char* data, size_t len, nr_transport_addr* addr, nr_socket* sock) - : server_(server), buffer_(), sock_(sock) { + : server_(server), sock_(sock) { buffer_.Copy(reinterpret_cast(data), len); nr_transport_addr_copy(&addr_, addr); } diff --git a/dom/media/webrtc/transport/test/test_nr_socket_unittest.cpp b/dom/media/webrtc/transport/test/test_nr_socket_unittest.cpp index af2779accdc9..7e5e4748a49c 100644 --- a/dom/media/webrtc/transport/test/test_nr_socket_unittest.cpp +++ b/dom/media/webrtc/transport/test/test_nr_socket_unittest.cpp @@ -32,13 +32,7 @@ namespace mozilla { class TestNrSocketTest : public MtransportTest { public: - TestNrSocketTest() - : MtransportTest(), - wait_done_for_main_(false), - sts_(), - public_addrs_(), - private_addrs_(), - nats_() {} + TestNrSocketTest() : wait_done_for_main_(false) {} void SetUp() override { MtransportTest::SetUp(); diff --git a/dom/media/webrtc/transport/test/transport_unittests.cpp b/dom/media/webrtc/transport/test/transport_unittests.cpp index 956913a839be..7729151adef6 100644 --- a/dom/media/webrtc/transport/test/transport_unittests.cpp +++ b/dom/media/webrtc/transport/test/transport_unittests.cpp @@ -167,7 +167,7 @@ class TransportLayerLossy : public TransportLayer { class TlsParser { public: - TlsParser(const unsigned char* data, size_t len) : buffer_(), offset_(0) { + TlsParser(const unsigned char* data, size_t len) : offset_(0) { buffer_.Copy(data, len); } @@ -221,8 +221,7 @@ class TlsParser { class DtlsRecordParser { public: - DtlsRecordParser(const unsigned char* data, size_t len) - : buffer_(), offset_(0) { + DtlsRecordParser(const unsigned char* data, size_t len) : offset_(0) { buffer_.Copy(data, len); } @@ -324,7 +323,7 @@ class DtlsInspectorInjector : public DtlsRecordInspector { class DtlsInspectorRecordHandshakeMessage : public DtlsRecordInspector { public: explicit DtlsInspectorRecordHandshakeMessage(uint8_t handshake_type) - : handshake_type_(handshake_type), buffer_() {} + : handshake_type_(handshake_type) {} virtual void OnRecord(TransportLayer* layer, uint8_t content_type, const unsigned char* data, size_t len) { @@ -440,13 +439,9 @@ class TransportTestPeer : public sigslot::has_slots<> { lossy_(new TransportLayerLossy()), dtls_(new TransportLayerDtls()), identity_(DtlsIdentity::Generate()), - ice_ctx_(), - streams_(), peer_(nullptr), gathering_complete_(false), digest_("sha-1"_ns), - enabled_cipersuites_(), - disabled_cipersuites_(), test_utils_(utils) { NrIceCtx::InitializeGlobals(NrIceCtx::GlobalConfig()); ice_ctx_ = NrIceCtx::Create(name); diff --git a/dom/media/webrtc/transport/test/turn_unittest.cpp b/dom/media/webrtc/transport/test/turn_unittest.cpp index ae5d0386d9c5..bf5696164dad 100644 --- a/dom/media/webrtc/transport/test/turn_unittest.cpp +++ b/dom/media/webrtc/transport/test/turn_unittest.cpp @@ -71,8 +71,7 @@ static std::string kDummyTurnServer("192.0.2.1"); // From RFC 5737 class TurnClient : public MtransportTest { public: TurnClient() - : MtransportTest(), - real_socket_(nullptr), + : real_socket_(nullptr), net_socket_(nullptr), buffered_socket_(nullptr), net_fd_(nullptr), diff --git a/dom/media/webrtc/transport/test/webrtcproxychannel_unittest.cpp b/dom/media/webrtc/transport/test/webrtcproxychannel_unittest.cpp index 5bfddc7a3f40..b07de280a06e 100644 --- a/dom/media/webrtc/transport/test/webrtcproxychannel_unittest.cpp +++ b/dom/media/webrtc/transport/test/webrtcproxychannel_unittest.cpp @@ -504,8 +504,7 @@ void FakeWebrtcTCPSocket::InvokeOnRead(nsTArray&& aReadData) { class WebrtcTCPSocketTest : public MtransportTest { public: WebrtcTCPSocketTest() - : MtransportTest(), - mSocketThread(nullptr), + : mSocketThread(nullptr), mSocketTransport(nullptr), mInputStream(nullptr), mOutputStream(nullptr), diff --git a/dom/media/webrtc/transport/test_nr_socket.h b/dom/media/webrtc/transport/test_nr_socket.h index c6a796c063eb..ffde821ac8c2 100644 --- a/dom/media/webrtc/transport/test_nr_socket.h +++ b/dom/media/webrtc/transport/test_nr_socket.h @@ -159,8 +159,7 @@ class TestNat { block_tls_(false), error_code_for_drop_(0), delay_stun_resp_ms_(0), - nat_delegate_(nullptr), - sockets_() {} + nat_delegate_(nullptr) {} bool has_port_mappings() const; @@ -293,10 +292,7 @@ class TestNrSocket : public NrSocketBase { DeferredPacket(TestNrSocket* sock, const void* data, size_t len, int flags, const nr_transport_addr* addr, RefPtr internal_socket) - : socket_(sock), - buffer_(), - flags_(flags), - internal_socket_(internal_socket) { + : socket_(sock), flags_(flags), internal_socket_(internal_socket) { buffer_.Copy(reinterpret_cast(data), len); nr_transport_addr_copy(&to_, addr); } diff --git a/dom/media/webrtc/transport/transportlayer.h b/dom/media/webrtc/transport/transportlayer.h index 47287ab4e02e..262ac7f687ca 100644 --- a/dom/media/webrtc/transport/transportlayer.h +++ b/dom/media/webrtc/transport/transportlayer.h @@ -37,7 +37,7 @@ class TransportLayer : public sigslot::has_slots<> { enum State { TS_NONE, TS_INIT, TS_CONNECTING, TS_OPEN, TS_CLOSED, TS_ERROR }; // Is this a stream or datagram flow - TransportLayer() : state_(TS_NONE), flow_id_(), downward_(nullptr) {} + TransportLayer() : state_(TS_NONE), downward_(nullptr) {} virtual ~TransportLayer() = default; diff --git a/dom/media/webrtc/transport/transportlayerdtls.h b/dom/media/webrtc/transport/transportlayerdtls.h index 078b266e8b0f..d68a6e77d5f9 100644 --- a/dom/media/webrtc/transport/transportlayerdtls.h +++ b/dom/media/webrtc/transport/transportlayerdtls.h @@ -43,7 +43,7 @@ struct Packet; class TransportLayerNSPRAdapter { public: explicit TransportLayerNSPRAdapter(TransportLayer* output) - : output_(output), input_(), enabled_(true) {} + : output_(output), enabled_(true) {} void PacketReceived(MediaPacket& packet); int32_t Recv(void* buf, int32_t buflen); diff --git a/dom/media/webrtc/transport/transportlayerloopback.h b/dom/media/webrtc/transport/transportlayerloopback.h index 6801af8189bf..754be9603aae 100644 --- a/dom/media/webrtc/transport/transportlayerloopback.h +++ b/dom/media/webrtc/transport/transportlayerloopback.h @@ -28,7 +28,6 @@ class TransportLayerLoopback : public TransportLayer { TransportLayerLoopback() : peer_(nullptr), timer_(nullptr), - packets_(), packets_lock_(nullptr), deliverer_(nullptr), combinePackets_(false) {} diff --git a/dom/media/webrtc/transportbridge/MediaPipeline.cpp b/dom/media/webrtc/transportbridge/MediaPipeline.cpp index d575ff4bba93..5d85404a7159 100644 --- a/dom/media/webrtc/transportbridge/MediaPipeline.cpp +++ b/dom/media/webrtc/transportbridge/MediaPipeline.cpp @@ -262,7 +262,6 @@ MediaPipeline::MediaPipeline(const std::string& aPc, mRtpBytesSent(0), mRtpBytesReceived(0), mPc(aPc), - mFilter(), mRtpHeaderExtensionMap(new webrtc::RtpHeaderExtensionMap()), mPacketDumper(PacketDumper::GetPacketDumper(mPc)) {} diff --git a/dom/quota/OriginOperations.cpp b/dom/quota/OriginOperations.cpp index 82f33b77530c..00a133db05b6 100644 --- a/dom/quota/OriginOperations.cpp +++ b/dom/quota/OriginOperations.cpp @@ -2586,8 +2586,7 @@ void EstimateOp::CloseDirectory() { ListOriginsOp::ListOriginsOp(MovingNotNull> aQuotaManager) : OpenStorageDirectoryHelper(std::move(aQuotaManager), - "dom::quota::ListOriginsOp"), - TraverseRepositoryHelper() { + "dom::quota::ListOriginsOp") { AssertIsOnOwningThread(); } diff --git a/dom/quota/OriginParser.h b/dom/quota/OriginParser.h index 9b9b2c0d64ff..cc4d0d1a11e5 100644 --- a/dom/quota/OriginParser.h +++ b/dom/quota/OriginParser.h @@ -78,7 +78,6 @@ class MOZ_STACK_CLASS OriginParser final { explicit OriginParser(const nsACString& aOrigin) : mOrigin(aOrigin), mTokenizer(aOrigin, '+'), - mPort(), mSchemeType(eNone), mState(eExpectingAppIdOrScheme), mInIsolatedMozBrowser(false), diff --git a/dom/script/ScriptLoader.cpp b/dom/script/ScriptLoader.cpp index fccc4262f7d5..6f7f8f1ed222 100644 --- a/dom/script/ScriptLoader.cpp +++ b/dom/script/ScriptLoader.cpp @@ -1918,7 +1918,7 @@ using ModuleCompileTask = class ScriptDecodeTask final : public CompileOrDecodeTask { public: explicit ScriptDecodeTask(const JS::TranscodeRange& aRange) - : CompileOrDecodeTask(), mRange(aRange) {} + : mRange(aRange) {} nsresult Init(JS::DecodeOptions& aOptions) { nsresult rv = InitFrontendContext(); diff --git a/dom/script/ScriptSettings.cpp b/dom/script/ScriptSettings.cpp index 1f2d92bcb5d9..3b39538e5184 100644 --- a/dom/script/ScriptSettings.cpp +++ b/dom/script/ScriptSettings.cpp @@ -643,7 +643,7 @@ AutoJSContext::AutoJSContext() : mCx(nullptr) { AutoJSContext::operator JSContext*() const { return mCx; } -AutoSafeJSContext::AutoSafeJSContext() : AutoJSAPI() { +AutoSafeJSContext::AutoSafeJSContext() { MOZ_ASSERT(NS_IsMainThread()); DebugOnly ok = Init(xpc::UnprivilegedJunkScope()); diff --git a/dom/streams/ReadableStreamBYOBReader.cpp b/dom/streams/ReadableStreamBYOBReader.cpp index 13ba6085664e..f40d98bb93e6 100644 --- a/dom/streams/ReadableStreamBYOBReader.cpp +++ b/dom/streams/ReadableStreamBYOBReader.cpp @@ -36,8 +36,7 @@ NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(ReadableStreamBYOBReader) NS_INTERFACE_MAP_END_INHERITING(ReadableStreamGenericReader) ReadableStreamBYOBReader::ReadableStreamBYOBReader(nsISupports* aGlobal) - : ReadableStreamGenericReader(do_QueryInterface(aGlobal)), - mReadIntoRequests({}) {} + : ReadableStreamGenericReader(do_QueryInterface(aGlobal)) {} JSObject* ReadableStreamBYOBReader::WrapObject( JSContext* aCx, JS::Handle aGivenProto) { diff --git a/dom/streams/ReadableStreamDefaultReader.cpp b/dom/streams/ReadableStreamDefaultReader.cpp index ff95fb37a85e..ebc86d477895 100644 --- a/dom/streams/ReadableStreamDefaultReader.cpp +++ b/dom/streams/ReadableStreamDefaultReader.cpp @@ -48,8 +48,7 @@ NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(ReadableStreamDefaultReader) NS_INTERFACE_MAP_END_INHERITING(ReadableStreamGenericReader) ReadableStreamDefaultReader::ReadableStreamDefaultReader(nsISupports* aGlobal) - : ReadableStreamGenericReader(do_QueryInterface(aGlobal)), - nsWrapperCache() {} + : ReadableStreamGenericReader(do_QueryInterface(aGlobal)) {} ReadableStreamDefaultReader::~ReadableStreamDefaultReader() { mReadRequests.clear(); diff --git a/dom/svg/DOMSVGPathSeg.h b/dom/svg/DOMSVGPathSeg.h index 706a2040640b..7447526aaeed 100644 --- a/dom/svg/DOMSVGPathSeg.h +++ b/dom/svg/DOMSVGPathSeg.h @@ -208,7 +208,7 @@ class DOMSVGPathSeg : public nsWrapperCache { class DOMSVGPathSegClosePath : public DOMSVGPathSeg { public: - DOMSVGPathSegClosePath() : DOMSVGPathSeg() {} + DOMSVGPathSegClosePath() {} IMPL_SVGPATHSEG_SUBCLASS_COMMON(ClosePath, dom::SVGPathSeg_Binding::PATHSEG_CLOSEPATH) @@ -222,7 +222,7 @@ class DOMSVGPathSegClosePath : public DOMSVGPathSeg { class DOMSVGPathSegMovetoAbs : public DOMSVGPathSeg { public: - DOMSVGPathSegMovetoAbs(float x, float y) : DOMSVGPathSeg() { + DOMSVGPathSegMovetoAbs(float x, float y) { mArgs[0] = x; mArgs[1] = y; } @@ -241,7 +241,7 @@ class DOMSVGPathSegMovetoAbs : public DOMSVGPathSeg { class DOMSVGPathSegMovetoRel : public DOMSVGPathSeg { public: - DOMSVGPathSegMovetoRel(float x, float y) : DOMSVGPathSeg() { + DOMSVGPathSegMovetoRel(float x, float y) { mArgs[0] = x; mArgs[1] = y; } @@ -260,7 +260,7 @@ class DOMSVGPathSegMovetoRel : public DOMSVGPathSeg { class DOMSVGPathSegLinetoAbs : public DOMSVGPathSeg { public: - DOMSVGPathSegLinetoAbs(float x, float y) : DOMSVGPathSeg() { + DOMSVGPathSegLinetoAbs(float x, float y) { mArgs[0] = x; mArgs[1] = y; } @@ -279,7 +279,7 @@ class DOMSVGPathSegLinetoAbs : public DOMSVGPathSeg { class DOMSVGPathSegLinetoRel : public DOMSVGPathSeg { public: - DOMSVGPathSegLinetoRel(float x, float y) : DOMSVGPathSeg() { + DOMSVGPathSegLinetoRel(float x, float y) { mArgs[0] = x; mArgs[1] = y; } @@ -299,8 +299,7 @@ class DOMSVGPathSegLinetoRel : public DOMSVGPathSeg { class DOMSVGPathSegCurvetoCubicAbs : public DOMSVGPathSeg { public: DOMSVGPathSegCurvetoCubicAbs(float x1, float y1, float x2, float y2, float x, - float y) - : DOMSVGPathSeg() { + float y) { mArgs[0] = x1; mArgs[1] = y1; mArgs[2] = x2; @@ -332,8 +331,7 @@ class DOMSVGPathSegCurvetoCubicAbs : public DOMSVGPathSeg { class DOMSVGPathSegCurvetoCubicRel : public DOMSVGPathSeg { public: DOMSVGPathSegCurvetoCubicRel(float x1, float y1, float x2, float y2, float x, - float y) - : DOMSVGPathSeg() { + float y) { mArgs[0] = x1; mArgs[1] = y1; mArgs[2] = x2; @@ -364,8 +362,7 @@ class DOMSVGPathSegCurvetoCubicRel : public DOMSVGPathSeg { class DOMSVGPathSegCurvetoQuadraticAbs : public DOMSVGPathSeg { public: - DOMSVGPathSegCurvetoQuadraticAbs(float x1, float y1, float x, float y) - : DOMSVGPathSeg() { + DOMSVGPathSegCurvetoQuadraticAbs(float x1, float y1, float x, float y) { mArgs[0] = x1; mArgs[1] = y1; mArgs[2] = x; @@ -391,8 +388,7 @@ class DOMSVGPathSegCurvetoQuadraticAbs : public DOMSVGPathSeg { class DOMSVGPathSegCurvetoQuadraticRel : public DOMSVGPathSeg { public: - DOMSVGPathSegCurvetoQuadraticRel(float x1, float y1, float x, float y) - : DOMSVGPathSeg() { + DOMSVGPathSegCurvetoQuadraticRel(float x1, float y1, float x, float y) { mArgs[0] = x1; mArgs[1] = y1; mArgs[2] = x; @@ -419,8 +415,7 @@ class DOMSVGPathSegCurvetoQuadraticRel : public DOMSVGPathSeg { class DOMSVGPathSegArcAbs : public DOMSVGPathSeg { public: DOMSVGPathSegArcAbs(float r1, float r2, float angle, bool largeArcFlag, - bool sweepFlag, float x, float y) - : DOMSVGPathSeg() { + bool sweepFlag, float x, float y) { mArgs[0] = r1; mArgs[1] = r2; mArgs[2] = angle; @@ -455,8 +450,7 @@ class DOMSVGPathSegArcAbs : public DOMSVGPathSeg { class DOMSVGPathSegArcRel : public DOMSVGPathSeg { public: DOMSVGPathSegArcRel(float r1, float r2, float angle, bool largeArcFlag, - bool sweepFlag, float x, float y) - : DOMSVGPathSeg() { + bool sweepFlag, float x, float y) { mArgs[0] = r1; mArgs[1] = r2; mArgs[2] = angle; @@ -490,9 +484,7 @@ class DOMSVGPathSegArcRel : public DOMSVGPathSeg { class DOMSVGPathSegLinetoHorizontalAbs : public DOMSVGPathSeg { public: - explicit DOMSVGPathSegLinetoHorizontalAbs(float x) : DOMSVGPathSeg() { - mArgs[0] = x; - } + explicit DOMSVGPathSegLinetoHorizontalAbs(float x) { mArgs[0] = x; } IMPL_SVGPATHSEG_SUBCLASS_COMMON( LinetoHorizontalAbs, @@ -507,9 +499,7 @@ class DOMSVGPathSegLinetoHorizontalAbs : public DOMSVGPathSeg { class DOMSVGPathSegLinetoHorizontalRel : public DOMSVGPathSeg { public: - explicit DOMSVGPathSegLinetoHorizontalRel(float x) : DOMSVGPathSeg() { - mArgs[0] = x; - } + explicit DOMSVGPathSegLinetoHorizontalRel(float x) { mArgs[0] = x; } IMPL_SVGPATHSEG_SUBCLASS_COMMON( LinetoHorizontalRel, @@ -524,9 +514,7 @@ class DOMSVGPathSegLinetoHorizontalRel : public DOMSVGPathSeg { class DOMSVGPathSegLinetoVerticalAbs : public DOMSVGPathSeg { public: - explicit DOMSVGPathSegLinetoVerticalAbs(float y) : DOMSVGPathSeg() { - mArgs[0] = y; - } + explicit DOMSVGPathSegLinetoVerticalAbs(float y) { mArgs[0] = y; } IMPL_SVGPATHSEG_SUBCLASS_COMMON( LinetoVerticalAbs, dom::SVGPathSeg_Binding::PATHSEG_LINETO_VERTICAL_ABS) @@ -540,9 +528,7 @@ class DOMSVGPathSegLinetoVerticalAbs : public DOMSVGPathSeg { class DOMSVGPathSegLinetoVerticalRel : public DOMSVGPathSeg { public: - explicit DOMSVGPathSegLinetoVerticalRel(float y) : DOMSVGPathSeg() { - mArgs[0] = y; - } + explicit DOMSVGPathSegLinetoVerticalRel(float y) { mArgs[0] = y; } IMPL_SVGPATHSEG_SUBCLASS_COMMON( LinetoVerticalRel, dom::SVGPathSeg_Binding::PATHSEG_LINETO_VERTICAL_REL) @@ -556,8 +542,7 @@ class DOMSVGPathSegLinetoVerticalRel : public DOMSVGPathSeg { class DOMSVGPathSegCurvetoCubicSmoothAbs : public DOMSVGPathSeg { public: - DOMSVGPathSegCurvetoCubicSmoothAbs(float x2, float y2, float x, float y) - : DOMSVGPathSeg() { + DOMSVGPathSegCurvetoCubicSmoothAbs(float x2, float y2, float x, float y) { mArgs[0] = x2; mArgs[1] = y2; mArgs[2] = x; @@ -583,8 +568,7 @@ class DOMSVGPathSegCurvetoCubicSmoothAbs : public DOMSVGPathSeg { class DOMSVGPathSegCurvetoCubicSmoothRel : public DOMSVGPathSeg { public: - DOMSVGPathSegCurvetoCubicSmoothRel(float x2, float y2, float x, float y) - : DOMSVGPathSeg() { + DOMSVGPathSegCurvetoCubicSmoothRel(float x2, float y2, float x, float y) { mArgs[0] = x2; mArgs[1] = y2; mArgs[2] = x; @@ -610,7 +594,7 @@ class DOMSVGPathSegCurvetoCubicSmoothRel : public DOMSVGPathSeg { class DOMSVGPathSegCurvetoQuadraticSmoothAbs : public DOMSVGPathSeg { public: - DOMSVGPathSegCurvetoQuadraticSmoothAbs(float x, float y) : DOMSVGPathSeg() { + DOMSVGPathSegCurvetoQuadraticSmoothAbs(float x, float y) { mArgs[0] = x; mArgs[1] = y; } @@ -630,7 +614,7 @@ class DOMSVGPathSegCurvetoQuadraticSmoothAbs : public DOMSVGPathSeg { class DOMSVGPathSegCurvetoQuadraticSmoothRel : public DOMSVGPathSeg { public: - DOMSVGPathSegCurvetoQuadraticSmoothRel(float x, float y) : DOMSVGPathSeg() { + DOMSVGPathSegCurvetoQuadraticSmoothRel(float x, float y) { mArgs[0] = x; mArgs[1] = y; } diff --git a/dom/svg/SVGTransform.h b/dom/svg/SVGTransform.h index 50a330c854ed..f1f2ba6e9202 100644 --- a/dom/svg/SVGTransform.h +++ b/dom/svg/SVGTransform.h @@ -21,9 +21,7 @@ class SVGTransform { public: // Default ctor initialises to matrix type with identity matrix SVGTransform() - : mMatrix() // Initialises to identity - , - mAngle(0.f), + : mAngle(0.f), mOriginX(0.f), mOriginY(0.f), mType(dom::SVGTransform_Binding::SVG_TRANSFORM_MATRIX) {} diff --git a/dom/vr/XRView.cpp b/dom/vr/XRView.cpp index 07c3b81c9f4b..c1ff18004e9a 100644 --- a/dom/vr/XRView.cpp +++ b/dom/vr/XRView.cpp @@ -20,8 +20,7 @@ NS_IMPL_CYCLE_COLLECTION_WRAPPERCACHE_WITH_JS_MEMBERS(XRView, XRView::XRView(nsISupports* aParent, const XREye& aEye) : mParent(aParent), mEye(aEye), - mPosition(gfx::PointDouble3D()), - mOrientation(gfx::QuaternionDouble()), + mJSProjectionMatrix(nullptr) { mozilla::HoldJSObjects(this); } diff --git a/dom/xslt/xslt/txVariableMap.h b/dom/xslt/xslt/txVariableMap.h index 167eade697f4..20c140552460 100644 --- a/dom/xslt/xslt/txVariableMap.h +++ b/dom/xslt/xslt/txVariableMap.h @@ -36,7 +36,7 @@ class txVariableMapBase { */ class txVariableMap : public txVariableMapBase { public: - txVariableMap() : txVariableMapBase() { MOZ_COUNT_CTOR(txVariableMap); } + txVariableMap() { MOZ_COUNT_CTOR(txVariableMap); } MOZ_COUNTED_DTOR(txVariableMap) }; diff --git a/editor/libeditor/ChangeStyleTransaction.cpp b/editor/libeditor/ChangeStyleTransaction.cpp index deeaffc41f85..edd6ac29d7c9 100644 --- a/editor/libeditor/ChangeStyleTransaction.cpp +++ b/editor/libeditor/ChangeStyleTransaction.cpp @@ -50,8 +50,6 @@ ChangeStyleTransaction::ChangeStyleTransaction(nsStyledElement& aStyledElement, : EditTransactionBase(), mStyledElement(&aStyledElement), mProperty(&aProperty), - mUndoValue(), - mRedoValue(), mRemoveProperty(aRemove), mUndoAttributeWasSet(false), mRedoAttributeWasSet(false) { diff --git a/editor/libeditor/HTMLEditHelpers.cpp b/editor/libeditor/HTMLEditHelpers.cpp index 73c678d8b26c..cb1f93795c2c 100644 --- a/editor/libeditor/HTMLEditHelpers.cpp +++ b/editor/libeditor/HTMLEditHelpers.cpp @@ -79,9 +79,7 @@ void DOMIterator::AppendNodesToArray( } } -DOMSubtreeIterator::DOMSubtreeIterator() : DOMIterator() { - mIter = &mSubtreeIter; -} +DOMSubtreeIterator::DOMSubtreeIterator() { mIter = &mSubtreeIter; } nsresult DOMSubtreeIterator::Init(nsRange& aRange) { return mIter->Init(&aRange); diff --git a/editor/libeditor/HTMLEditHelpers.h b/editor/libeditor/HTMLEditHelpers.h index e96e78b511de..085158ba51ae 100644 --- a/editor/libeditor/HTMLEditHelpers.h +++ b/editor/libeditor/HTMLEditHelpers.h @@ -189,15 +189,13 @@ class MOZ_STACK_CLASS MoveNodeResult final : public CaretPoint { private: explicit MoveNodeResult(const EditorDOMPoint& aNextInsertionPoint, bool aHandled) - : CaretPoint(), - mNextInsertionPoint(aNextInsertionPoint), + : mNextInsertionPoint(aNextInsertionPoint), mHandled(aHandled && aNextInsertionPoint.IsSet()) { AutoEditorDOMPointChildInvalidator computeOffsetAndForgetChild( mNextInsertionPoint); } explicit MoveNodeResult(EditorDOMPoint&& aNextInsertionPoint, bool aHandled) - : CaretPoint(), - mNextInsertionPoint(std::move(aNextInsertionPoint)), + : mNextInsertionPoint(std::move(aNextInsertionPoint)), mHandled(aHandled && mNextInsertionPoint.IsSet()) { AutoEditorDOMPointChildInvalidator computeOffsetAndForgetChild( mNextInsertionPoint); @@ -673,8 +671,7 @@ class MOZ_STACK_CLASS SplitRangeOffFromNodeResult final : public CaretPoint { SplitRangeOffFromNodeResult(nsIContent* aLeftContent, nsIContent* aMiddleContent, nsIContent* aRightContent) - : CaretPoint(), - mLeftContent(aLeftContent), + : mLeftContent(aLeftContent), mMiddleContent(aMiddleContent), mRightContent(aRightContent) {} @@ -752,8 +749,7 @@ class MOZ_STACK_CLASS SplitRangeOffResult final : public CaretPoint { SplitRangeOffResult(EditorDOMRange&& aTrackedRange, SplitNodeResult&& aSplitNodeResultAtStart, SplitNodeResult&& aSplitNodeResultAtEnd) - : CaretPoint(), - mRange(std::move(aTrackedRange)), + : mRange(std::move(aTrackedRange)), mHandled(aSplitNodeResultAtStart.Handled() || aSplitNodeResultAtEnd.Handled()) { MOZ_ASSERT(mRange.StartRef().IsSet()); diff --git a/editor/libeditor/HTMLEditorEventListener.h b/editor/libeditor/HTMLEditorEventListener.h index 201265dfabe8..21eb11501007 100644 --- a/editor/libeditor/HTMLEditorEventListener.h +++ b/editor/libeditor/HTMLEditorEventListener.h @@ -22,8 +22,7 @@ class Element; class HTMLEditorEventListener final : public EditorEventListener { public: HTMLEditorEventListener() - : EditorEventListener(), - mListeningToMouseMoveEventForResizers(false), + : mListeningToMouseMoveEventForResizers(false), mListeningToMouseMoveEventForGrabber(false), mListeningToResizeEvent(false) {} diff --git a/editor/txmgr/TransactionStack.cpp b/editor/txmgr/TransactionStack.cpp index f0d9c7d45554..099b46a77cb6 100644 --- a/editor/txmgr/TransactionStack.cpp +++ b/editor/txmgr/TransactionStack.cpp @@ -13,8 +13,7 @@ namespace mozilla { -TransactionStack::TransactionStack(Type aType) - : nsRefPtrDeque(), mType(aType) {} +TransactionStack::TransactionStack(Type aType) : mType(aType) {} TransactionStack::~TransactionStack() { Clear(); } diff --git a/gfx/2d/Blur.cpp b/gfx/2d/Blur.cpp index 5de04f71746c..a598f2c758be 100644 --- a/gfx/2d/Blur.cpp +++ b/gfx/2d/Blur.cpp @@ -540,7 +540,7 @@ void AlphaBoxBlur::Init(const Rect& aRect, const IntSize& aSpreadRadius, AlphaBoxBlur::AlphaBoxBlur(const Rect& aRect, int32_t aStride, float aSigmaX, float aSigmaY) : mRect(TruncatedToInt(aRect)), - mSpreadRadius(), + mBlurRadius(CalculateBlurRadius(Point(aSigmaX, aSigmaY))), mStride(aStride), mSurfaceAllocationSize(0), diff --git a/gfx/2d/Path.cpp b/gfx/2d/Path.cpp index 69b5680c24fd..4ad9199a7928 100644 --- a/gfx/2d/Path.cpp +++ b/gfx/2d/Path.cpp @@ -22,7 +22,7 @@ static double CubicRoot(double aValue) { struct PointD : public BasePoint { typedef BasePoint Super; - PointD() : Super() {} + PointD() {} PointD(double aX, double aY) : Super(aX, aY) {} MOZ_IMPLICIT PointD(const Point& aPoint) : Super(aPoint.x, aPoint.y) {} diff --git a/gfx/layers/FrameMetrics.h b/gfx/layers/FrameMetrics.h index 65db430d7c1c..ee638b3192a2 100644 --- a/gfx/layers/FrameMetrics.h +++ b/gfx/layers/FrameMetrics.h @@ -88,18 +88,13 @@ struct FrameMetrics { mCompositionBoundsWidthIgnoringScrollbars(0), mDisplayPort(0, 0, 0, 0), mScrollableRect(0, 0, 0, 0), - mCumulativeResolution(), mDevPixelsPerCSSPixel(1), mScrollOffset(0, 0), - mZoom(), mBoundingCompositionSize(0, 0), mPresShellId(-1), mLayoutViewport(0, 0, 0, 0), - mTransformToAncestorScale(), - mPaintRequestTime(), mVisualDestination(0, 0), mVisualScrollUpdateType(eNone), - mCompositionSizeWithoutDynamicToolbar(), mIsRootContent(false), mIsScrollInfoLayer(false), mHasNonZeroDisplayPortMargins(false), @@ -740,10 +735,7 @@ struct ScrollMetadata { sNullMetadata; // We sometimes need an empty metadata ScrollMetadata() - : mMetrics(), - mSnapInfo(), - mScrollParentId(ScrollableLayerGuid::NULL_SCROLL_ID), - mContentDescription(), + : mScrollParentId(ScrollableLayerGuid::NULL_SCROLL_ID), mLineScrollAmount(0, 0), mPageScrollAmount(0, 0), mHasScrollgrab(false), @@ -755,8 +747,7 @@ struct ScrollMetadata { mDidContentGetPainted(true), mForceMousewheelAutodir(false), mForceMousewheelAutodirHonourRoot(false), - mIsPaginatedPresentation(false), - mOverscrollBehavior() {} + mIsPaginatedPresentation(false) {} bool operator==(const ScrollMetadata& aOther) const { return mMetrics == aOther.mMetrics && mSnapInfo == aOther.mSnapInfo && diff --git a/gfx/layers/RepaintRequest.h b/gfx/layers/RepaintRequest.h index 44fdcb7d1041..7a89610c34cb 100644 --- a/gfx/layers/RepaintRequest.h +++ b/gfx/layers/RepaintRequest.h @@ -48,15 +48,11 @@ struct RepaintRequest { : mScrollId(ScrollableLayerGuid::NULL_SCROLL_ID), mPresShellResolution(1), mCompositionBounds(0, 0, 0, 0), - mCumulativeResolution(), mDevPixelsPerCSSPixel(1), mScrollOffset(0, 0), - mZoom(), mDisplayPortMargins(0, 0, 0, 0), mPresShellId(-1), mLayoutViewport(0, 0, 0, 0), - mTransformToAncestorScale(), - mPaintRequestTime(), mScrollUpdateType(eNone), mScrollAnimationType(APZScrollAnimationType::No), mIsRootContent(false), diff --git a/gfx/layers/apz/src/AsyncPanZoomController.cpp b/gfx/layers/apz/src/AsyncPanZoomController.cpp index 6f7a9acf42dd..8e88c6a4e061 100644 --- a/gfx/layers/apz/src/AsyncPanZoomController.cpp +++ b/gfx/layers/apz/src/AsyncPanZoomController.cpp @@ -763,7 +763,6 @@ AsyncPanZoomController::AsyncPanZoomController( ViewportMaxScale() / ParentLayerToScreenScale(1)), mLastSampleTime(GetFrameTime()), mLastCheckerboardReport(GetFrameTime()), - mLastNotifiedZoom(), mOverscrollEffect(MakeUnique(*this)), mState(NOTHING), mX(this), diff --git a/gfx/layers/ipc/CanvasTranslator.cpp b/gfx/layers/ipc/CanvasTranslator.cpp index 5db058bbf618..f6f68f299725 100644 --- a/gfx/layers/ipc/CanvasTranslator.cpp +++ b/gfx/layers/ipc/CanvasTranslator.cpp @@ -67,7 +67,7 @@ TextureData* CanvasTranslator::CreateTextureData(TextureType aTextureType, return textureData; } -CanvasTranslator::CanvasTranslator() : gfx::InlineTranslator() { +CanvasTranslator::CanvasTranslator() { // Track when remote canvas has been activated. Telemetry::ScalarAdd(Telemetry::ScalarID::GFX_CANVAS_REMOTE_ACTIVATED, 1); } diff --git a/gfx/layers/wr/HitTestInfoManager.cpp b/gfx/layers/wr/HitTestInfoManager.cpp index 3365a92fbfc2..552221b14c68 100644 --- a/gfx/layers/wr/HitTestInfoManager.cpp +++ b/gfx/layers/wr/HitTestInfoManager.cpp @@ -49,8 +49,7 @@ static void CreateWebRenderCommands(wr::DisplayListBuilder& aBuilder, } HitTestInfoManager::HitTestInfoManager() - : mArea(nsRect()), - mFlags(gfx::CompositorHitTestInvisibleToHit), + : mFlags(gfx::CompositorHitTestInvisibleToHit), mViewId(ScrollableLayerGuid::NULL_SCROLL_ID), mSpaceAndClipChain(wr::InvalidScrollNodeWithChain()) {} diff --git a/gfx/layers/wr/WebRenderImageHost.cpp b/gfx/layers/wr/WebRenderImageHost.cpp index c1c6661d640e..47f5a5948823 100644 --- a/gfx/layers/wr/WebRenderImageHost.cpp +++ b/gfx/layers/wr/WebRenderImageHost.cpp @@ -37,9 +37,7 @@ namespace layers { class ISurfaceAllocator; WebRenderImageHost::WebRenderImageHost(const TextureInfo& aTextureInfo) - : CompositableHost(aTextureInfo), - ImageComposite(), - mCurrentAsyncImageManager(nullptr) {} + : CompositableHost(aTextureInfo), mCurrentAsyncImageManager(nullptr) {} WebRenderImageHost::~WebRenderImageHost() { MOZ_ASSERT(mPendingRemoteTextureWrappers.empty()); diff --git a/gfx/src/nsRect.h b/gfx/src/nsRect.h index c306e026da3f..ccf48f0d9e94 100644 --- a/gfx/src/nsRect.h +++ b/gfx/src/nsRect.h @@ -35,7 +35,7 @@ struct nsRect : public mozilla::gfx::BaseRect Super; - nsRectAbsolute() : Super() {} + nsRectAbsolute() {} nsRectAbsolute(nscoord aX1, nscoord aY1, nscoord aX2, nscoord aY2) : Super(aX1, aY1, aX2, aY2) {} diff --git a/gfx/src/nsSize.h b/gfx/src/nsSize.h index 21aa65487791..b80d1bde74a1 100644 --- a/gfx/src/nsSize.h +++ b/gfx/src/nsSize.h @@ -19,7 +19,7 @@ typedef mozilla::gfx::IntSize nsIntSize; struct nsSize : public mozilla::gfx::BaseSize { typedef mozilla::gfx::BaseSize Super; - constexpr nsSize() : Super() {} + constexpr nsSize() {} constexpr nsSize(nscoord aWidth, nscoord aHeight) : Super(aWidth, aHeight) {} inline mozilla::gfx::IntSize ScaleToNearestPixels( diff --git a/gfx/thebes/gfxFontEntry.h b/gfx/thebes/gfxFontEntry.h index 86d2445d0bfb..5bce0fdded8a 100644 --- a/gfx/thebes/gfxFontEntry.h +++ b/gfx/thebes/gfxFontEntry.h @@ -1222,8 +1222,7 @@ struct FontFamily { // together with the CSS generic (if any) that was mapped to it in this // particular case (so it can be reported to the DevTools font inspector). struct FamilyAndGeneric final { - FamilyAndGeneric() - : mFamily(), mGeneric(mozilla::StyleGenericFontFamily(0)) {} + FamilyAndGeneric() : mGeneric(mozilla::StyleGenericFontFamily(0)) {} FamilyAndGeneric(const FamilyAndGeneric& aOther) = default; explicit FamilyAndGeneric(gfxFontFamily* aFamily, mozilla::StyleGenericFontFamily aGeneric = diff --git a/gfx/thebes/gfxLineSegment.h b/gfx/thebes/gfxLineSegment.h index 5b9479ede510..7f4ad13f61c8 100644 --- a/gfx/thebes/gfxLineSegment.h +++ b/gfx/thebes/gfxLineSegment.h @@ -10,7 +10,7 @@ #include "gfxPoint.h" struct gfxLineSegment { - gfxLineSegment() : mStart(gfxPoint()), mEnd(gfxPoint()) {} + gfxLineSegment() {} gfxLineSegment(const gfxPoint& aStart, const gfxPoint& aEnd) : mStart(aStart), mEnd(aEnd) {} diff --git a/gfx/thebes/gfxPlatform.cpp b/gfx/thebes/gfxPlatform.cpp index f2b417572870..75fd145b873a 100644 --- a/gfx/thebes/gfxPlatform.cpp +++ b/gfx/thebes/gfxPlatform.cpp @@ -218,8 +218,7 @@ class CrashStatsLogForwarder : public mozilla::gfx::LogForwarder { }; CrashStatsLogForwarder::CrashStatsLogForwarder(CrashReporter::Annotation aKey) - : mBuffer(), - mCrashCriticalKey(aKey), + : mCrashCriticalKey(aKey), mMaxCapacity(0), mIndex(-1), mMutex("CrashStatsLogForwarder") {} diff --git a/gfx/thebes/gfxPlatformFontList.cpp b/gfx/thebes/gfxPlatformFontList.cpp index 261d466d1c24..590ae9ce1bd6 100644 --- a/gfx/thebes/gfxPlatformFontList.cpp +++ b/gfx/thebes/gfxPlatformFontList.cpp @@ -1918,7 +1918,6 @@ FamilyAndGeneric gfxPlatformFontList::GetDefaultFontFamily( ShmemCharMapHashEntry::ShmemCharMapHashEntry(const gfxSparseBitSet* aCharMap) : mList(gfxPlatformFontList::PlatformFontList()->SharedFontList()), - mCharMap(), mHash(aCharMap->GetChecksum()) { size_t len = SharedBitSet::RequiredSize(*aCharMap); mCharMap = mList->Alloc(len); diff --git a/gfx/vr/service/OSVRSession.cpp b/gfx/vr/service/OSVRSession.cpp index fc4e7e741ccb..8315bc7f4a18 100644 --- a/gfx/vr/service/OSVRSession.cpp +++ b/gfx/vr/service/OSVRSession.cpp @@ -197,8 +197,7 @@ mozilla::gfx::VRFieldOfView SetFromTanRadians(double left, double right, } OSVRSession::OSVRSession() - : VRSession(), - mRuntimeLoaded(false), + : mRuntimeLoaded(false), mOSVRInitialized(false), mClientContextInitialized(false), mDisplayConfigInitialized(false), diff --git a/gfx/vr/service/OpenVRSession.cpp b/gfx/vr/service/OpenVRSession.cpp index b0e3ad4f80c0..bfb486799db3 100644 --- a/gfx/vr/service/OpenVRSession.cpp +++ b/gfx/vr/service/OpenVRSession.cpp @@ -183,8 +183,7 @@ bool GenerateTempFileName(nsCString& aPath) { #endif // defined(XP_WIN) OpenVRSession::OpenVRSession() - : VRSession(), - mVRSystem(nullptr), + : mVRSystem(nullptr), mVRChaperone(nullptr), mVRCompositor(nullptr), mHapticPulseRemaining{}, diff --git a/gfx/vr/service/PuppetSession.cpp b/gfx/vr/service/PuppetSession.cpp index ab00e3c653e7..aa5478a1150c 100644 --- a/gfx/vr/service/PuppetSession.cpp +++ b/gfx/vr/service/PuppetSession.cpp @@ -21,7 +21,7 @@ using namespace mozilla::gfx; namespace mozilla::gfx { -PuppetSession::PuppetSession() : VRSession() {} +PuppetSession::PuppetSession() {} PuppetSession::~PuppetSession() { Shutdown(); } diff --git a/image/VectorImage.cpp b/image/VectorImage.cpp index aacdce5dbbfc..e130450407c3 100644 --- a/image/VectorImage.cpp +++ b/image/VectorImage.cpp @@ -64,8 +64,7 @@ class SVGRootRenderingObserver final : public SVGRenderingObserver { SVGRootRenderingObserver(SVGDocumentWrapper* aDocWrapper, VectorImage* aVectorImage) - : SVGRenderingObserver(), - mDocWrapper(aDocWrapper), + : mDocWrapper(aDocWrapper), mVectorImage(aVectorImage), mHonoringInvalidations(true) { MOZ_ASSERT(mDocWrapper, "Need a non-null SVG document wrapper"); diff --git a/image/imgFrame.h b/image/imgFrame.h index c0049c36ca55..0e2b21851135 100644 --- a/image/imgFrame.h +++ b/image/imgFrame.h @@ -170,8 +170,7 @@ class imgFrame { already_AddRefed GetSourceSurface(); struct AddSizeOfCbData : public SourceSurface::SizeOfInfo { - AddSizeOfCbData() - : SourceSurface::SizeOfInfo(), mIndex(0), mFinished(false) {} + AddSizeOfCbData() : mIndex(0), mFinished(false) {} size_t mIndex; bool mFinished; diff --git a/intl/components/src/NumberFormatFields.cpp b/intl/components/src/NumberFormatFields.cpp index 8ab4690d5044..ae6fb531ddd0 100644 --- a/intl/components/src/NumberFormatFields.cpp +++ b/intl/components/src/NumberFormatFields.cpp @@ -200,7 +200,7 @@ bool NumberFormatFields::toPartsVector(size_t overallLength, public: PartGenerator(const FieldsVector& vec, uint32_t limit, const NumberPartSourceMap& sourceMap) - : fields(vec), limit(limit), sourceMap(sourceMap), enclosingFields() {} + : fields(vec), limit(limit), sourceMap(sourceMap) {} bool nextPart(bool* hasPart, NumberPart* part) { // There are no parts left if we've partitioned the entire string. diff --git a/ipc/chromium/src/base/histogram.cc b/ipc/chromium/src/base/histogram.cc index ffb951846615..83390ec78a81 100644 --- a/ipc/chromium/src/base/histogram.cc +++ b/ipc/chromium/src/base/histogram.cc @@ -218,8 +218,7 @@ size_t Histogram::SampleSet::SizeOfExcludingThis( } Histogram::Histogram(Sample minimum, Sample maximum, size_t bucket_count) - : sample_(), - declared_min_(minimum), + : declared_min_(minimum), declared_max_(maximum), bucket_count_(bucket_count), flags_(kNoFlags), @@ -228,8 +227,7 @@ Histogram::Histogram(Sample minimum, Sample maximum, size_t bucket_count) } Histogram::Histogram(TimeDelta minimum, TimeDelta maximum, size_t bucket_count) - : sample_(), - declared_min_(static_cast(minimum.InMilliseconds())), + : declared_min_(static_cast(minimum.InMilliseconds())), declared_max_(static_cast(maximum.InMilliseconds())), bucket_count_(bucket_count), flags_(kNoFlags), @@ -388,7 +386,7 @@ double Histogram::GetPeakBucketSize(const SampleSet& snapshot) const { // Methods for the Histogram::SampleSet class //------------------------------------------------------------------------------ -Histogram::SampleSet::SampleSet() : counts_(), sum_(0), redundant_count_(0) {} +Histogram::SampleSet::SampleSet() : sum_(0), redundant_count_(0) {} Histogram::SampleSet::~SampleSet() {} @@ -543,7 +541,7 @@ Histogram* FlagHistogram::FactoryGet(Flags flags, const int* buckets) { return h; } -FlagHistogram::FlagHistogram() : BooleanHistogram(), mSwitched(false) {} +FlagHistogram::FlagHistogram() : mSwitched(false) {} Histogram::ClassType FlagHistogram::histogram_type() const { return FLAG_HISTOGRAM; diff --git a/ipc/chromium/src/base/lock.h b/ipc/chromium/src/base/lock.h index b2aceafa86a2..40cf2e5f4879 100644 --- a/ipc/chromium/src/base/lock.h +++ b/ipc/chromium/src/base/lock.h @@ -15,7 +15,7 @@ class Lock { public: // Optimized wrapper implementation - Lock() : lock_() {} + Lock() {} ~Lock() {} void Acquire() { lock_.Lock(); } void Release() { lock_.Unlock(); } diff --git a/js/loader/ScriptLoadRequest.cpp b/js/loader/ScriptLoadRequest.cpp index 316c93059988..e7db7245921e 100644 --- a/js/loader/ScriptLoadRequest.cpp +++ b/js/loader/ScriptLoadRequest.cpp @@ -89,7 +89,6 @@ ScriptLoadRequest::ScriptLoadRequest( mIntegrity(aIntegrity), mReferrer(aReferrer), mScriptTextLength(0), - mScriptBytecode(), mBytecodeOffset(0), mURI(aURI), mLoadContext(aContext), diff --git a/js/src/builtin/TestingFunctions.cpp b/js/src/builtin/TestingFunctions.cpp index 8a4ed8bbae43..168c8854cfe7 100644 --- a/js/src/builtin/TestingFunctions.cpp +++ b/js/src/builtin/TestingFunctions.cpp @@ -4647,7 +4647,7 @@ static bool IsAvxPresent(JSContext* cx, unsigned argc, Value* vp) { class ShellAllocationMetadataBuilder : public AllocationMetadataBuilder { public: - ShellAllocationMetadataBuilder() : AllocationMetadataBuilder() {} + ShellAllocationMetadataBuilder() {} virtual JSObject* build(JSContext* cx, HandleObject, AutoEnterOOMUnsafeRegion& oomUnsafe) const override; diff --git a/js/src/debugger/Script.cpp b/js/src/debugger/Script.cpp index 81b1a37e5d91..79e6bac806cb 100644 --- a/js/src/debugger/Script.cpp +++ b/js/src/debugger/Script.cpp @@ -747,12 +747,7 @@ class DebuggerScript::GetPossibleBreakpointsMatcher { public: explicit GetPossibleBreakpointsMatcher(JSContext* cx, MutableHandleObject result) - : cx_(cx), - result_(result), - minOffset(), - maxOffset(), - minLine(), - maxLine() {} + : cx_(cx), result_(result) {} bool parseQuery(HandleObject query) { RootedValue lineValue(cx_); diff --git a/js/src/frontend/FrontendContext.h b/js/src/frontend/FrontendContext.h index b4837fab0487..2e9dd1bffae9 100644 --- a/js/src/frontend/FrontendContext.h +++ b/js/src/frontend/FrontendContext.h @@ -113,8 +113,7 @@ class FrontendContext { : alloc_(this), nameCollectionPool_(nullptr), ownNameCollectionPool_(false), - scriptDataTableHolder_(&js::globalSharedScriptDataTableHolder), - supportedImportAssertions_() {} + scriptDataTableHolder_(&js::globalSharedScriptDataTableHolder) {} ~FrontendContext(); void setStackQuota(JS::NativeStackSize stackSize); @@ -233,7 +232,7 @@ class MOZ_STACK_CLASS AutoReportFrontendContext : public FrontendContext { public: explicit AutoReportFrontendContext(JSContext* cx, Warning warning = Warning::Report) - : FrontendContext(), cx_(cx), warning_(warning) { + : cx_(cx), warning_(warning) { setCurrentJSContext(cx_); MOZ_ASSERT(cx_ == maybeCx_); } @@ -267,8 +266,7 @@ class ManualReportFrontendContext : public FrontendContext { #endif public: - explicit ManualReportFrontendContext(JSContext* cx) - : FrontendContext(), cx_(cx) { + explicit ManualReportFrontendContext(JSContext* cx) : cx_(cx) { setCurrentJSContext(cx_); } diff --git a/js/src/gc/GC.cpp b/js/src/gc/GC.cpp index 86383d1d6b70..804d692f777c 100644 --- a/js/src/gc/GC.cpp +++ b/js/src/gc/GC.cpp @@ -4981,7 +4981,7 @@ void AutoAssertEmptyNursery::checkCondition(JSContext* cx) { MOZ_ASSERT(cx->nursery().isEmpty()); } -AutoEmptyNursery::AutoEmptyNursery(JSContext* cx) : AutoAssertEmptyNursery() { +AutoEmptyNursery::AutoEmptyNursery(JSContext* cx) { MOZ_ASSERT(!cx->suppressGC); cx->runtime()->gc.stats().suspendPhases(); cx->runtime()->gc.evictNursery(JS::GCReason::EVICT_NURSERY); diff --git a/js/src/gc/PrivateIterators-inl.h b/js/src/gc/PrivateIterators-inl.h index f63d1c3c8de3..e6013c3e94a1 100644 --- a/js/src/gc/PrivateIterators-inl.h +++ b/js/src/gc/PrivateIterators-inl.h @@ -33,8 +33,7 @@ class ArenaCellIterUnderFinalize : public ArenaCellIter { class GrayObjectIter : public ZoneAllCellIter { public: - explicit GrayObjectIter(JS::Zone* zone, AllocKind kind) - : ZoneAllCellIter() { + explicit GrayObjectIter(JS::Zone* zone, AllocKind kind) { initForTenuredIteration(zone, kind); } diff --git a/js/src/gc/Zone.cpp b/js/src/gc/Zone.cpp index 133d29a584fb..de702267be09 100644 --- a/js/src/gc/Zone.cpp +++ b/js/src/gc/Zone.cpp @@ -167,7 +167,6 @@ JS::Zone::Zone(JSRuntime* rt, Kind kind) allocNurseryStrings_(true), allocNurseryBigInts_(true), pretenuring(this), - compartments_(), crossZoneStringWrappers_(this), gcEphemeronEdges_(SystemAllocPolicy(), rt->randomHashCodeScrambler()), gcNurseryEphemeronEdges_(SystemAllocPolicy(), diff --git a/js/src/jit/BaselineCodeGen.cpp b/js/src/jit/BaselineCodeGen.cpp index 1d45a6025c94..6bf3a569550c 100644 --- a/js/src/jit/BaselineCodeGen.cpp +++ b/js/src/jit/BaselineCodeGen.cpp @@ -97,8 +97,7 @@ BaselineCodeGen::BaselineCodeGen(JSContext* cx, TempAllocator& alloc, BaselineCompiler::BaselineCompiler(JSContext* cx, TempAllocator& alloc, JSScript* script) - : BaselineCodeGen(cx, alloc, /* HandlerArgs = */ alloc, script), - profilerPushToggleOffset_() { + : BaselineCodeGen(cx, alloc, /* HandlerArgs = */ alloc, script) { #ifdef JS_CODEGEN_NONE MOZ_CRASH(); #endif diff --git a/js/src/jit/BaselineFrameInfo.h b/js/src/jit/BaselineFrameInfo.h index 2e4c994d9972..5d81a2fce1b3 100644 --- a/js/src/jit/BaselineFrameInfo.h +++ b/js/src/jit/BaselineFrameInfo.h @@ -227,7 +227,7 @@ class CompilerFrameInfo : public FrameInfo { public: CompilerFrameInfo(JSScript* script, MacroAssembler& masm) - : FrameInfo(masm), script(script), stack(), spIndex(0) {} + : FrameInfo(masm), script(script), spIndex(0) {} [[nodiscard]] bool init(TempAllocator& alloc); size_t nlocals() const { return script->nfixed(); } diff --git a/js/src/jit/IonIC.h b/js/src/jit/IonIC.h index 8a06df8e3689..36f50a82ec16 100644 --- a/js/src/jit/IonIC.h +++ b/js/src/jit/IonIC.h @@ -113,8 +113,7 @@ class IonIC { pc_(nullptr), rejoinOffset_(0), fallbackOffset_(0), - kind_(kind), - state_() {} + kind_(kind) {} void attachStub(IonICStub* newStub, JitCode* code); diff --git a/js/src/jit/JitFrames.cpp b/js/src/jit/JitFrames.cpp index e723c76e3764..cb1fc08be29a 100644 --- a/js/src/jit/JitFrames.cpp +++ b/js/src/jit/JitFrames.cpp @@ -2139,11 +2139,7 @@ Value SnapshotIterator::maybeReadAllocByIndex(size_t index) { InlineFrameIterator::InlineFrameIterator(JSContext* cx, const JSJitFrameIter* iter) - : calleeTemplate_(cx), - calleeRVA_(), - script_(cx), - pc_(nullptr), - numActualArgs_(0) { + : calleeTemplate_(cx), script_(cx), pc_(nullptr), numActualArgs_(0) { resetOn(iter); } @@ -2153,7 +2149,6 @@ InlineFrameIterator::InlineFrameIterator(JSContext* cx, framesRead_(0), frameCount_(iter ? iter->frameCount_ : UINT32_MAX), calleeTemplate_(cx), - calleeRVA_(), script_(cx), pc_(nullptr), numActualArgs_(0) { diff --git a/js/src/jit/LIR.cpp b/js/src/jit/LIR.cpp index aa72ca681f1e..1e3d7af0f0d9 100644 --- a/js/src/jit/LIR.cpp +++ b/js/src/jit/LIR.cpp @@ -26,8 +26,7 @@ const char* const js::jit::LIROpNames[] = { }; LIRGraph::LIRGraph(MIRGraph* mir) - : blocks_(), - constantPool_(mir->alloc()), + : constantPool_(mir->alloc()), constantPoolMap_(mir->alloc()), safepoints_(mir->alloc()), nonCallSafepoints_(mir->alloc()), @@ -72,7 +71,7 @@ void LIRGraph::dump() { #endif LBlock::LBlock(MBasicBlock* from) - : block_(from), phis_(), entryMoveGroup_(nullptr), exitMoveGroup_(nullptr) { + : block_(from), entryMoveGroup_(nullptr), exitMoveGroup_(nullptr) { from->assignLir(this); } diff --git a/js/src/jit/ProcessExecutableMemory.cpp b/js/src/jit/ProcessExecutableMemory.cpp index dd74538a5366..0d44be9755b7 100644 --- a/js/src/jit/ProcessExecutableMemory.cpp +++ b/js/src/jit/ProcessExecutableMemory.cpp @@ -681,7 +681,6 @@ class ProcessExecutableMemory { lock_(mutexid::ProcessExecutableRegion), pagesAllocated_(0), cursor_(0), - rng_(), pages_() {} [[nodiscard]] bool init() { diff --git a/js/src/jit/RegisterAllocator.h b/js/src/jit/RegisterAllocator.h index 845ef91ce9e6..805bc7e77d78 100644 --- a/js/src/jit/RegisterAllocator.h +++ b/js/src/jit/RegisterAllocator.h @@ -196,7 +196,7 @@ class InstructionDataMap { FixedList insData_; public: - InstructionDataMap() : insData_() {} + InstructionDataMap() {} [[nodiscard]] bool init(MIRGenerator* gen, uint32_t numInstructions) { if (!insData_.init(gen->alloc(), numInstructions)) { diff --git a/js/src/jit/RegisterSets.h b/js/src/jit/RegisterSets.h index c343c8c15001..40790026a42c 100644 --- a/js/src/jit/RegisterSets.h +++ b/js/src/jit/RegisterSets.h @@ -564,7 +564,7 @@ class AllocatableSetAccessors { } public: - AllocatableSetAccessors() : set_() {} + AllocatableSetAccessors() {} explicit constexpr AllocatableSetAccessors(SetType) = delete; explicit constexpr AllocatableSetAccessors(RegisterSet set) : set_(set) {} @@ -641,7 +641,7 @@ class LiveSetAccessors { } public: - LiveSetAccessors() : set_() {} + LiveSetAccessors() {} explicit constexpr LiveSetAccessors(SetType) = delete; explicit constexpr LiveSetAccessors(RegisterSet set) : set_(set) {} diff --git a/js/src/jit/shared/CodeGenerator-shared.cpp b/js/src/jit/shared/CodeGenerator-shared.cpp index 73f7147c350f..c1e062af0386 100644 --- a/js/src/jit/shared/CodeGenerator-shared.cpp +++ b/js/src/jit/shared/CodeGenerator-shared.cpp @@ -48,12 +48,10 @@ MacroAssembler& CodeGeneratorShared::ensureMasm(MacroAssembler* masmArg, CodeGeneratorShared::CodeGeneratorShared(MIRGenerator* gen, LIRGraph* graph, MacroAssembler* masmArg) - : maybeMasm_(), - masm(ensureMasm(masmArg, gen->alloc(), gen->realm)), + : masm(ensureMasm(masmArg, gen->alloc(), gen->realm)), gen(gen), graph(*graph), current(nullptr), - snapshots_(), recovers_(), #ifdef DEBUG pushedArgs_(0), diff --git a/js/src/jit/x64/Assembler-x64.cpp b/js/src/jit/x64/Assembler-x64.cpp index 35212750d19b..82e6efba85f8 100644 --- a/js/src/jit/x64/Assembler-x64.cpp +++ b/js/src/jit/x64/Assembler-x64.cpp @@ -16,13 +16,13 @@ ABIArgGenerator::ABIArgGenerator() : #if defined(XP_WIN) regIndex_(0), - stackOffset_(ShadowStackSpace), + stackOffset_(ShadowStackSpace) #else intRegIndex_(0), floatRegIndex_(0), - stackOffset_(0), + stackOffset_(0) #endif - current_() { +{ } ABIArg ABIArgGenerator::next(MIRType type) { diff --git a/js/src/jsapi.cpp b/js/src/jsapi.cpp index 25de16ccf1be..662ac56fef2b 100644 --- a/js/src/jsapi.cpp +++ b/js/src/jsapi.cpp @@ -2366,8 +2366,7 @@ void JS::ReadOnlyCompileOptions::copyPODNonTransitiveOptions( noScriptRval = rhs.noScriptRval; } -JS::OwningCompileOptions::OwningCompileOptions(JSContext* cx) - : ReadOnlyCompileOptions() {} +JS::OwningCompileOptions::OwningCompileOptions(JSContext* cx) {} void JS::OwningCompileOptions::release() { // OwningCompileOptions always owns these, so these casts are okay. @@ -2459,7 +2458,7 @@ bool JS::OwningCompileOptions::copy(JS::FrontendContext* fc, return copyImpl(fc, rhs); } -JS::CompileOptions::CompileOptions(JSContext* cx) : ReadOnlyCompileOptions() { +JS::CompileOptions::CompileOptions(JSContext* cx) { prefableOptions_ = cx->options().compileOptions(); if (cx->options().asmJSOption() == AsmJSOption::Enabled) { @@ -3956,7 +3955,7 @@ void JSErrorBase::freeMessage() { message_ = JS::ConstUTF8CharsZ(); } -JSErrorNotes::JSErrorNotes() : notes_() {} +JSErrorNotes::JSErrorNotes() {} JSErrorNotes::~JSErrorNotes() = default; diff --git a/js/src/threading/Mutex.h b/js/src/threading/Mutex.h index 4f2ac4940b21..c2eb1bfbab69 100644 --- a/js/src/threading/Mutex.h +++ b/js/src/threading/Mutex.h @@ -36,7 +36,7 @@ struct MutexId { // we must override it and make Mutex a friend. class MutexImpl : public mozilla::detail::MutexImpl { protected: - MutexImpl() : mozilla::detail::MutexImpl() {} + MutexImpl() {} friend class Mutex; }; diff --git a/js/src/threading/Thread.h b/js/src/threading/Thread.h index ab62e7b65026..b4e0d6b11cfe 100644 --- a/js/src/threading/Thread.h +++ b/js/src/threading/Thread.h @@ -63,7 +63,7 @@ class Thread { typename DerefO = std::remove_reference_t, typename = std::enable_if_t>> explicit Thread(O&& options = Options()) - : id_(ThreadId()), options_(std::forward(options)) { + : options_(std::forward(options)) { MOZ_ASSERT(isInitialized()); } diff --git a/js/src/vm/CodeCoverage.cpp b/js/src/vm/CodeCoverage.cpp index 9c86e7708ea8..e3aa75213602 100644 --- a/js/src/vm/CodeCoverage.cpp +++ b/js/src/vm/CodeCoverage.cpp @@ -515,7 +515,7 @@ void EnableLCov() { gLCovIsEnabled = true; } -LCovRuntime::LCovRuntime() : out_(), pid_(getpid()), isEmpty_(true) {} +LCovRuntime::LCovRuntime() : pid_(getpid()), isEmpty_(true) {} LCovRuntime::~LCovRuntime() { if (out_.isInitialized()) { diff --git a/js/src/vm/Compartment.h b/js/src/vm/Compartment.h index beb883e87e01..6cea7a7c3db0 100644 --- a/js/src/vm/Compartment.h +++ b/js/src/vm/Compartment.h @@ -120,7 +120,7 @@ class ObjectWrapperMap { InnerMap* map; - Ptr() : InnerMap::Ptr(), map(nullptr) {} + Ptr() : map(nullptr) {} Ptr(const InnerMap::Ptr& p, InnerMap& m) : InnerMap::Ptr(p), map(&m) {} }; diff --git a/js/src/vm/Compression.cpp b/js/src/vm/Compression.cpp index eda3c9a522c7..cc6903eaae0a 100644 --- a/js/src/vm/Compression.cpp +++ b/js/src/vm/Compression.cpp @@ -27,8 +27,7 @@ Compressor::Compressor(const unsigned char* inp, size_t inplen) inplen(inplen), initialized(false), finished(false), - currentChunkSize(0), - chunkOffsets() { + currentChunkSize(0) { MOZ_ASSERT(inplen > 0, "data to compress can't be empty"); zs.opaque = nullptr; diff --git a/js/src/vm/GeckoProfiler.cpp b/js/src/vm/GeckoProfiler.cpp index 7c0ddf22259f..5a0033cc6956 100644 --- a/js/src/vm/GeckoProfiler.cpp +++ b/js/src/vm/GeckoProfiler.cpp @@ -29,11 +29,7 @@ GeckoProfilerThread::GeckoProfilerThread() : profilingStack_(nullptr), profilingStackIfEnabled_(nullptr) {} GeckoProfilerRuntime::GeckoProfilerRuntime(JSRuntime* rt) - : rt(rt), - strings_(), - slowAssertions(false), - enabled_(false), - eventMarker_(nullptr) { + : rt(rt), slowAssertions(false), enabled_(false), eventMarker_(nullptr) { MOZ_ASSERT(rt != nullptr); } diff --git a/js/src/vm/JSContext.cpp b/js/src/vm/JSContext.cpp index 68ed576b0a58..4d8d14bd23c0 100644 --- a/js/src/vm/JSContext.cpp +++ b/js/src/vm/JSContext.cpp @@ -1025,9 +1025,6 @@ JSContext::JSContext(JSRuntime* runtime, const JS::ContextOptions& options) canSkipEnqueuingJobs(this, false), promiseRejectionTrackerCallback(this, nullptr), promiseRejectionTrackerCallbackData(this, nullptr), -#ifdef JS_STRUCTURED_SPEW - structuredSpewer_(), -#endif insideDebuggerEvaluationWithOnNativeCallHook(this, nullptr) { MOZ_ASSERT(static_cast(this) == JS::RootingContext::get(this)); diff --git a/js/src/vm/JSScript-inl.h b/js/src/vm/JSScript-inl.h index 2010f420606b..2d42700ef653 100644 --- a/js/src/vm/JSScript-inl.h +++ b/js/src/vm/JSScript-inl.h @@ -18,11 +18,10 @@ namespace js { -ScriptCounts::ScriptCounts() - : pcCounts_(), throwCounts_(), ionCounts_(nullptr) {} +ScriptCounts::ScriptCounts() : ionCounts_(nullptr) {} ScriptCounts::ScriptCounts(PCCountsVector&& jumpTargets) - : pcCounts_(std::move(jumpTargets)), throwCounts_(), ionCounts_(nullptr) {} + : pcCounts_(std::move(jumpTargets)), ionCounts_(nullptr) {} ScriptCounts::ScriptCounts(ScriptCounts&& src) : pcCounts_(std::move(src.pcCounts_)), @@ -41,8 +40,7 @@ ScriptCounts& ScriptCounts::operator=(ScriptCounts&& src) { ScriptCounts::~ScriptCounts() { js_delete(ionCounts_); } -ScriptAndCounts::ScriptAndCounts(JSScript* script) - : script(script), scriptCounts() { +ScriptAndCounts::ScriptAndCounts(JSScript* script) : script(script) { script->releaseScriptCounts(&scriptCounts); } diff --git a/js/src/vm/JitActivation.cpp b/js/src/vm/JitActivation.cpp index 7b24bda69076..d6c630458bb7 100644 --- a/js/src/vm/JitActivation.cpp +++ b/js/src/vm/JitActivation.cpp @@ -34,7 +34,6 @@ js::jit::JitActivation::JitActivation(JSContext* cx) packedExitFP_(nullptr), encodedWasmExitReason_(0), prevJitActivation_(cx->jitActivation), - rematerializedFrames_(), ionRecovery_(cx), bailoutData_(nullptr), lastProfilingFrame_(nullptr), diff --git a/js/src/vm/PIC.h b/js/src/vm/PIC.h index 89845f99335e..4f1258dd58a6 100644 --- a/js/src/vm/PIC.h +++ b/js/src/vm/PIC.h @@ -108,9 +108,7 @@ struct ForOfPIC { const HeapPtr shape_; public: - explicit Stub(Shape* shape) : BaseStub(), shape_(shape) { - MOZ_ASSERT(shape_); - } + explicit Stub(Shape* shape) : shape_(shape) { MOZ_ASSERT(shape_); } Shape* shape() { return shape_; } @@ -183,8 +181,7 @@ struct ForOfPIC { public: explicit Chain(JSObject* picObject) - : BaseChain(), - picObject_(picObject), + : picObject_(picObject), arrayProto_(nullptr), arrayIteratorProto_(nullptr), arrayProtoShape_(nullptr), diff --git a/js/src/vm/Runtime.cpp b/js/src/vm/Runtime.cpp index 6bacf4dfc78c..a40381f9240f 100644 --- a/js/src/vm/Runtime.cpp +++ b/js/src/vm/Runtime.cpp @@ -107,7 +107,6 @@ JSRuntime::JSRuntime(JSRuntime* parentRuntime) readPrincipals(nullptr), canAddPrivateElement(&DefaultHostEnsureCanAddPrivateElementCallback), warningReporter(nullptr), - selfHostedLazyScript(), geckoProfiler_(thisFromCtor()), trustedPrincipals_(nullptr), wrapObjectCallbacks(&DefaultWrapObjectCallbacks), @@ -123,7 +122,6 @@ JSRuntime::JSRuntime(JSRuntime* parentRuntime) profilingScripts(false), scriptAndCountsVector(nullptr), watchtowerTestingLog(nullptr), - lcovOutput_(), jitRuntime_(nullptr), gc(thisFromCtor()), emptyString(nullptr), @@ -151,12 +149,7 @@ JSRuntime::JSRuntime(JSRuntime* parentRuntime) stackFormat_(parentRuntime ? js::StackFormat::Default : js::StackFormat::SpiderMonkey), wasmInstances(mutexid::WasmRuntimeInstances), - moduleAsyncEvaluatingPostOrder(ASYNC_EVALUATING_POST_ORDER_INIT), - moduleResolveHook(), - moduleMetadataHook(), - moduleDynamicImportHook(), - scriptPrivateAddRefHook(), - scriptPrivateReleaseHook() { + moduleAsyncEvaluatingPostOrder(ASYNC_EVALUATING_POST_ORDER_INIT) { JS_COUNT_CTOR(JSRuntime); liveRuntimesCount++; diff --git a/js/src/vm/SavedFrame.h b/js/src/vm/SavedFrame.h index a6eec16c3072..edce54add192 100644 --- a/js/src/vm/SavedFrame.h +++ b/js/src/vm/SavedFrame.h @@ -199,7 +199,7 @@ inline void AssertObjectIsSavedFrameOrWrapper(JSContext* cx, // to the subsumes callback, and should be special cased with a shortcut before // that. struct ReconstructedSavedFramePrincipals : public JSPrincipals { - explicit ReconstructedSavedFramePrincipals() : JSPrincipals() { + explicit ReconstructedSavedFramePrincipals() { MOZ_ASSERT(is(this)); this->refcount = 1; } diff --git a/js/src/vm/SavedStacks.h b/js/src/vm/SavedStacks.h index 1620fca5a203..a86f751c238a 100644 --- a/js/src/vm/SavedStacks.h +++ b/js/src/vm/SavedStacks.h @@ -161,8 +161,7 @@ class SavedStacks { public: SavedStacks() - : frames(), - bernoulliSeeded(false), + : bernoulliSeeded(false), bernoulli(1.0, 0x59fdad7f6b4cc573, 0x91adf38db96a9354), creatingSavedFrame(false) {} @@ -191,7 +190,7 @@ class SavedStacks { // An alloction metadata builder that marks cells with the JavaScript stack // at which they were allocated. struct MetadataBuilder : public AllocationMetadataBuilder { - MetadataBuilder() : AllocationMetadataBuilder() {} + MetadataBuilder() {} virtual JSObject* build(JSContext* cx, HandleObject obj, AutoEnterOOMUnsafeRegion& oomUnsafe) const override; }; diff --git a/js/src/vm/SelfHosting.cpp b/js/src/vm/SelfHosting.cpp index b84ddbe54e79..1976f2bdce31 100644 --- a/js/src/vm/SelfHosting.cpp +++ b/js/src/vm/SelfHosting.cpp @@ -2412,8 +2412,7 @@ class MOZ_STACK_CLASS AutoPrintSelfHostingFrontendContext JSContext* cx_; public: - explicit AutoPrintSelfHostingFrontendContext(JSContext* cx) - : FrontendContext(), cx_(cx) { + explicit AutoPrintSelfHostingFrontendContext(JSContext* cx) : cx_(cx) { setCurrentJSContext(cx_); } ~AutoPrintSelfHostingFrontendContext() { diff --git a/js/src/vm/SharedImmutableStringsCache.h b/js/src/vm/SharedImmutableStringsCache.h index 206bce697fa6..4ae17b5dc78c 100644 --- a/js/src/vm/SharedImmutableStringsCache.h +++ b/js/src/vm/SharedImmutableStringsCache.h @@ -308,7 +308,7 @@ class SharedImmutableStringsCache { Set set; - Inner() : set() {} + Inner() {} Inner(const Inner&) = delete; Inner& operator=(const Inner&) = delete; diff --git a/js/src/vm/Stack.h b/js/src/vm/Stack.h index 0f4eea8b5a49..34f38979c419 100644 --- a/js/src/vm/Stack.h +++ b/js/src/vm/Stack.h @@ -253,7 +253,7 @@ class AbstractFramePtr { class NullFramePtr : public AbstractFramePtr { public: - NullFramePtr() : AbstractFramePtr() {} + NullFramePtr() {} }; enum MaybeConstruct { NO_CONSTRUCT = false, CONSTRUCT = true }; diff --git a/js/src/vm/UbiNode.cpp b/js/src/vm/UbiNode.cpp index c541e933de65..424c5a9d7815 100644 --- a/js/src/vm/UbiNode.cpp +++ b/js/src/vm/UbiNode.cpp @@ -372,7 +372,7 @@ namespace JS { namespace ubi { RootList::RootList(JSContext* cx, bool wantNames /* = false */) - : cx(cx), edges(), wantNames(wantNames), inited(false) {} + : cx(cx), wantNames(wantNames), inited(false) {} std::pair RootList::init() { EdgeVectorTracer tracer(cx->runtime(), &edges, wantNames); diff --git a/js/src/vm/UbiNodeCensus.cpp b/js/src/vm/UbiNodeCensus.cpp index a313852f59d8..86bfd6a228a4 100644 --- a/js/src/vm/UbiNodeCensus.cpp +++ b/js/src/vm/UbiNodeCensus.cpp @@ -49,13 +49,12 @@ class SimpleCount : public CountType { public: explicit SimpleCount(UniqueTwoByteChars& label, bool reportCount = true, bool reportBytes = true) - : CountType(), - label(std::move(label)), + : label(std::move(label)), reportCount(reportCount), reportBytes(reportBytes) {} explicit SimpleCount() - : CountType(), label(nullptr), reportCount(true), reportBytes(true) {} + : label(nullptr), reportCount(true), reportBytes(true) {} void destructCount(CountBase& countBase) override { Count& count = static_cast(countBase); @@ -122,11 +121,11 @@ class BucketCount : public CountType { struct Count : CountBase { JS::ubi::Vector ids_; - explicit Count(BucketCount& count) : CountBase(count), ids_() {} + explicit Count(BucketCount& count) : CountBase(count) {} }; public: - explicit BucketCount() : CountType() {} + explicit BucketCount() {} void destructCount(CountBase& countBase) override { Count& count = static_cast(countBase); @@ -202,8 +201,7 @@ class ByCoarseType : public CountType { ByCoarseType(CountTypePtr& objects, CountTypePtr& scripts, CountTypePtr& strings, CountTypePtr& other, CountTypePtr& domNode) - : CountType(), - objects(std::move(objects)), + : objects(std::move(objects)), scripts(std::move(scripts)), strings(std::move(strings)), other(std::move(other)), @@ -412,9 +410,7 @@ class ByObjectClass : public CountType { public: ByObjectClass(CountTypePtr& classesType, CountTypePtr& otherType) - : CountType(), - classesType(std::move(classesType)), - otherType(std::move(otherType)) {} + : classesType(std::move(classesType)), otherType(std::move(otherType)) {} void destructCount(CountBase& countBase) override { Count& count = static_cast(countBase); @@ -524,7 +520,7 @@ class ByDomObjectClass : public CountType { public: explicit ByDomObjectClass(CountTypePtr& classesType) - : CountType(), classesType(std::move(classesType)) {} + : classesType(std::move(classesType)) {} void destructCount(CountBase& countBase) override { Count& count = static_cast(countBase); @@ -618,7 +614,7 @@ class ByUbinodeType : public CountType { public: explicit ByUbinodeType(CountTypePtr& entryType) - : CountType(), entryType(std::move(entryType)) {} + : entryType(std::move(entryType)) {} void destructCount(CountBase& countBase) override { Count& count = static_cast(countBase); @@ -763,9 +759,7 @@ class ByAllocationStack : public CountType { public: ByAllocationStack(CountTypePtr& entryType, CountTypePtr& noStackType) - : CountType(), - entryType(std::move(entryType)), - noStackType(std::move(noStackType)) {} + : entryType(std::move(entryType)), noStackType(std::move(noStackType)) {} void destructCount(CountBase& countBase) override { Count& count = static_cast(countBase); @@ -941,8 +935,7 @@ class ByFilename : public CountType { public: ByFilename(CountTypePtr&& thenType, CountTypePtr&& noFilenameType) - : CountType(), - thenType(std::move(thenType)), + : thenType(std::move(thenType)), noFilenameType(std::move(noFilenameType)) {} void destructCount(CountBase& countBase) override { diff --git a/js/src/wasm/WasmBCRegDefs.h b/js/src/wasm/WasmBCRegDefs.h index 912834b7b5d1..733e12eaef18 100644 --- a/js/src/wasm/WasmBCRegDefs.h +++ b/js/src/wasm/WasmBCRegDefs.h @@ -208,7 +208,7 @@ struct RegPtr : public Register { }; struct RegF32 : public FloatRegister { - RegF32() : FloatRegister() {} + RegF32() {} explicit RegF32(FloatRegister reg) : FloatRegister(reg) { MOZ_ASSERT(isSingle()); } @@ -217,7 +217,7 @@ struct RegF32 : public FloatRegister { }; struct RegF64 : public FloatRegister { - RegF64() : FloatRegister() {} + RegF64() {} explicit RegF64(FloatRegister reg) : FloatRegister(reg) { MOZ_ASSERT(isDouble()); } @@ -227,7 +227,7 @@ struct RegF64 : public FloatRegister { #ifdef ENABLE_WASM_SIMD struct RegV128 : public FloatRegister { - RegV128() : FloatRegister() {} + RegV128() {} explicit RegV128(FloatRegister reg) : FloatRegister(reg) { MOZ_ASSERT(isSimd128()); } diff --git a/js/src/wasm/WasmCodegenTypes.h b/js/src/wasm/WasmCodegenTypes.h index 5c6d15dc92bd..17140be30f34 100644 --- a/js/src/wasm/WasmCodegenTypes.h +++ b/js/src/wasm/WasmCodegenTypes.h @@ -254,8 +254,7 @@ struct TrapSite { #ifdef DEBUG insn(TrapMachineInsn::OfficialUD), #endif - pcOffset(-1), - bytecode() { + pcOffset(-1) { } TrapSite(TrapMachineInsn insn, FaultingCodeOffset fco, BytecodeOffset bytecode) @@ -319,7 +318,7 @@ struct Offsets { WASM_DECLARE_CACHEABLE_POD(Offsets); struct CallableOffsets : Offsets { - MOZ_IMPLICIT CallableOffsets(uint32_t ret = 0) : Offsets(), ret(ret) {} + MOZ_IMPLICIT CallableOffsets(uint32_t ret = 0) : ret(ret) {} // The offset of the return instruction precedes 'end' by a variable number // of instructions due to out-of-line codegen. @@ -331,8 +330,7 @@ struct CallableOffsets : Offsets { WASM_DECLARE_CACHEABLE_POD(CallableOffsets); struct FuncOffsets : CallableOffsets { - MOZ_IMPLICIT FuncOffsets() - : CallableOffsets(), uncheckedCallEntry(0), tierEntry(0) {} + MOZ_IMPLICIT FuncOffsets() : uncheckedCallEntry(0), tierEntry(0) {} // Function CodeRanges have a checked call entry which takes an extra // signature argument which is checked against the callee's signature before diff --git a/js/src/wasm/WasmFrameIter.cpp b/js/src/wasm/WasmFrameIter.cpp index 407678bcc9f0..2af500252a09 100644 --- a/js/src/wasm/WasmFrameIter.cpp +++ b/js/src/wasm/WasmFrameIter.cpp @@ -62,7 +62,6 @@ WasmFrameIter::WasmFrameIter(JitActivation* activation, wasm::Frame* fp) fp_(fp ? fp : activation->wasmExitFP()), instance_(nullptr), unwoundCallerFP_(nullptr), - unwoundJitFrameType_(), unwind_(Unwind::False), unwoundAddressOfReturnAddress_(nullptr), resumePCinCurrentFrame_(nullptr) { diff --git a/js/src/wasm/WasmTypeDef.h b/js/src/wasm/WasmTypeDef.h index 65a4b1d67a25..26906b641fa3 100644 --- a/js/src/wasm/WasmTypeDef.h +++ b/js/src/wasm/WasmTypeDef.h @@ -111,7 +111,7 @@ class FuncType { } public: - FuncType() : args_(), results_() {} + FuncType() {} FuncType(ValTypeVector&& args, ValTypeVector&& results) : args_(std::move(args)), results_(std::move(results)) {} @@ -298,7 +298,7 @@ class StructType { OutlineTraceOffsetVector outlineTraceOffsets_; public: - StructType() : fields_(), size_(0) {} + StructType() : size_(0) {} explicit StructType(StructFieldVector&& fields) : fields_(std::move(fields)), size_(0) {} diff --git a/js/src/wasm/WasmValue.h b/js/src/wasm/WasmValue.h index 08407187cc21..3601ee7cd6f3 100644 --- a/js/src/wasm/WasmValue.h +++ b/js/src/wasm/WasmValue.h @@ -172,7 +172,7 @@ class LitVal { Cell cell_; public: - LitVal() : type_(ValType()), cell_{} {} + LitVal() {} explicit LitVal(ValType type) : type_(type) { switch (type.kind()) { @@ -259,7 +259,7 @@ WASM_DECLARE_CACHEABLE_POD(LitVal::Cell); class MOZ_NON_PARAM Val : public LitVal { public: - Val() : LitVal() {} + Val() {} explicit Val(ValType type) : LitVal(type) {} explicit Val(const LitVal& val); explicit Val(uint32_t i32) : LitVal(i32) {} diff --git a/js/xpconnect/src/XPCJSRuntime.cpp b/js/xpconnect/src/XPCJSRuntime.cpp index 3012d91cdf5c..15c48b1d7b51 100644 --- a/js/xpconnect/src/XPCJSRuntime.cpp +++ b/js/xpconnect/src/XPCJSRuntime.cpp @@ -2783,9 +2783,7 @@ XPCJSRuntime::XPCJSRuntime(JSContext* aCx) mIID2NativeInterfaceMap(mozilla::MakeUnique()), mClassInfo2NativeSetMap(mozilla::MakeUnique()), mNativeSetMap(mozilla::MakeUnique()), - mWrappedNativeScopes(), mGCIsRunning(false), - mNativesToReleaseArray(), mDoingFinalization(false), mAsyncSnowWhiteFreer(new AsyncFreeSnowWhite()) { MOZ_COUNT_CTOR_INHERITED(XPCJSRuntime, CycleCollectedJSRuntime); diff --git a/layout/base/PresShell.cpp b/layout/base/PresShell.cpp index 64004dc3430e..1e69bb10b635 100644 --- a/layout/base/PresShell.cpp +++ b/layout/base/PresShell.cpp @@ -10003,8 +10003,7 @@ void PresShell::DelayedInputEvent::Dispatch() { widget->DispatchEvent(mEvent, status); } -PresShell::DelayedMouseEvent::DelayedMouseEvent(WidgetMouseEvent* aEvent) - : DelayedInputEvent() { +PresShell::DelayedMouseEvent::DelayedMouseEvent(WidgetMouseEvent* aEvent) { MOZ_DIAGNOSTIC_ASSERT(aEvent->IsTrusted()); WidgetMouseEvent* mouseEvent = new WidgetMouseEvent(true, aEvent->mMessage, aEvent->mWidget, @@ -10013,8 +10012,7 @@ PresShell::DelayedMouseEvent::DelayedMouseEvent(WidgetMouseEvent* aEvent) mEvent = mouseEvent; } -PresShell::DelayedKeyEvent::DelayedKeyEvent(WidgetKeyboardEvent* aEvent) - : DelayedInputEvent() { +PresShell::DelayedKeyEvent::DelayedKeyEvent(WidgetKeyboardEvent* aEvent) { MOZ_DIAGNOSTIC_ASSERT(aEvent->IsTrusted()); WidgetKeyboardEvent* keyEvent = new WidgetKeyboardEvent(true, aEvent->mMessage, aEvent->mWidget); diff --git a/layout/base/nsCounterManager.h b/layout/base/nsCounterManager.h index ccca4a2b2139..db40e64442dd 100644 --- a/layout/base/nsCounterManager.h +++ b/layout/base/nsCounterManager.h @@ -212,7 +212,7 @@ inline bool nsCounterNode::IsUnitializedIncrementNode() { class nsCounterList : public nsGenConList { public: nsCounterList(nsAtom* aCounterName, mozilla::ContainStyleScope* aScope) - : nsGenConList(), mCounterName(aCounterName), mScope(aScope) { + : mCounterName(aCounterName), mScope(aScope) { MOZ_ASSERT(aScope); } diff --git a/layout/generic/BlockReflowState.cpp b/layout/generic/BlockReflowState.cpp index 373cc55c139e..6a864c388004 100644 --- a/layout/generic/BlockReflowState.cpp +++ b/layout/generic/BlockReflowState.cpp @@ -43,7 +43,6 @@ BlockReflowState::BlockReflowState( mReflowInput .ComputedLogicalBorderPadding(mReflowInput.GetWritingMode()) .ApplySkipSides(aFrame->PreReflowBlockLevelLogicalSkipSides())), - mPrevBEndMargin(), mMinLineHeight(aReflowInput.GetLineHeight()), mLineNumber(0), mTrailingClearFromPIF(StyleClear::None), diff --git a/layout/generic/StickyScrollContainer.cpp b/layout/generic/StickyScrollContainer.cpp index 56ecd7f38305..2e9d32ab5fca 100644 --- a/layout/generic/StickyScrollContainer.cpp +++ b/layout/generic/StickyScrollContainer.cpp @@ -23,7 +23,7 @@ NS_DECLARE_FRAME_PROPERTY_DELETABLE(StickyScrollContainerProperty, StickyScrollContainer) StickyScrollContainer::StickyScrollContainer(nsIScrollableFrame* aScrollFrame) - : mScrollFrame(aScrollFrame), mScrollPosition() { + : mScrollFrame(aScrollFrame) { mScrollFrame->AddScrollPositionListener(this); } diff --git a/layout/generic/nsFrameSelection.cpp b/layout/generic/nsFrameSelection.cpp index f9fa873d818f..ebd566acf236 100644 --- a/layout/generic/nsFrameSelection.cpp +++ b/layout/generic/nsFrameSelection.cpp @@ -150,7 +150,6 @@ PeekOffsetStruct::PeekOffsetStruct(nsSelectionAmount aAmount, mDesiredCaretPos(aDesiredCaretPos), mWordMovementType(aWordMovementType), mOptions(aOptions), - mResultContent(), mResultFrame(nullptr), mContentOffset(0), mAttach(CARET_ASSOCIATE_BEFORE) {} diff --git a/layout/generic/nsGfxScrollFrame.cpp b/layout/generic/nsGfxScrollFrame.cpp index 94c1888abe4d..c4181a8feb11 100644 --- a/layout/generic/nsGfxScrollFrame.cpp +++ b/layout/generic/nsGfxScrollFrame.cpp @@ -246,7 +246,6 @@ nsHTMLScrollFrame::nsHTMLScrollFrame(ComputedStyle* aStyle, mLastPos(-1, -1), mApzScrollPos(0, 0), mLastUpdateFramesPos(-1, -1), - mDisplayPortAtLastFrameUpdate(), mScrollParentID(mozilla::layers::ScrollableLayerGuid::NULL_SCROLL_ID), mAnchor(this), mCurrentAPZScrollAnimationType(APZScrollAnimationType::No), diff --git a/layout/generic/nsIFrame.h b/layout/generic/nsIFrame.h index 14faa330bb04..011020eb65d8 100644 --- a/layout/generic/nsIFrame.h +++ b/layout/generic/nsIFrame.h @@ -590,8 +590,7 @@ class nsIFrame : public nsQueryFrame { explicit nsIFrame(ComputedStyle* aStyle, nsPresContext* aPresContext, ClassID aID) - : mRect(), - mContent(nullptr), + : mContent(nullptr), mComputedStyle(aStyle), mPresContext(aPresContext), mParent(nullptr), diff --git a/layout/generic/nsLineBox.cpp b/layout/generic/nsLineBox.cpp index 7afbd1630565..18051aa69a94 100644 --- a/layout/generic/nsLineBox.cpp +++ b/layout/generic/nsLineBox.cpp @@ -36,7 +36,6 @@ using namespace mozilla; nsLineBox::nsLineBox(nsIFrame* aFrame, int32_t aCount, bool aIsBlock) : mFirstChild(aFrame), - mWritingMode(), mContainerSize(-1, -1), mBounds(WritingMode()), // mBounds will be initialized with the correct // writing mode when it is set diff --git a/layout/generic/nsLineBox.h b/layout/generic/nsLineBox.h index f11c58267879..d46cf9604a42 100644 --- a/layout/generic/nsLineBox.h +++ b/layout/generic/nsLineBox.h @@ -535,8 +535,7 @@ class nsLineBox final : public nsLineLink { }; struct ExtraBlockData : public ExtraData { - explicit ExtraBlockData(const nsRect& aBounds) - : ExtraData(aBounds), mCarriedOutBEndMargin() {} + explicit ExtraBlockData(const nsRect& aBounds) : ExtraData(aBounds) {} nsCollapsingMargin mCarriedOutBEndMargin; }; diff --git a/layout/mathml/nsMathMLmfracFrame.h b/layout/mathml/nsMathMLmfracFrame.h index c457c96aa0b7..27f2fa27d29c 100644 --- a/layout/mathml/nsMathMLmfracFrame.h +++ b/layout/mathml/nsMathMLmfracFrame.h @@ -94,7 +94,6 @@ class nsMathMLmfracFrame final : public nsMathMLContainerFrame { explicit nsMathMLmfracFrame(ComputedStyle* aStyle, nsPresContext* aPresContext) : nsMathMLContainerFrame(aStyle, aPresContext, kClassID), - mLineRect(), mSlashChar(nullptr), mLineThickness(0) {} virtual ~nsMathMLmfracFrame(); diff --git a/layout/mathml/nsMathMLmrootFrame.cpp b/layout/mathml/nsMathMLmrootFrame.cpp index 5b4a48093ab7..c74767d7778f 100644 --- a/layout/mathml/nsMathMLmrootFrame.cpp +++ b/layout/mathml/nsMathMLmrootFrame.cpp @@ -30,9 +30,7 @@ NS_IMPL_FRAMEARENA_HELPERS(nsMathMLmrootFrame) nsMathMLmrootFrame::nsMathMLmrootFrame(ComputedStyle* aStyle, nsPresContext* aPresContext) - : nsMathMLContainerFrame(aStyle, aPresContext, kClassID), - mSqrChar(), - mBarRect() {} + : nsMathMLContainerFrame(aStyle, aPresContext, kClassID) {} nsMathMLmrootFrame::~nsMathMLmrootFrame() = default; diff --git a/layout/painting/nsDisplayList.h b/layout/painting/nsDisplayList.h index 79f92e902406..052931c89f8f 100644 --- a/layout/painting/nsDisplayList.h +++ b/layout/painting/nsDisplayList.h @@ -310,9 +310,7 @@ class nsDisplayListBuilder { : mAccumulatedRectLevels(0), mAllowAsyncAnimation(true) {} Preserves3DContext(const Preserves3DContext& aOther) - : mAccumulatedTransform(), - mAccumulatedRect(), - mAccumulatedRectLevels(0), + : mAccumulatedRectLevels(0), mVisibleRect(aOther.mVisibleRect), mAllowAsyncAnimation(aOther.mAllowAsyncAnimation) {} diff --git a/layout/style/nsStyleStruct.cpp b/layout/style/nsStyleStruct.cpp index fb4cce7384e0..462bbd6181f5 100644 --- a/layout/style/nsStyleStruct.cpp +++ b/layout/style/nsStyleStruct.cpp @@ -2760,8 +2760,7 @@ void nsStyleContent::TriggerImageLoads(Document& aDoc, // nsStyleTextReset::nsStyleTextReset() - : mTextOverflow(), - mTextDecorationLine(StyleTextDecorationLine::NONE), + : mTextDecorationLine(StyleTextDecorationLine::NONE), mTextDecorationStyle(StyleTextDecorationStyle::Solid), mUnicodeBidi(StyleUnicodeBidi::Normal), mInitialLetterSink(0), diff --git a/layout/svg/SVGTextFrame.cpp b/layout/svg/SVGTextFrame.cpp index 56b3bfa4940e..7dc2c2e8653f 100644 --- a/layout/svg/SVGTextFrame.cpp +++ b/layout/svg/SVGTextFrame.cpp @@ -1421,7 +1421,6 @@ class MOZ_STACK_CLASS TextFrameIterator { : mRootFrame(aRoot), mSubtree(aSubtree), mCurrentFrame(aRoot), - mCurrentPosition(), mSubtreePosition(mSubtree ? eBeforeSubtree : eWithinSubtree) { Init(); } @@ -1436,7 +1435,6 @@ class MOZ_STACK_CLASS TextFrameIterator { ? aSubtree->GetPrimaryFrame() : nullptr), mCurrentFrame(aRoot), - mCurrentPosition(), mSubtreePosition(mSubtree ? eBeforeSubtree : eWithinSubtree) { Init(); } diff --git a/layout/xul/tree/nsTreeBodyFrame.cpp b/layout/xul/tree/nsTreeBodyFrame.cpp index 479e1b0c4410..1592f83723ae 100644 --- a/layout/xul/tree/nsTreeBodyFrame.cpp +++ b/layout/xul/tree/nsTreeBodyFrame.cpp @@ -236,7 +236,6 @@ NS_QUERYFRAME_TAIL_INHERITING(SimpleXULLeafFrame) nsTreeBodyFrame::nsTreeBodyFrame(ComputedStyle* aStyle, nsPresContext* aPresContext) : SimpleXULLeafFrame(aStyle, aPresContext, kClassID), - mImageCache(), mTopRowIndex(0), mPageLength(0), mHorzPosition(0), diff --git a/media/webrtc/signaling/gtest/mediapipeline_unittest.cpp b/media/webrtc/signaling/gtest/mediapipeline_unittest.cpp index b9cc17014bf2..afbdb85f18e7 100644 --- a/media/webrtc/signaling/gtest/mediapipeline_unittest.cpp +++ b/media/webrtc/signaling/gtest/mediapipeline_unittest.cpp @@ -261,7 +261,6 @@ class TestAgent { aSharedState)), audio_conduit_( AudioSessionConduit::Create(call_, test_utils->sts_target())), - audio_pipeline_(), transport_(new LoopbackTransport) { Unused << WaitFor(InvokeAsync(call_->mCallThread, __func__, [&] { audio_conduit_->InitControl(&control_); diff --git a/memory/replace/dmd/DMD.cpp b/memory/replace/dmd/DMD.cpp index 2e12deda2407..c9a425170d01 100644 --- a/memory/replace/dmd/DMD.cpp +++ b/memory/replace/dmd/DMD.cpp @@ -744,11 +744,7 @@ class LiveBlock { public: LiveBlock(const void* aPtr, size_t aReqSize, const StackTrace* aAllocStackTrace) - : mPtr(aPtr), - mReqSize(aReqSize), - mAllocStackTrace(aAllocStackTrace), - mReportStackTrace_mReportedOnAlloc() // all fields get zeroed - {} + : mPtr(aPtr), mReqSize(aReqSize), mAllocStackTrace(aAllocStackTrace) {} const void* Address() const { return mPtr; } diff --git a/memory/replace/phc/PHC.cpp b/memory/replace/phc/PHC.cpp index f5a2b102e656..cecd9d5fff09 100644 --- a/memory/replace/phc/PHC.cpp +++ b/memory/replace/phc/PHC.cpp @@ -168,7 +168,7 @@ class InfallibleAllocPolicy { class StackTrace : public phc::StackTrace { public: - StackTrace() : phc::StackTrace() {} + StackTrace() {} void Clear() { mLength = 0; } @@ -546,10 +546,7 @@ class GMut { public: AllocPageInfo() : mState(AllocPageState::NeverAllocated), - mArenaId(), mBaseAddr(nullptr), - mAllocStack(), - mFreeStack(), mReuseTime(0) {} // The current allocation page state. @@ -619,9 +616,7 @@ class GMut { // The mutex that protects the other members. static Mutex sMutex MOZ_UNANNOTATED; - GMut() : mRNG(RandomSeed<0>(), RandomSeed<1>()), mAllocPages() { - sMutex.Init(); - } + GMut() : mRNG(RandomSeed<0>(), RandomSeed<1>()) { sMutex.Init(); } uint64_t Random64(GMutLock) { return mRNG.next(); } diff --git a/memory/replace/phc/PHC.h b/memory/replace/phc/PHC.h index b53897b70ef9..3c4519fbf646 100644 --- a/memory/replace/phc/PHC.h +++ b/memory/replace/phc/PHC.h @@ -91,12 +91,7 @@ class AddrInfo { bool mPhcWasLocked = false; // Default to no PHC info. - AddrInfo() - : mKind(Kind::Unknown), - mBaseAddr(nullptr), - mUsableSize(0), - mAllocStack(), - mFreeStack() {} + AddrInfo() : mKind(Kind::Unknown), mBaseAddr(nullptr), mUsableSize(0) {} }; // Global instance that is retrieved by the process generating the crash report diff --git a/modules/libpref/Preferences.cpp b/modules/libpref/Preferences.cpp index 37d9ab63c209..2ef82c60296a 100644 --- a/modules/libpref/Preferences.cpp +++ b/modules/libpref/Preferences.cpp @@ -2293,10 +2293,7 @@ class nsPrefLocalizedString final : public nsIPrefLocalizedString { //---------------------------------------------------------------------------- nsPrefBranch::nsPrefBranch(const char* aPrefRoot, PrefValueKind aKind) - : mPrefRoot(aPrefRoot), - mKind(aKind), - mFreeingObserverList(false), - mObservers() { + : mPrefRoot(aPrefRoot), mKind(aKind), mFreeingObserverList(false) { nsCOMPtr observerService = services::GetObserverService(); if (observerService) { ++mRefCnt; // must be > 0 when we call this, or we'll get deleted! diff --git a/mozglue/misc/AutoProfilerLabel.cpp b/mozglue/misc/AutoProfilerLabel.cpp index eaa70fa33518..1df6ea2b3731 100644 --- a/mozglue/misc/AutoProfilerLabel.cpp +++ b/mozglue/misc/AutoProfilerLabel.cpp @@ -38,7 +38,7 @@ class MOZ_RAII AutoProfilerLabelData { // Does not preserve behavior in JS record/replay. class Mutex : private mozilla::detail::MutexImpl { public: - Mutex() : mozilla::detail::MutexImpl() {} + Mutex() {} void Lock() { mozilla::detail::MutexImpl::lock(); } void Unlock() { mozilla::detail::MutexImpl::unlock(); } }; diff --git a/netwerk/base/BackgroundFileSaver.cpp b/netwerk/base/BackgroundFileSaver.cpp index bc52097da9a0..3af6b8eb2664 100644 --- a/netwerk/base/BackgroundFileSaver.cpp +++ b/netwerk/base/BackgroundFileSaver.cpp @@ -858,7 +858,7 @@ NS_IMPL_ISUPPORTS(BackgroundFileSaverOutputStream, nsIBackgroundFileSaver, nsIOutputStreamCallback) BackgroundFileSaverOutputStream::BackgroundFileSaverOutputStream() - : BackgroundFileSaver(), mAsyncWaitCallback(nullptr) {} + : mAsyncWaitCallback(nullptr) {} bool BackgroundFileSaverOutputStream::HasInfiniteBuffer() { return false; } diff --git a/netwerk/base/nsBufferedStreams.h b/netwerk/base/nsBufferedStreams.h index 5c5c7c07e73e..2bbbf45baf25 100644 --- a/netwerk/base/nsBufferedStreams.h +++ b/netwerk/base/nsBufferedStreams.h @@ -90,7 +90,7 @@ class nsBufferedInputStream final : public nsBufferedStream, NS_DECL_NSIASYNCINPUTSTREAMLENGTH NS_DECL_NSIINPUTSTREAMLENGTHCALLBACK - nsBufferedInputStream() : nsBufferedStream() {} + nsBufferedInputStream() {} static nsresult Create(REFNSIID aIID, void** aResult); @@ -146,7 +146,7 @@ class nsBufferedOutputStream : public nsBufferedStream, NS_DECL_NSIBUFFEREDOUTPUTSTREAM NS_DECL_NSISTREAMBUFFERACCESS - nsBufferedOutputStream() : nsBufferedStream() {} + nsBufferedOutputStream() {} static nsresult Create(REFNSIID aIID, void** aResult); diff --git a/netwerk/base/nsStreamLoader.cpp b/netwerk/base/nsStreamLoader.cpp index bd3ff25de947..7391b4ceb941 100644 --- a/netwerk/base/nsStreamLoader.cpp +++ b/netwerk/base/nsStreamLoader.cpp @@ -14,7 +14,7 @@ namespace mozilla { namespace net { -nsStreamLoader::nsStreamLoader() : mData() {} +nsStreamLoader::nsStreamLoader() {} NS_IMETHODIMP nsStreamLoader::Init(nsIStreamLoaderObserver* aStreamObserver, diff --git a/netwerk/dns/DNS.cpp b/netwerk/dns/DNS.cpp index bf20dd0e040a..91730989db30 100644 --- a/netwerk/dns/DNS.cpp +++ b/netwerk/dns/DNS.cpp @@ -414,7 +414,6 @@ AddrInfo::AddrInfo(const nsACString& host, DNSResolverType aResolverType, uint32_t aTTL) : ttl(aTTL), mHostName(host), - mCanonicalName(), mResolverType(aResolverType), mTRRType(aTRRType), mAddresses(std::move(addresses)) {} diff --git a/netwerk/dns/nsEffectiveTLDService.cpp b/netwerk/dns/nsEffectiveTLDService.cpp index 9e7030c16111..fafbc296d5f3 100644 --- a/netwerk/dns/nsEffectiveTLDService.cpp +++ b/netwerk/dns/nsEffectiveTLDService.cpp @@ -45,7 +45,7 @@ NS_IMPL_ISUPPORTS(nsEffectiveTLDService, nsIEffectiveTLDService, static nsEffectiveTLDService* gService = nullptr; nsEffectiveTLDService::nsEffectiveTLDService() - : mIDNService(), mGraphLock("nsEffectiveTLDService::mGraph") { + : mGraphLock("nsEffectiveTLDService::mGraph") { mGraph.emplace(etld_dafsa::kDafsa); } diff --git a/netwerk/protocol/about/nsAboutProtocolHandler.h b/netwerk/protocol/about/nsAboutProtocolHandler.h index 1a15400361be..e861f065b320 100644 --- a/netwerk/protocol/about/nsAboutProtocolHandler.h +++ b/netwerk/protocol/about/nsAboutProtocolHandler.h @@ -57,7 +57,7 @@ class nsNestedAboutURI final : public nsSimpleNestedURI { private: nsNestedAboutURI(nsIURI* aInnerURI, nsIURI* aBaseURI) : nsSimpleNestedURI(aInnerURI), mBaseURI(aBaseURI) {} - nsNestedAboutURI() : nsSimpleNestedURI() {} + nsNestedAboutURI() {} virtual ~nsNestedAboutURI() = default; public: diff --git a/netwerk/protocol/http/InterceptedHttpChannel.cpp b/netwerk/protocol/http/InterceptedHttpChannel.cpp index b4c3203536e4..2abf72b1653a 100644 --- a/netwerk/protocol/http/InterceptedHttpChannel.cpp +++ b/netwerk/protocol/http/InterceptedHttpChannel.cpp @@ -41,8 +41,7 @@ InterceptedHttpChannel::InterceptedHttpChannel( mProgressReported(0), mSynthesizedStreamLength(-1), mResumeStartPos(0), - mCallingStatusAndProgress(false), - mTimeStamps() { + mCallingStatusAndProgress(false) { // Pre-set the creation and AsyncOpen times based on the original channel // we are intercepting. We don't want our extra internal redirect to mask // any time spent processing the channel. diff --git a/security/certverifier/NSSCertDBTrustDomain.cpp b/security/certverifier/NSSCertDBTrustDomain.cpp index d8e327888011..38488a4e84b6 100644 --- a/security/certverifier/NSSCertDBTrustDomain.cpp +++ b/security/certverifier/NSSCertDBTrustDomain.cpp @@ -100,8 +100,6 @@ NSSCertDBTrustDomain::NSSCertDBTrustDomain( mHostname(hostname), mCertStorage(do_GetService(NS_CERT_STORAGE_CID)), mOCSPStaplingStatus(CertVerifier::OCSP_STAPLING_NEVER_CHECKED), - mSCTListFromCertificate(), - mSCTListFromOCSPStapling(), mBuiltInRootsModule(SECMOD_FindModule(kRootModuleName)), mOCSPFetchStatus(OCSPFetchStatus::NotFetched) {} diff --git a/security/manager/ssl/CommonSocketControl.cpp b/security/manager/ssl/CommonSocketControl.cpp index 7472b13f33dc..2208333fb352 100644 --- a/security/manager/ssl/CommonSocketControl.cpp +++ b/security/manager/ssl/CommonSocketControl.cpp @@ -31,9 +31,7 @@ CommonSocketControl::CommonSocketControl(const nsCString& aHostName, int32_t aPort, uint32_t aProviderFlags) : mHostName(aHostName), mPort(aPort), - mOriginAttributes(), mCanceled(false), - mSessionCacheInfo(), mHandshakeCompleted(false), mJoined(false), mSentClientCert(false), @@ -42,25 +40,13 @@ CommonSocketControl::CommonSocketControl(const nsCString& aHostName, mProviderFlags(aProviderFlags), mSecurityState(0), mErrorCode(0), - mFailedCertChain(), mServerCert(nullptr), - mSucceededCertChain(), - mCipherSuite(), - mKeaGroupName(), - mSignatureSchemeName(), - mProtocolVersion(), mCertificateTransparencyStatus(0), - mIsAcceptedEch(), - mIsDelegatedCredential(), - mOverridableErrorCategory(), mMadeOCSPRequests(false), mUsedPrivateDNS(false), - mIsEV(), mNPNCompleted(false), - mNegotiatedNPN(), mResumed(false), - mIsBuiltCertChainRootBuiltInRoot(false), - mPeerId() { + mIsBuiltCertChainRootBuiltInRoot(false) { #if defined(MOZ_DIAGNOSTIC_ASSERT_ENABLED) mOwningThread = PR_GetCurrentThread(); #endif diff --git a/security/manager/ssl/ScopedNSSTypes.h b/security/manager/ssl/ScopedNSSTypes.h index 7ed1b7201bb6..7d2567b8c523 100644 --- a/security/manager/ssl/ScopedNSSTypes.h +++ b/security/manager/ssl/ScopedNSSTypes.h @@ -192,7 +192,7 @@ class DigestBase { */ class Digest : public DigestBase { public: - explicit Digest() : DigestBase() {} + explicit Digest() {} static nsresult DigestBuf(SECOidTag hashAlg, Span buf, /*out*/ nsTArray& out) { @@ -263,7 +263,7 @@ class Digest : public DigestBase { // NS_ENSURE_SUCCESS(rv, rv); class HMAC : public DigestBase { public: - explicit HMAC() : DigestBase() {} + explicit HMAC() {} nsresult Begin(SECOidTag hashAlg, Span key) { if (!EnsureNSSInitializedChromeOrContent()) { diff --git a/security/manager/ssl/nsNSSCallbacks.cpp b/security/manager/ssl/nsNSSCallbacks.cpp index e299810cb74d..d1667e0161be 100644 --- a/security/manager/ssl/nsNSSCallbacks.cpp +++ b/security/manager/ssl/nsNSSCallbacks.cpp @@ -133,9 +133,7 @@ OCSPRequest::OCSPRequest(const nsACString& aiaLocation, mPOSTData(reinterpret_cast(ocspRequest), ocspRequestLength), mTimeout(timeout), mTimeoutTimer(nullptr), - mStartTime(), - mResponseResult(NS_ERROR_FAILURE), - mResponseBytes() { + mResponseResult(NS_ERROR_FAILURE) { MOZ_ASSERT(ocspRequestLength <= OCSP_REQUEST_MAX_LENGTH); } diff --git a/security/manager/ssl/nsNSSIOLayer.cpp b/security/manager/ssl/nsNSSIOLayer.cpp index 096f719d15fe..8279b643f686 100644 --- a/security/manager/ssl/nsNSSIOLayer.cpp +++ b/security/manager/ssl/nsNSSIOLayer.cpp @@ -750,7 +750,6 @@ static int16_t nsSSLIOLayerPoll(PRFileDesc* fd, int16_t in_flags, nsSSLIOLayerHelpers::nsSSLIOLayerHelpers(uint32_t aTlsFlags) : mTreatUnsafeNegotiationAsBroken(false), - mTLSIntoleranceInfo(), mVersionFallbackLimit(SSL_LIBRARY_VERSION_TLS_1_0), mutex("nsSSLIOLayerHelpers.mutex"), mTlsFlags(aTlsFlags) {} diff --git a/storage/mozStorageAsyncStatement.cpp b/storage/mozStorageAsyncStatement.cpp index d0bd81e69b27..5813da7e84bb 100644 --- a/storage/mozStorageAsyncStatement.cpp +++ b/storage/mozStorageAsyncStatement.cpp @@ -94,8 +94,7 @@ static AsyncStatementClassInfo sAsyncStatementClassInfo; //////////////////////////////////////////////////////////////////////////////// //// AsyncStatement -AsyncStatement::AsyncStatement() - : StorageBaseStatementInternal(), mFinalized(false) {} +AsyncStatement::AsyncStatement() : mFinalized(false) {} nsresult AsyncStatement::initialize(Connection* aDBConnection, sqlite3* aNativeConnection, diff --git a/storage/mozStorageService.cpp b/storage/mozStorageService.cpp index 5a7b0c955ff5..ac5a7b17888c 100644 --- a/storage/mozStorageService.cpp +++ b/storage/mozStorageService.cpp @@ -205,7 +205,6 @@ Service::AutoVFSRegistration::~AutoVFSRegistration() { Service::Service() : mMutex("Service::mMutex"), mRegistrationMutex("Service::mRegistrationMutex"), - mConnections(), mLastSensitivity(mozilla::intl::Collator::Sensitivity::Base) {} Service::~Service() { diff --git a/storage/mozStorageStatement.cpp b/storage/mozStorageStatement.cpp index 3aad04d29a30..96dbee3271c8 100644 --- a/storage/mozStorageStatement.cpp +++ b/storage/mozStorageStatement.cpp @@ -99,11 +99,9 @@ static StatementClassInfo sStatementClassInfo; //// Statement Statement::Statement() - : StorageBaseStatementInternal(), - mDBStatement(nullptr), + : mDBStatement(nullptr), mParamCount(0), mResultColumnCount(0), - mColumnNames(), mExecuting(false), mQueryStatusRecorded(false), mHasExecuted(false) {} diff --git a/toolkit/components/extensions/webrequest/ChannelWrapper.cpp b/toolkit/components/extensions/webrequest/ChannelWrapper.cpp index 16d9c60aacdc..a062e89abdc3 100644 --- a/toolkit/components/extensions/webrequest/ChannelWrapper.cpp +++ b/toolkit/components/extensions/webrequest/ChannelWrapper.cpp @@ -86,7 +86,7 @@ static const ClassificationStruct classificationArray[] = { namespace { class ChannelListHolder : public LinkedList { public: - ChannelListHolder() : LinkedList() {} + ChannelListHolder() {} ~ChannelListHolder(); }; diff --git a/toolkit/components/places/tests/gtest/mock_Link.h b/toolkit/components/places/tests/gtest/mock_Link.h index aa83a2fe7b20..03d9381d52dd 100644 --- a/toolkit/components/places/tests/gtest/mock_Link.h +++ b/toolkit/components/places/tests/gtest/mock_Link.h @@ -22,7 +22,7 @@ class mock_Link : public mozilla::dom::Link { typedef void (*Handler)(State); explicit mock_Link(Handler aHandlerFunction, bool aRunNextTest = true) - : mozilla::dom::Link(), mRunNextTest(aRunNextTest) { + : mRunNextTest(aRunNextTest) { AwaitNewNotification(aHandlerFunction); } diff --git a/toolkit/components/satchel/nsFormFillController.cpp b/toolkit/components/satchel/nsFormFillController.cpp index f3dd1f20171b..3e167bd3e4d8 100644 --- a/toolkit/components/satchel/nsFormFillController.cpp +++ b/toolkit/components/satchel/nsFormFillController.cpp @@ -90,7 +90,6 @@ nsFormFillController::nsFormFillController() mTimeout(50), mMinResultsForPopup(1), mMaxRows(0), - mLastRightClickTimeStamp(TimeStamp()), mDisableAutoComplete(false), mCompleteDefaultIndex(false), mCompleteSelectedIndex(false), diff --git a/toolkit/components/telemetry/core/TelemetryHistogram.cpp b/toolkit/components/telemetry/core/TelemetryHistogram.cpp index 9a0ccf896969..88ac88eb9ecc 100644 --- a/toolkit/components/telemetry/core/TelemetryHistogram.cpp +++ b/toolkit/components/telemetry/core/TelemetryHistogram.cpp @@ -976,7 +976,7 @@ namespace { Histogram::Histogram(HistogramID histogramId, const HistogramInfo& info, bool expired) - : mStorage(), mSingleStore(nullptr), mIsExpired(expired) { + : mSingleStore(nullptr), mIsExpired(expired) { if (IsExpired()) { return; } @@ -1117,8 +1117,7 @@ nsresult internal_ReflectKeyedHistogram( KeyedHistogram::KeyedHistogram(HistogramID id, const HistogramInfo& info, bool expired) - : mStorage(), - mSingleStore(nullptr), + : mSingleStore(nullptr), mId(id), mHistogramInfo(info), mIsExpired(expired) { diff --git a/toolkit/components/windowwatcher/nsWindowWatcher.cpp b/toolkit/components/windowwatcher/nsWindowWatcher.cpp index 9c8e6a919263..e2ed8fc5e963 100644 --- a/toolkit/components/windowwatcher/nsWindowWatcher.cpp +++ b/toolkit/components/windowwatcher/nsWindowWatcher.cpp @@ -228,9 +228,7 @@ NS_IMPL_QUERY_INTERFACE(nsWindowWatcher, nsIWindowWatcher, nsIPromptFactory, nsPIWindowWatcher) nsWindowWatcher::nsWindowWatcher() - : mEnumeratorList(), - mOldestWindow(nullptr), - mListLock("nsWindowWatcher.mListLock") {} + : mOldestWindow(nullptr), mListLock("nsWindowWatcher.mListLock") {} nsWindowWatcher::~nsWindowWatcher() { // delete data diff --git a/toolkit/mozapps/extensions/AddonManagerStartup.cpp b/toolkit/mozapps/extensions/AddonManagerStartup.cpp index 29b9d992413a..f9430307e2cf 100644 --- a/toolkit/mozapps/extensions/AddonManagerStartup.cpp +++ b/toolkit/mozapps/extensions/AddonManagerStartup.cpp @@ -479,7 +479,7 @@ Result Addon::UpdateLastModifiedTime() { } InstallLocation::InstallLocation(JSContext* cx, const JS::Value& value) - : WrapperBase(cx, value), mAddonsObj(cx), mAddonsIter() { + : WrapperBase(cx, value), mAddonsObj(cx) { mAddonsObj = GetObject("addons"); if (!mAddonsObj) { mAddonsObj = JS_NewPlainObject(cx); diff --git a/tools/profiler/core/memory_hooks.cpp b/tools/profiler/core/memory_hooks.cpp index 59e87d607c2b..b2908dd1fe9f 100644 --- a/tools/profiler/core/memory_hooks.cpp +++ b/tools/profiler/core/memory_hooks.cpp @@ -209,7 +209,7 @@ class InfallibleAllocWithoutHooksPolicy { // Define a custom implementation here. class Mutex : private ::mozilla::detail::MutexImpl { public: - Mutex() : ::mozilla::detail::MutexImpl() {} + Mutex() {} void Lock() { ::mozilla::detail::MutexImpl::lock(); } void Unlock() { ::mozilla::detail::MutexImpl::unlock(); } @@ -247,7 +247,7 @@ class AllocationTracker { AllocationSet; public: - AllocationTracker() : mAllocations(), mMutex() {} + AllocationTracker() {} void AddMemoryAddress(const void* memoryAddress) { MutexAutoLock lock(mMutex); diff --git a/tools/profiler/core/platform-linux-android.cpp b/tools/profiler/core/platform-linux-android.cpp index 1961aa94357d..2ee6ef6640ff 100644 --- a/tools/profiler/core/platform-linux-android.cpp +++ b/tools/profiler/core/platform-linux-android.cpp @@ -262,12 +262,7 @@ static void SigprofHandler(int aSignal, siginfo_t* aInfo, void* aContext) { errno = savedErrno; } -Sampler::Sampler(PSLockRef aLock) - : mMyPid(profiler_current_process_id()), - // We don't know what the sampler thread's ID will be until it runs, so - // set mSamplerTid to a dummy value and fill it in for real in - // SuspendAndSampleAndResumeThread(). - mSamplerTid{} { +Sampler::Sampler(PSLockRef aLock) : mMyPid(profiler_current_process_id()) { #if defined(USE_EHABI_STACKWALK) mozilla::EHABIStackWalkInit(); #endif diff --git a/tools/profiler/tests/gtest/LulTestDwarf.cpp b/tools/profiler/tests/gtest/LulTestDwarf.cpp index 55373ec093bc..d6460c759713 100644 --- a/tools/profiler/tests/gtest/LulTestDwarf.cpp +++ b/tools/profiler/tests/gtest/LulTestDwarf.cpp @@ -534,7 +534,7 @@ TEST_F(LulDwarfCFI, CIEVersion3ReturnColumn) { } struct CFIInsnFixture : public CFIFixture { - CFIInsnFixture() : CFIFixture() { + CFIInsnFixture() { data_factor = 0xb6f; return_register = 0x9be1ed9f; version = 3; @@ -2045,7 +2045,7 @@ TEST_F(LulDwarfCFIRestore, RestoreValExpressionRuleChangedValExpression) { } struct EHFrameFixture : public CFIInsnFixture { - EHFrameFixture() : CFIInsnFixture(), section(kBigEndian, 4, true) { + EHFrameFixture() : section(kBigEndian, 4, true) { encoded_pointer_bases.cfi = 0x7f496cb2; encoded_pointer_bases.text = 0x540f67b6; encoded_pointer_bases.data = 0xe3eab768; diff --git a/tools/profiler/tests/gtest/LulTestInfrastructure.h b/tools/profiler/tests/gtest/LulTestInfrastructure.h index 9faa7ca858d4..9ed7e9c99560 100644 --- a/tools/profiler/tests/gtest/LulTestInfrastructure.h +++ b/tools/profiler/tests/gtest/LulTestInfrastructure.h @@ -533,7 +533,6 @@ class CFISection : public Section { address_size_(address_size), eh_frame_(eh_frame), pointer_encoding_(lul::DW_EH_PE_absptr), - encoded_pointer_bases_(), entry_length_(NULL), in_fde_(false) { // The 'start', 'Here', and 'Mark' members of a CFISection all refer diff --git a/uriloader/exthandler/nsOSHelperAppServiceChild.h b/uriloader/exthandler/nsOSHelperAppServiceChild.h index f37caf010d12..05c2195d10e1 100644 --- a/uriloader/exthandler/nsOSHelperAppServiceChild.h +++ b/uriloader/exthandler/nsOSHelperAppServiceChild.h @@ -19,7 +19,7 @@ class nsIMIMEInfo; */ class nsOSHelperAppServiceChild : public nsExternalHelperAppService { public: - nsOSHelperAppServiceChild() : nsExternalHelperAppService(){}; + nsOSHelperAppServiceChild(){}; virtual ~nsOSHelperAppServiceChild() = default; NS_IMETHOD GetProtocolHandlerInfoFromOS(const nsACString& aScheme, diff --git a/widget/BasicEvents.h b/widget/BasicEvents.h index dfcf2744ce22..04711fad54a5 100644 --- a/widget/BasicEvents.h +++ b/widget/BasicEvents.h @@ -510,9 +510,7 @@ class WidgetEvent : public WidgetEventTime { SetDefaultComposedInNativeAnonymousContent(); } - WidgetEvent() : WidgetEventTime(), mPath(nullptr) { - MOZ_COUNT_CTOR(WidgetEvent); - } + WidgetEvent() : mPath(nullptr) { MOZ_COUNT_CTOR(WidgetEvent); } public: WidgetEvent(bool aIsTrusted, EventMessage aMessage, @@ -521,7 +519,7 @@ class WidgetEvent : public WidgetEventTime { MOZ_COUNTED_DTOR_VIRTUAL(WidgetEvent) - WidgetEvent(const WidgetEvent& aOther) : WidgetEventTime() { + WidgetEvent(const WidgetEvent& aOther) : WidgetEventTime(aOther) { MOZ_COUNT_CTOR(WidgetEvent); *this = aOther; } diff --git a/widget/ContentCache.cpp b/widget/ContentCache.cpp index df5748cb8a04..b6093fb3f78f 100644 --- a/widget/ContentCache.cpp +++ b/widget/ContentCache.cpp @@ -694,8 +694,7 @@ bool ContentCacheInChild::SetSelection( *****************************************************************************/ ContentCacheInParent::ContentCacheInParent(BrowserParent& aBrowserParent) - : ContentCache(), - mBrowserParent(aBrowserParent), + : mBrowserParent(aBrowserParent), mCommitStringByRequest(nullptr), mPendingCommitLength(0), mIsChildIgnoringCompositionEvents(false) {} diff --git a/widget/SystemTimeConverter.h b/widget/SystemTimeConverter.h index 4a074d573fec..aa2a760487e3 100644 --- a/widget/SystemTimeConverter.h +++ b/widget/SystemTimeConverter.h @@ -30,8 +30,6 @@ class SystemTimeConverter { public: SystemTimeConverter() : mReferenceTime(Time(0)), - mReferenceTimeStamp() // Initializes to the null timestamp - , mLastBackwardsSkewCheck(Time(0)), kTimeRange(std::numeric_limits