corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1167389 - Make FileList::mParent a smart pointer, and declare it to the cycle collector. r=ehsan

Browse Source
This commit is contained in:
Michael Layzell
2015-07-07 06:38:00 -04:00
parent 7667b7f0d1
commit b0dd7b6f6f
4 changed files with 5 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
dom/html/HTMLInputElement.cpp
View File

@@ -879,9 +879,6 @@ HTMLInputElement::HTMLInputElement(already_AddRefed<mozilla::dom::NodeInfo>& aNo
HTMLInputElement::~HTMLInputElement()
{
if (mFileList) {
mFileList->Disconnect();
}
if (mNumberControlSpinnerIsSpinning) {
StopNumberControlSpinnerSpin();
}
@@ -936,10 +933,7 @@ NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN_INHERITED(HTMLInputElement,
NS_IMPL_CYCLE_COLLECTION_UNLINK(mValidity)
NS_IMPL_CYCLE_COLLECTION_UNLINK(mControllers)
NS_IMPL_CYCLE_COLLECTION_UNLINK(mFiles)
if (tmp->mFileList) {
tmp->mFileList->Disconnect();
tmp->mFileList = nullptr;
}
NS_IMPL_CYCLE_COLLECTION_UNLINK(mFileList)
if (tmp->IsSingleLineTextControl(false)) {
tmp->mInputData.mState->Unlink();
}