corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1896711 part 3: Use MakeRefPtr/MakeAndAddRef to reduce boilerplate, in layout/base. r=TYLin

Browse Source 
Also remove some unnecessary null-checks for objects that we're allocating
infallibly.

Differential Revision: https://phabricator.services.mozilla.com/D210389
This commit is contained in:
Daniel Holbert
2024-05-15 07:29:20 +00:00
parent 3f02c7c39d
commit af69b59aae
8 changed files with 24 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
layout/base/PresShell.cpp
View File

@@ -5700,8 +5700,7 @@ void PresShell::SynthesizeMouseMove(bool aFromScroll) {
}
if (!mSynthMouseMoveEvent.IsPending()) {
RefPtr<nsSynthMouseMoveEvent> ev =
new nsSynthMouseMoveEvent(this, aFromScroll);
auto ev = MakeRefPtr<nsSynthMouseMoveEvent>(this, aFromScroll);
GetPresContext()->RefreshDriver()->AddRefreshObserver(
ev, FlushType::Display, "Synthetic mouse move event");
@@ -10500,11 +10499,10 @@ bool PresShell::VerifyIncrementalReflow() {
}
// Create a presentation context to view the new frame tree
RefPtr<nsPresContext> cx = new nsRootPresContext(
auto cx = MakeRefPtr<nsRootPresContext>(
mDocument, mPresContext->IsPaginated()
? nsPresContext::eContext_PrintPreview
: nsPresContext::eContext_Galley);
NS_ENSURE_TRUE(cx, false);
nsDeviceContext* dc = mPresContext->DeviceContext();
nsresult rv = cx->Init(dc);
@@ -10516,8 +10514,7 @@ bool PresShell::VerifyIncrementalReflow() {
nsIWidget* parentWidget = rootView->GetWidget();
// Create a new view manager.
RefPtr<nsViewManager> vm = new nsViewManager();
NS_ENSURE_TRUE(vm, false);
auto vm = MakeRefPtr<nsViewManager>();
rv = vm->Init(dc);
NS_ENSURE_SUCCESS(rv, false);