corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug 712914 - add some sanity checking when (de)serializing security info in the disk cache. r=michal

Browse Source
This commit is contained in:
Nick Hurley
2012-03-30 11:21:01 +02:00
parent 35ad2f6efc
commit ad61154559
5 changed files with 177 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
netwerk/cache/nsDiskCacheMap.cpp vendored
View File

@@ -787,12 +787,15 @@ nsDiskCacheMap::CreateDiskCacheEntry(nsDiskCacheBinding * binding,
if (!entry) return nsnull;
// Store security info, if it is serializable
nsCOMPtr<nsISerializable> serializable =
do_QueryInterface(entry->SecurityInfo());
nsCOMPtr<nsISupports> infoObj = entry->SecurityInfo();
nsCOMPtr<nsISerializable> serializable = do_QueryInterface(infoObj);
if (infoObj && !serializable) return nsnull;
if (serializable) {
nsCString info;
NS_SerializeToString(serializable, info);
entry->SetMetaDataElement("security-info", info.get());
nsresult rv = NS_SerializeToString(serializable, info);
if (NS_FAILED(rv)) return nsnull;
rv = entry->SetMetaDataElement("security-info", info.get());
if (NS_FAILED(rv)) return nsnull;
}
PRUint32 keySize = entry->Key()->Length() + 1;