corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1966027 - Document.parseHTMLUnsafe shouldn't sanitize as safe. r=emilio

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D249035
This commit is contained in:
Tom Schuster
2025-05-13 12:28:23 +00:00
committed by tschuster@mozilla.com
parent 49b12c4176
commit aceb72f7f9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dom/base/Document.cpp
View File

@@ -20332,13 +20332,13 @@ already_AddRefed<Document> Document::ParseHTMLUnsafe(
nsCOMPtr<nsIGlobalObject> global = nsCOMPtr<nsIGlobalObject> global =
do_QueryInterface(aGlobal.GetAsSupports()); do_QueryInterface(aGlobal.GetAsSupports());
RefPtr<Sanitizer> sanitizer = Sanitizer::GetInstance( RefPtr<Sanitizer> sanitizer = Sanitizer::GetInstance(
global, aOptions.mSanitizer.Value(), true, aError); global, aOptions.mSanitizer.Value(), /* aSafe */ false, aError);
if (aError.Failed()) { if (aError.Failed()) {
return nullptr; return nullptr;
} }
// Step 6. Call sanitize on document with sanitizer and false. // Step 6. Call sanitize on document with sanitizer and false.
sanitizer->Sanitize(doc, /* aSafe */ true, aError); sanitizer->Sanitize(doc, /* aSafe */ false, aError);
if (aError.Failed()) { if (aError.Failed()) {
return nullptr; return nullptr;
} }
@@ -20375,7 +20375,7 @@ already_AddRefed<Document> Document::ParseHTML(GlobalObject& aGlobal,
// from options with options and true. // from options with options and true.
nsCOMPtr<nsIGlobalObject> global = do_QueryInterface(aGlobal.GetAsSupports()); nsCOMPtr<nsIGlobalObject> global = do_QueryInterface(aGlobal.GetAsSupports());
RefPtr<Sanitizer> sanitizer = RefPtr<Sanitizer> sanitizer =
Sanitizer::GetInstance(global, aOptions.mSanitizer, true, aError); Sanitizer::GetInstance(global, aOptions.mSanitizer, /* aSafe */ true, aError);
if (aError.Failed()) { if (aError.Failed()) {
return nullptr; return nullptr;
} }