corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1709217 - Part 3: Get rid of NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_INDETERM; r=smaug

Browse Source 
Depends on D114182

Differential Revision: https://phabricator.services.mozilla.com/D114183
This commit is contained in:
Edgar Chen
2021-05-11 19:38:45 +00:00
parent 182170ed8f
commit accf4fc04d
4 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
devtools/server/actors/network-monitor/utils/network-utils.js
View File

@@ -310,7 +310,6 @@ const ErrorCodes = {
NS_ERROR_DOM_IMAGE_INACTIVE_DOCUMENT: 0x80530403, NS_ERROR_DOM_IMAGE_INACTIVE_DOCUMENT: 0x80530403,
NS_ERROR_DOM_IMAGE_INVALID_REQUEST: 0x80530404, NS_ERROR_DOM_IMAGE_INVALID_REQUEST: 0x80530404,
NS_ERROR_DOM_IMAGE_BROKEN: 0x80530405, NS_ERROR_DOM_IMAGE_BROKEN: 0x80530405,
NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_INDETERM: 0x80530408,
NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_STATE: 0x80530409, NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_STATE: 0x80530409,
NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_SUPPORTED: 0x8053040a, NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_SUPPORTED: 0x8053040a,
NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_VALUE: 0x8053040b, NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_VALUE: 0x8053040b,

3
dom/base/Document.cpp
View File

@@ -5389,7 +5389,8 @@ bool Document::QueryCommandIndeterm(const nsAString& aHTMLCommandName,
ErrorResult& aRv) { ErrorResult& aRv) {
// Only allow on HTML documents. // Only allow on HTML documents.
if (!IsHTMLOrXHTML()) { if (!IsHTMLOrXHTML()) {
aRv.Throw(NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_INDETERM); aRv.ThrowInvalidStateError(
"queryCommandIndeterm is only supported on HTML documents");
return false; return false;
} }
// Otherwise, don't throw exception for compatibility with Chrome. // Otherwise, don't throw exception for compatibility with Chrome.

1
dom/base/domerr.msg
View File

@@ -161,7 +161,6 @@ DOM4_MSG_DEF(EncodingError, "Invalid image request.", NS_ERROR_DOM_IMAGE_INVALID
DOM4_MSG_DEF(EncodingError, "Invalid encoded image data.", NS_ERROR_DOM_IMAGE_BROKEN) DOM4_MSG_DEF(EncodingError, "Invalid encoded image data.", NS_ERROR_DOM_IMAGE_BROKEN)
/* Editing command errors. */ /* Editing command errors. */
DOM4_MSG_DEF(InvalidStateError, "queryCommandIndeterm is only supported on HTML documents.", NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_INDETERM)
DOM4_MSG_DEF(InvalidStateError, "queryCommandState is only supported on HTML documents.", NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_STATE) DOM4_MSG_DEF(InvalidStateError, "queryCommandState is only supported on HTML documents.", NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_STATE)
DOM4_MSG_DEF(InvalidStateError, "queryCommandSupported is only supported on HTML documents.", NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_SUPPORTED) DOM4_MSG_DEF(InvalidStateError, "queryCommandSupported is only supported on HTML documents.", NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_SUPPORTED)
DOM4_MSG_DEF(InvalidStateError, "queryCommandValue is only supported on HTML documents.", NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_VALUE) DOM4_MSG_DEF(InvalidStateError, "queryCommandValue is only supported on HTML documents.", NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_VALUE)

1
xpcom/base/ErrorList.py
View File

@@ -756,7 +756,6 @@ with modules["DOM"]:
errors["NS_ERROR_DOM_IMAGE_BROKEN"] = FAILURE(1029) errors["NS_ERROR_DOM_IMAGE_BROKEN"] = FAILURE(1029)
# Editing command errors. # Editing command errors.
errors["NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_INDETERM"] = FAILURE(1032)
errors["NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_STATE"] = FAILURE(1033) errors["NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_STATE"] = FAILURE(1033)
errors["NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_SUPPORTED"] = FAILURE( errors["NS_ERROR_DOM_INVALID_STATE_DOCUMENT_QUERY_COMMAND_SUPPORTED"] = FAILURE(
1034 1034