corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1259660 - Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag r=masayuki

Browse Source 
Moved mozilla::WidgetMosueEventBase::buttonType in MouseEvents.h to mozilla::MouseButton in EventForwards.h, and mozilla::WidgetMouseEventBase::buttonsFlag to mozilla::MouseButtonsFlag so that any referer in header files do not need to include MouseEvents.h only for referring them. Instead, they just need to include EventForwards.h. Now when MouseEvents.h is changed, the rebuild speed becomes faster.

Differential Revision: https://phabricator.services.mozilla.com/D25325
This commit is contained in:
Srujana Peddinti
2019-04-21 20:13:34 +00:00
parent 5339df33de
commit abf70d4412
40 changed files with 264 additions and 276 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
dom/html/HTMLInputElement.cpp
View File

@@ -4012,8 +4012,8 @@ nsresult HTMLInputElement::PostHandleEvent(EventChainPostVisitor& aVisitor) {
// cancel all of these events for buttons
// XXXsmaug Why?
WidgetMouseEvent* mouseEvent = aVisitor.mEvent->AsMouseEvent();
if (mouseEvent->mButton == WidgetMouseEvent::eMiddleButton ||
mouseEvent->mButton == WidgetMouseEvent::eRightButton) {
if (mouseEvent->mButton == MouseButton::eMiddle ||
mouseEvent->mButton == MouseButton::eRight) {
if (mType == NS_FORM_INPUT_BUTTON || mType == NS_FORM_INPUT_RESET ||
mType == NS_FORM_INPUT_SUBMIT) {
if (aVisitor.mDOMEvent) {
@@ -4024,7 +4024,7 @@ nsresult HTMLInputElement::PostHandleEvent(EventChainPostVisitor& aVisitor) {
}
}
if (mType == NS_FORM_INPUT_NUMBER && aVisitor.mEvent->IsTrusted()) {
if (mouseEvent->mButton == WidgetMouseEvent::eLeftButton &&
if (mouseEvent->mButton == MouseButton::eLeft &&
!IgnoreInputEventWithModifier(mouseEvent, false)) {
nsNumberControlFrame* numberControlFrame =
do_QueryFrame(GetPrimaryFrame());
@@ -4192,7 +4192,7 @@ void HTMLInputElement::PostHandleEventForRangeThumb(
}
if (aVisitor.mEvent->mMessage == eMouseDown) {
if (aVisitor.mEvent->AsMouseEvent()->mButtons ==
WidgetMouseEvent::eLeftButtonFlag) {
MouseButtonsFlag::eLeftFlag) {
StartRangeThumbDrag(inputEvent);
} else if (mIsDraggingRange) {
CancelRangeThumbDrag();