corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove == comparison of dynamic java strings, and also prevent collapsing empty strings in the clipboard to null r=mfinkle

Browse Source
This commit is contained in:
Kartikaya Gupta
2011-10-12 16:24:35 -04:00
parent c8f9a9938b
commit abe83c5eae
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
embedding/android/GeckoAppShell.java
View File

@@ -849,6 +849,7 @@ public class GeckoAppShell
static SynchronousQueue<String> sClipboardQueue =
new SynchronousQueue<String>();
private static String EMPTY_STRING = new String();
// On some devices, access to the clipboard service needs to happen
// on a thread with a looper, so dispatch this to our looper thread
@@ -876,12 +877,12 @@ public class GeckoAppShell
text = cm.getText().toString();
}
try {
sClipboardQueue.put(text != null ? text : "");
sClipboardQueue.put(text != null ? text : EMPTY_STRING);
} catch (InterruptedException ie) {}
}});
try {
String ret = sClipboardQueue.take();
return ret == "" ? null : ret;
return (ret == EMPTY_STRING ? null : ret);
} catch (InterruptedException ie) {}
return null;
}