Bug 1571567 - Fix no-fallthrough errors in /toolkit. r=MattN

Differential Revision: https://phabricator.services.mozilla.com/D40746

toolkit/components/alerts/resources/content/alert.js

@@ -51,6 +51,7 @@ function prefillAlertInfo() {
         icon.src = window.arguments[12];
       }
     }
+    // fall through
     case 12: {
       if (window.arguments[11]) {
         let alertBox = document.getElementById("alertBox");
@@ -95,12 +96,16 @@ function prefillAlertInfo() {
         );
       }
     }
+    // fall through
     case 11:
       gAlertListener = window.arguments[10];
+    // fall through
     case 10:
       gReplacedWindow = window.arguments[9];
+    // fall through
     case 9:
       gRequireInteraction = window.arguments[8];
+    // fall through
     case 8:
       if (window.arguments[7]) {
         document
@@ -110,15 +115,19 @@ function prefillAlertInfo() {
           .getElementById("alertTextLabel")
           .setAttribute("lang", window.arguments[7]);
       }
+    // fall through
     case 7:
       if (window.arguments[6]) {
         document.getElementById("alertNotification").style.direction =
           window.arguments[6];
       }
+    // fall through
     case 6:
       gOrigin = window.arguments[5];
+    // fall through
     case 5:
       gAlertCookie = window.arguments[4];
+    // fall through
     case 4:
       gAlertTextClickable = window.arguments[3];
       if (gAlertTextClickable) {
@@ -129,6 +138,7 @@ function prefillAlertInfo() {
           .getElementById("alertTextLabel")
           .setAttribute("clickable", true);
       }
+    // fall through
     case 3:
       if (window.arguments[2]) {
         document.getElementById("alertBox").setAttribute("hasBodyText", true);
@@ -159,10 +169,12 @@ function prefillAlertInfo() {
         }
         bodyTextLabel.textContent = bodyText;
       }
+    // fall through
     case 2:
       document
         .getElementById("alertTitleLabel")
         .setAttribute("value", window.arguments[1]);
+    // fall through
     case 1:
       if (window.arguments[0]) {
         document.getElementById("alertBox").setAttribute("hasImage", true);
@@ -170,6 +182,7 @@ function prefillAlertInfo() {
           .getElementById("alertImage")
           .setAttribute("src", window.arguments[0]);
       }
+    // fall through
     case 0:
       break;
   }

toolkit/components/antitracking/test/browser/antitracking_head.js

@@ -509,6 +509,7 @@ this.AntiTracking = {
 
                   ifr.src = obj.nextPage;
                 });
+                break;
               case "navigate-topframe":
                 // pass-through
                 break;

toolkit/components/captivedetect/CaptiveDetect.jsm

@@ -209,7 +209,7 @@ function LoginObserver(captivePortalDetector) {
         case LOGIN_OBSERVER_STATE_BURST:
           // Wait while network stays idle for a short period
           state = LOGIN_OBSERVER_STATE_VERIFY_NEEDED;
-        // Fall though to start polling timer
+        // Fall through to start polling timer
         case LOGIN_OBSERVER_STATE_IDLE:
         // Just fall through to perform a captive portal check.
         case LOGIN_OBSERVER_STATE_VERIFY_NEEDED:

toolkit/components/normandy/actions/PreferenceRollbackAction.jsm

@@ -64,6 +64,7 @@ class PreferenceRollbackAction extends BaseAction {
           { reason: "rollback" }
         );
         TelemetryEnvironment.setExperimentInactive(rolloutSlug);
+        break;
       }
       case PreferenceRollouts.STATE_ROLLED_BACK: {
         // The rollout has already been rolled back, so nothing to do here.

toolkit/components/normandy/actions/ShowHeartbeatAction.jsm

@@ -149,6 +149,7 @@ class ShowHeartbeatAction extends BaseAction {
           );
           return false;
         }
+        break;
       }
 
       case "nag": {
@@ -161,6 +162,7 @@ class ShowHeartbeatAction extends BaseAction {
           );
           return false;
         }
+        break;
       }
 
       case "xdays": {

toolkit/components/passwordmgr/LoginHelper.jsm

@@ -456,7 +456,7 @@ this.LoginHelper = {
 
       for (let prop of aNewLoginData.enumerator) {
         switch (prop.name) {
-          // nsILoginInfo
+          // nsILoginInfo (fall through)
           case "origin":
           case "httpRealm":
           case "formActionOrigin":
@@ -464,7 +464,7 @@ this.LoginHelper = {
           case "password":
           case "usernameField":
           case "passwordField":
-          // nsILoginMetaInfo
+          // nsILoginMetaInfo (fall through)
           case "guid":
           case "timeCreated":
           case "timeLastUsed":

toolkit/components/passwordmgr/storage-json.js

@@ -435,8 +435,8 @@ this.LoginManagerStorage_json.prototype = {
               }
               break;
             }
-          // fall through
           // Normal cases.
+          // fall through
           case "httpRealm":
           case "id":
           case "usernameField":

toolkit/components/passwordmgr/storage-mozStorage.js

@@ -562,8 +562,8 @@ LoginManagerStorage_mozStorage.prototype = {
             }
             break;
           }
-        // Fall through
         // Normal cases.
+        // Fall through
         case "httpRealm":
         case "id":
         case "usernameField":

toolkit/components/places/tests/queries/test_containersQueries_sorting.js

@@ -440,6 +440,7 @@ function check_children_sorting(aRootNode, aExpectedSortingMode) {
       comparator = function(a, b) {
         return b.time - a.time;
       };
+    // fall through - we shouldn't do this, see bug 1572437.
     case Ci.nsINavHistoryQueryOptions.SORT_BY_DATEADDED_ASCENDING:
       comparator = function(a, b) {
         return a.dateAdded - b.dateAdded;

toolkit/components/resistfingerprinting/RFPHelper.jsm

@@ -179,6 +179,7 @@ class _RFPHelper {
       case 0: // will prompt
       // This should only happen when turning privacy.resistFingerprinting off.
       // Works like disabling accept-language spoofing.
+      // fall through
       case 1: // don't spoof
         if (
           Services.prefs.prefHasUserValue("javascript.use_us_english_locale")

toolkit/components/timermanager/UpdateTimerManager.jsm

@@ -72,6 +72,7 @@ TimerManager.prototype = {
         // to profile-after-change to initialize the timer.
         minInterval = 500;
         minFirstInterval = 500;
+      // fall through
       case "profile-after-change":
         this._timerMinimumDelay = Math.max(
           1000 *

toolkit/content/widgets/browser-custom-element.js

@@ -1840,6 +1840,7 @@
             }
             // don't break here. we need to eat keydown events.
           }
+          // fall through
           case "keypress":
           case "keyup": {
             // All keyevents should be eaten here during autoscrolling.

toolkit/modules/PopupNotifications.jsm

@@ -771,9 +771,8 @@ PopupNotifications.prototype = {
           for (let elt of this.panel.children) {
             elt.notification.timeShown = this.window.performance.now();
           }
-          break;
         }
-
+      // fall through
       case "TabSelect":
         let self = this;
         // setTimeout(..., 0) needed, otherwise openPopup from "activate" event

toolkit/mozapps/extensions/internal/XPIInstall.jsm

@@ -1421,6 +1421,7 @@ class AddonInstall {
         let stagedAddon = stagingDir.clone();
 
         this.unstageInstall(stagedAddon);
+        break;
       default:
         throw new Error(
           "Cannot cancel install of " +

toolkit/mozapps/extensions/test/browser/head.js

@@ -1410,7 +1410,7 @@ MockInstall.prototype = {
 
         this.state = AddonManager.STATE_DOWNLOADED;
         this.callListeners("onDownloadEnded");
-
+      // fall through
       case AddonManager.STATE_DOWNLOADED:
         this.state = AddonManager.STATE_INSTALLING;
         if (!this.callListeners("onInstallStarted")) {

toolkit/profile/content/profileSelection.js

@@ -188,6 +188,7 @@ function onProfilesKey(aEvent) {
       if (AppConstants.platform != "macosx") {
         break;
       }
+    // fall through
     case KeyEvent.DOM_VK_DELETE:
       ConfirmDelete();
       break;