From aa41db9b410dc3024a108cb9205821d90f7cf509 Mon Sep 17 00:00:00 2001
From: Magnus Melin <mkmelin+mozilla@iki.fi>
Date: Tue, 25 Mar 2025 15:33:35 +0000
Subject: [PATCH] Bug 1956233 - avoid getting URI prefs when not
 contentprincipal. r=jesup

Differential Revision: https://phabricator.services.mozilla.com/D242919
---
 caps/BasePrincipal.cpp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/caps/BasePrincipal.cpp b/caps/BasePrincipal.cpp
index cfe5efbe3682..be82137413d7 100644
--- a/caps/BasePrincipal.cpp
+++ b/caps/BasePrincipal.cpp
@@ -1067,6 +1067,12 @@ NS_IMETHODIMP
 BasePrincipal::IsURIInPrefList(const char* aPref, bool* aResult) {
   AssertIsOnMainThread();
   *aResult = false;
+
+  if (Kind() != eContentPrincipal) {
+    // We don't store prefs for non-content principals.
+    return NS_OK;
+  }
+
   nsCOMPtr<nsIURI> prinURI;
   nsresult rv = GetURI(getter_AddRefs(prinURI));
   if (NS_FAILED(rv) || !prinURI) {