[components] Closes https://github.com/mozilla-mobile/android-components/issues/7719: Remove all default headers from GeckoViewFetchClient.

This commit is contained in:
Sebastian Kaspari
2020-09-21 12:05:10 +02:00
parent db7d086612
commit a8b7b69812
14 changed files with 23 additions and 188 deletions

View File

@@ -27,7 +27,6 @@ import java.io.File
import java.io.IOException
import java.lang.Exception
import java.net.SocketTimeoutException
import java.util.Locale
import java.util.UUID
import java.util.concurrent.TimeUnit
@@ -73,48 +72,6 @@ abstract class FetchTestCases {
}
}
@Test
open fun get200WithDefaultHeaders() {
withServerResponding(
MockResponse()
) { client ->
val response = client.fetch(Request(rootUrl()))
assertEquals(200, response.status)
val request = takeRequest()
for (i in 0 until request.headers.size()) {
println(request.headers.name(i) + " = " + request.headers.value(i))
}
val headers = request.headers.filtered()
assertEquals(6, headers.size())
val names = headers.names()
assertTrue(names.contains("Host"))
assertTrue(names.contains("User-Agent"))
assertTrue(names.contains("Connection"))
assertTrue(names.contains("Accept-Encoding"))
assertTrue(names.contains("Accept"))
assertTrue(names.contains("Accept-Language"))
val host = url("/").host()
val port = url("/").port()
assertEquals("$host:$port", request.getHeader("Host"))
assertEquals("*/*", request.getHeader("Accept"))
assertEquals("*/*", request.getHeader("Accept-Language"))
assertEquals("gzip", request.getHeader("Accept-Encoding"))
// Ignoring case here: okhttp uses "Keep-Alive" and httpurlconnection uses "keep-alive".
// I do not want to override the header of either because I do not know if they read it
// internally and require a certain case.
assertEquals("keep-alive", request.getHeader("Connection")
.toLowerCase(Locale.ROOT))
}
}
@Test
open fun get200WithHeaders() {
withServerResponding(