Bug 1868440 - [ci] Upgrade taskcluster-taskgraph to v7.4.0, r=perftest-reviewers,geckoview-reviewers,ci-and-tooling,devtools-reviewers,taskgraph-reviewers,releng-reviewers,mach-reviewers,omc-reviewers,jmaher,hneiva,aminomancer,jari,dom-storage-reviewers,afinder,asuth,bhearsum,owlish
Differential Revision: https://phabricator.services.mozilla.com/D206260
This commit is contained in:
@@ -347,7 +347,7 @@ Adding the linter to the CI
|
||||
|
||||
First, the job will have to be declared in Taskcluster.
|
||||
|
||||
This should be done in the `mozlint Taskcluster configuration <https://searchfox.org/mozilla-central/source/taskcluster/ci/source-test/mozlint.yml>`_.
|
||||
This should be done in the `mozlint Taskcluster configuration <https://searchfox.org/mozilla-central/source/taskcluster/kinds/source-test/mozlint.yml>`_.
|
||||
You will need to define a symbol, how it is executed and on what kind of change.
|
||||
|
||||
For example, for ruff, the configuration is the following:
|
||||
|
||||
@@ -5,7 +5,7 @@ CondProf Addons is a linter for condprof customization JSON files (see :searchfo
|
||||
it reports linting errors if:
|
||||
|
||||
- any of the addons required by the customization files (e.g. see :searchfox:`testing/condprofile/condprof/customization/webext.json`)
|
||||
is not found in the tar file fetched through the `firefox-addons` fetch task (see :searchfox:`taskcluster/ci/fetch/browsertime.yml`)
|
||||
is not found in the tar file fetched through the `firefox-addons` fetch task (see :searchfox:`taskcluster/kinds/fetch/browsertime.yml`)
|
||||
- or the expected `firefox-addons` fetch task has not been found
|
||||
|
||||
Run Locally
|
||||
@@ -37,7 +37,7 @@ XPI file is missing from the firefox-addons.tar archive
|
||||
|
||||
This linting errors is expected to be reported if the linter detected that a confprof customization file
|
||||
requires an addon but the related xpi filename is not included in the firefox-addons.tar file fetched
|
||||
through the `firefox-addons` fetch task (see :searchfox:`taskcluster/ci/fetch/browsertime.yml`).
|
||||
through the `firefox-addons` fetch task (see :searchfox:`taskcluster/kinds/fetch/browsertime.yml`).
|
||||
|
||||
If the patch or phabricator revision is not meant to be landed, but only used as a temporary patch
|
||||
pushed on try or only applied locally (e.g. to run the tp6/tp6m webextensions perftests with a given
|
||||
@@ -50,14 +50,14 @@ the linting error have to be fixed before or along landing the change, either by
|
||||
- removing the addition to the customization file if it wasn't intended to include that addon to all runs
|
||||
of the tp6/tp6m webextensions perftests
|
||||
|
||||
- updating the `firefox-addons` fetch task as defined in :searchfox:`taskcluster/ci/fetch/browsertime.yml`
|
||||
- updating the `firefox-addons` fetch task as defined in :searchfox:`taskcluster/kinds/fetch/browsertime.yml`
|
||||
by creating a pull request in the github repository where the asset is stored, and ask a review from
|
||||
a peer of the `#webextensions-reviewer` and `#perftests-reviewers` review groups.
|
||||
|
||||
firefox-addons taskcluster config 'add-prefix' attribute should be set to 'firefox-addons/'
|
||||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
If this linting error is hit, then the `firefox-addons` task defined in :searchfox:`taskcluster/ci/fetch/browsertime.yml`
|
||||
If this linting error is hit, then the `firefox-addons` task defined in :searchfox:`taskcluster/kinds/fetch/browsertime.yml`
|
||||
is missing the `add-prefix` attribute or its value is not set to the expected 'firefox-addons/' subdir name.
|
||||
|
||||
This is enforced as a linting rule because when the condprof utility is going to build a conditioned profile
|
||||
@@ -69,7 +69,7 @@ names are already available in `$MOZ_FETCHES_DIR/firefox-addons`.
|
||||
firefox-addons taskcluser fetch config section not found
|
||||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
||||
|
||||
This linting error is hit if the linter does not find the expected `firefox-addons` task defined in :searchfox:`taskcluster/ci/fetch/browsertime.yml`
|
||||
This linting error is hit if the linter does not find the expected `firefox-addons` task defined in :searchfox:`taskcluster/kinds/fetch/browsertime.yml`
|
||||
or it is missing the expected `fetch` attribute.
|
||||
|
||||
Configuration
|
||||
|
||||
Reference in New Issue
Block a user