Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson

Differential Revision: https://phabricator.services.mozilla.com/D40745

browser/actors/LinkHandlerChild.jsm

@@ -119,6 +119,7 @@ class LinkHandlerChild extends ActorChild {
         case "apple-touch-icon-precomposed":
         case "fluid-icon":
           isRichIcon = true;
+        // fall through
         case "icon":
           if (iconAdded || link.hasAttribute("mask")) {
             // Masked icons are not supported yet.

browser/actors/PluginChild.jsm

@@ -494,8 +494,8 @@ class PluginChild extends JSWindowActorChild {
           "openPluginUpdatePage",
           pluginTag.id
         );
-      /* FALLTHRU */
 
+      /* FALLTHRU */
       case "PluginVulnerableNoUpdate":
       case "PluginClickToPlay":
         this._handleClickToPlayEvent(pluginElement);

browser/base/content/browser-places.js

@@ -155,8 +155,7 @@ var StarUI = {
           break;
         }
         this._isComposing = true;
-      // Explicit fall-through, during composition, panel shouldn't be
+      // Explicit fall-through, during composition, panel shouldn't be hidden automatically.
-      // hidden automatically.
       case "input":
       // Might have edited some text without keyboard events nor composition
       // events. Fall-through to cancel auto close in such case.

browser/base/content/browser.js

@@ -6058,6 +6058,7 @@ var CombinedStopReload = {
         if (event.button == 0 && !this.stop.disabled) {
           this._stopClicked = true;
         }
+        break;
       case "animationend": {
         if (
           event.target.classList.contains("toolbarbutton-animatable-image") &&

browser/base/content/tabbrowser-tabs.js

@@ -1733,6 +1733,7 @@
           if (relatedTarget && relatedTarget.ownerDocument == document) {
             break;
           }
+        // fall through
         case "mousemove":
           if (document.getElementById("tabContextMenu").state != "open") {
             this._unlockTabSizing();

browser/components/customizableui/PanelMultiView.jsm

@@ -1778,8 +1778,8 @@ var PanelView = class extends AssociatedToNode {
         if (!button || !button.classList.contains("subviewbutton-nav")) {
           break;
         }
-        // Fall-through...
       }
+      // Fall-through...
       case "Space":
       case "NumpadEnter":
       case "Enter": {

browser/components/newtab/common/Reducers.jsm

@@ -551,7 +551,7 @@ function DiscoveryStream(prevState = INITIAL_STATE.DiscoveryStream, action) {
 
   switch (action.type) {
     case at.DISCOVERY_STREAM_CONFIG_CHANGE:
-    // The reason this is a separate action is so it doesn't trigger a listener update on init
+    // Fall through to a separate action is so it doesn't trigger a listener update on init
     case at.DISCOVERY_STREAM_CONFIG_SETUP:
       return { ...prevState, config: action.data || {} };
     case at.DISCOVERY_STREAM_LAYOUT_UPDATE:

browser/components/newtab/lib/ASRouter.jsm

@@ -1875,6 +1875,7 @@ class _ASRouter {
           target,
           action.data && action.data.trigger
         );
+        break;
       case "BLOCK_MESSAGE_BY_ID":
         await this.blockMessageById(action.data.id);
         // Block the message but don't dismiss it in case the action taken has

browser/components/places/content/browserPlacesViews.js

@@ -2173,6 +2173,7 @@ this.PlacesPanelview = class extends PlacesViewBase {
         if (event.button != 1) {
           break;
         }
+      // fall through
       case "command":
         this._onCommand(event);
         break;

browser/components/preferences/in-content/main.js

@@ -3183,6 +3183,7 @@ class HandlerInfoWrapper {
         if (this instanceof InternalHandlerInfoWrapper) {
           return "ask";
         }
+        break;
 
       case kActionUsePlugin:
         return "plugin";
@@ -3201,10 +3202,10 @@ class HandlerInfoWrapper {
         if (gMainPane.isValidHandlerApp(preferredApp)) {
           return gMainPane._getIconURLForHandlerApp(preferredApp);
         }
-      // Explicit fall-through
 
       // This should never happen, but if preferredAction is set to some weird
       // value, then fall back to the generic application icon.
+      // Explicit fall-through
       default:
         return ICON_URL_APP;
     }

browser/modules/ContentSearch.jsm

@@ -208,6 +208,7 @@ var ContentSearch = {
         if (data != "init-complete") {
           break;
         }
+      // fall through
       case "nsPref:changed":
       case "browser-search-engine-modified":
         this._eventQueue.push({

browser/modules/TabsList.jsm

@@ -185,6 +185,7 @@ class TabsPanel extends TabsListBase {
           event.target.tab.toggleMuteAudio();
           break;
         }
+      // fall through
       default:
         super.handleEvent(event);
         break;