corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 868312: Various dom rooting fixes r=bz

Browse Source
This commit is contained in:
David Zbarsky
2013-05-04 03:52:57 -04:00
parent 65577db573
commit a4d5e39056
42 changed files with 212 additions and 208 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
dom/plugins/base/nsNPAPIPlugin.cpp
View File

@@ -1244,8 +1244,8 @@ _getpluginelement(NPP npp)
getter_AddRefs(holder));
NS_ENSURE_TRUE(holder, nullptr);
JSObject* obj = nullptr;
holder->GetJSObject(&obj);
JS::Rooted<JSObject*> obj(cx);
holder->GetJSObject(obj.address());
NS_ENSURE_TRUE(obj, nullptr);
return nsJSObjWrapper::GetNewOrUsed(npp, cx, obj);
@@ -1494,8 +1494,7 @@ _evaluate(NPP npp, NPObject* npobj, NPString *script, NPVariant *result)
JSAutoRequest req(cx);
JSObject *obj =
nsNPObjWrapper::GetNewOrUsed(npp, cx, npobj);
JS::Rooted<JSObject*> obj(cx, nsNPObjWrapper::GetNewOrUsed(npp, cx, npobj));
if (!obj) {
return false;