corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1315185 - Get rid of FileSystemFileEntry.createWriter, r=smaug

Browse Source
This commit is contained in:
Andrea Marchesini
2016-11-04 14:23:46 +01:00
parent fe1a742122
commit a36ca3b16a
4 changed files with 0 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
dom/filesystem/compat/FileSystemFileEntry.cpp
View File

@@ -90,14 +90,6 @@ FileSystemFileEntry::GetFullPath(nsAString& aPath, ErrorResult& aRv) const
} }
} }
void
FileSystemFileEntry::CreateWriter(VoidCallback& aSuccessCallback,
const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback) const
{
ErrorCallbackHelper::Call(GetParentObject(), aErrorCallback,
NS_ERROR_DOM_SECURITY_ERR);
}
void void
FileSystemFileEntry::GetFile(FileCallback& aSuccessCallback, FileSystemFileEntry::GetFile(FileCallback& aSuccessCallback,
const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback) const const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback) const

4
dom/filesystem/compat/FileSystemFileEntry.h
View File

@@ -41,10 +41,6 @@ public:
virtual void virtual void
GetFullPath(nsAString& aFullPath, ErrorResult& aRv) const override; GetFullPath(nsAString& aFullPath, ErrorResult& aRv) const override;
void
CreateWriter(VoidCallback& aSuccessCallback,
const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback) const;
void void
GetFile(FileCallback& aSuccessCallback, GetFile(FileCallback& aSuccessCallback,
const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback) const; const Optional<OwningNonNull<ErrorCallback>>& aErrorCallback) const;

10
dom/filesystem/compat/tests/test_basic.html
View File

@@ -71,15 +71,6 @@ function test_fileEntry_file() {
}); });
} }
function test_fileEntry_createWriter() {
fileEntry.createWriter(function(file) {
ok(false, "Something when wrong!");
}, function() {
ok(true, "We don't support createWrite");
next();
});
}
function test_fileEntry_getParent() { function test_fileEntry_getParent() {
fileEntry.getParent(function(entry) { fileEntry.getParent(function(entry) {
is(fileEntry.fullPath, entry.fullPath, "Top level FileEntry should return itself as parent."); is(fileEntry.fullPath, entry.fullPath, "Top level FileEntry should return itself as parent.");
@@ -425,7 +416,6 @@ var tests = [
test_fileEntry, test_fileEntry,
test_fileEntry_file, test_fileEntry_file,
test_fileEntry_createWriter,
test_fileEntry_getParent, test_fileEntry_getParent,
test_directoryEntry, test_directoryEntry,

5
dom/webidl/FileSystemFileEntry.webidl
View File

@@ -9,11 +9,6 @@ callback interface FileCallback {
}; };
interface FileSystemFileEntry : FileSystemEntry { interface FileSystemFileEntry : FileSystemEntry {
// the successCallback should be a FileWriteCallback but this method is not
// implemented. ErrorCallback will be called with SecurityError.
void createWriter (VoidCallback successCallback,
optional ErrorCallback errorCallback);
[BinaryName="GetFile"] [BinaryName="GetFile"]
void file (FileCallback successCallback, void file (FileCallback successCallback,
optional ErrorCallback errorCallback); optional ErrorCallback errorCallback);