corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1290337 - Part 13: Replace Value parameter to const Value& in finalizeInBackground. r=sfink

Browse Source
This commit is contained in:
Tooru Fujisawa
2016-09-11 18:15:23 +09:00
parent 59ba07a396
commit a33ab4d32a
6 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
dom/base/nsGlobalWindow.cpp
View File

@@ -667,7 +667,7 @@ class nsOuterWindowProxy : public js::Wrapper
public: public:
constexpr nsOuterWindowProxy() : js::Wrapper(0) { } constexpr nsOuterWindowProxy() : js::Wrapper(0) { }
virtual bool finalizeInBackground(JS::Value priv) const override { virtual bool finalizeInBackground(const JS::Value& priv) const override {
return false; return false;
} }

2
dom/bindings/Codegen.py
View File

@@ -11633,7 +11633,7 @@ class CGDOMJSProxyHandler_className(ClassMethod):
class CGDOMJSProxyHandler_finalizeInBackground(ClassMethod): class CGDOMJSProxyHandler_finalizeInBackground(ClassMethod):
def __init__(self, descriptor): def __init__(self, descriptor):
args = [Argument('JS::Value', 'priv')] args = [Argument('const JS::Value&', 'priv')]
ClassMethod.__init__(self, "finalizeInBackground", "bool", args, ClassMethod.__init__(self, "finalizeInBackground", "bool", args,
virtual=True, override=True, const=True) virtual=True, override=True, const=True)
self.descriptor = descriptor self.descriptor = descriptor

2
js/ipc/WrapperOwner.cpp
View File

@@ -93,7 +93,7 @@ class CPOWProxyHandler : public BaseProxyHandler
constexpr CPOWProxyHandler() constexpr CPOWProxyHandler()
: BaseProxyHandler(&family) {} : BaseProxyHandler(&family) {}
virtual bool finalizeInBackground(Value priv) const override { virtual bool finalizeInBackground(const Value& priv) const override {
return false; return false;
} }

2
js/public/Proxy.h
View File

@@ -211,7 +211,7 @@ class JS_FRIEND_API(BaseProxyHandler)
return offsetof(BaseProxyHandler, mFamily); return offsetof(BaseProxyHandler, mFamily);
} }
virtual bool finalizeInBackground(Value priv) const { virtual bool finalizeInBackground(const Value& priv) const {
/* /*
* Called on creation of a proxy to determine whether its finalize * Called on creation of a proxy to determine whether its finalize
* method can be finalized on the background thread. * method can be finalized on the background thread.

2
js/src/jswrapper.h
View File

@@ -66,7 +66,7 @@ class JS_FRIEND_API(Wrapper) : public BaseProxyHandler
mFlags(aFlags) mFlags(aFlags)
{ } { }
virtual bool finalizeInBackground(Value priv) const override; virtual bool finalizeInBackground(const Value& priv) const override;
/* Standard internal methods. */ /* Standard internal methods. */
virtual bool getOwnPropertyDescriptor(JSContext* cx, HandleObject proxy, HandleId id, virtual bool getOwnPropertyDescriptor(JSContext* cx, HandleObject proxy, HandleId id,

2
js/src/proxy/Wrapper.cpp
View File

@@ -21,7 +21,7 @@
using namespace js; using namespace js;
bool bool
Wrapper::finalizeInBackground(Value priv) const Wrapper::finalizeInBackground(const Value& priv) const
{ {
if (!priv.isObject()) if (!priv.isObject())
return true; return true;