corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1717680, use popup.triggerNode instead of document.popupNode in browser menu commands, r=Gijs

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D118522
This commit is contained in:
Neil Deakin
2021-07-09 11:51:14 +00:00
parent b239aadf74
commit a2b0395af6
4 changed files with 7 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
browser/components/customizableui/content/panelUI.inc.xhtml
View File

@@ -44,18 +44,18 @@
contexttype="toolbaritem"
class="customize-context-reportExtension"/>
<menuseparator/>
<menuitem oncommand="gCustomizeMode.addToPanel(document.popupNode, 'panelitem-context')"
<menuitem oncommand="gCustomizeMode.addToPanel(this.parentNode.triggerNode, 'panelitem-context')"
id="customizationPanelItemContextMenuPin"
data-lazy-l10n-id="toolbar-context-menu-pin-to-overflow-menu"
closemenu="single"
class="customize-context-moveToPanel"/>
<menuitem oncommand="gCustomizeMode.addToToolbar(document.popupNode, 'panelitem-context')"
<menuitem oncommand="gCustomizeMode.addToToolbar(this.parentNode.triggerNode, 'panelitem-context')"
id="customizationPanelItemContextMenuUnpin"
closemenu="single"
class="customize-context-moveToToolbar"
accesskey="&customizeMenu.unpinFromOverflowMenu.accesskey;"
label="&customizeMenu.unpinFromOverflowMenu.label;"/>
<menuitem oncommand="gCustomizeMode.removeFromArea(document.popupNode, 'panelitem-context')"
<menuitem oncommand="gCustomizeMode.removeFromArea(this.parentNode.triggerNode, 'panelitem-context')"
closemenu="single"
class="customize-context-removeFromPanel"
data-lazy-l10n-id="toolbar-context-menu-remove-from-toolbar"/>
@@ -194,11 +194,11 @@
<html:template id="customModeWrapper">
<menupopup id="customizationPaletteItemContextMenu"
onpopupshowing="gCustomizeMode.onPaletteContextMenuShowing(event)">
<menuitem oncommand="gCustomizeMode.addToToolbar(document.popupNode, 'palette-context')"
<menuitem oncommand="gCustomizeMode.addToToolbar(this.parentNode.triggerNode, 'palette-context')"
class="customize-context-addToToolbar"
accesskey="&customizeMenu.addToToolbar.accesskey;"
label="&customizeMenu.addToToolbar.label;"/>
<menuitem oncommand="gCustomizeMode.addToPanel(document.popupNode, 'palette-context')"
<menuitem oncommand="gCustomizeMode.addToPanel(this.parentNode.triggerNode, 'palette-context')"
class="customize-context-addToPanel"
accesskey="&customizeMenu.addToOverflowMenu.accesskey;"
label="&customizeMenu.addToOverflowMenu.label;"/>