corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1800319 - Change newtab code so that the ESLint rule no-console is an error, except for console.error calls. r=Mardak

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D161942
This commit is contained in:
Mark Banner
2022-11-13 21:02:41 +00:00
parent d0ed675301
commit 9ecec1531f
13 changed files with 24 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
browser/components/newtab/content-src/asrouter/asrouter-content.jsx
View File

@@ -50,7 +50,7 @@ export class ASRouterUISurface extends React.PureComponent {
if (!fxaEndpoint) {
const err =
"Tried to fetch flow params before fxaEndpoint pref was ready";
console.error(err); // eslint-disable-line no-console
console.error(err);
}
try {
@@ -64,10 +64,10 @@ export class ASRouterUISurface extends React.PureComponent {
const { deviceId, flowId, flowBeginTime } = await response.json();
result = { deviceId, flowId, flowBeginTime };
} else {
console.error("Non-200 response", response); // eslint-disable-line no-console
console.error("Non-200 response", response);
}
} catch (error) {
console.error(error); // eslint-disable-line no-console
console.error(error);
}
return result;
}

3
browser/components/newtab/content-src/asrouter/template-utils.js
View File

@@ -15,7 +15,8 @@ export function safeURI(url) {
"chrome:",
].includes(protocol);
if (!isAllowed) {
console.warn(`The protocol ${protocol} is not allowed for template URLs.`); // eslint-disable-line no-console
// eslint-disable-next-line no-console
console.warn(`The protocol ${protocol} is not allowed for template URLs.`);
}
return isAllowed ? url : "";
}

3
browser/components/newtab/content-src/asrouter/templates/SubmitFormSnippet/SubmitFormSnippet.jsx
View File

@@ -69,7 +69,7 @@ export class SubmitFormSnippet extends React.PureComponent {
const response = await fetch(fetchRequest); // eslint-disable-line fetch-options/no-fetch-credentials
json = await response.json();
} catch (err) {
console.log(err); // eslint-disable-line no-console
console.error(err);
}
if (json && json.status === "ok") {
@@ -83,7 +83,6 @@ export class SubmitFormSnippet extends React.PureComponent {
id: "NEWTAB_FOOTER_BAR_CONTENT",
});
} else {
// eslint-disable-next-line no-console
console.error(
"There was a problem submitting the form",
json || "[No JSON response]"

2
browser/components/newtab/content-src/components/ASRouterAdmin/ASRouterAdmin.jsx
View File

@@ -669,7 +669,7 @@ export class ASRouterAdminInner extends React.PureComponent {
try {
JSON.parse(value);
} catch (e) {
console.log(`Error parsing value of parameter ${name}`); // eslint-disable-line no-console
console.error(`Error parsing value of parameter ${name}`);
targetingParametersError = { id: name };
}

4
browser/components/newtab/content-src/components/DiscoveryStreamBase/DiscoveryStreamBase.jsx
View File

@@ -79,7 +79,7 @@ export class _DiscoveryStreamBase extends React.PureComponent {
[...rule.style].forEach(property => {
const value = rule.style[property];
if (!isAllowedCSS(property, value)) {
console.error(`Bad CSS declaration ${property}: ${value}`); // eslint-disable-line no-console
console.error(`Bad CSS declaration ${property}: ${value}`);
rule.style.removeProperty(property);
}
});
@@ -102,7 +102,7 @@ export class _DiscoveryStreamBase extends React.PureComponent {
// CSSOM silently ignores bad selectors, so we'll be noisy instead
if (rule.selectorText === DUMMY_CSS_SELECTOR) {
console.error(`Bad CSS selector ${selectors}`); // eslint-disable-line no-console
console.error(`Bad CSS selector ${selectors}`);
}
});
});

2
browser/components/newtab/content-src/lib/aboutwelcome-utils.js
View File

@@ -44,7 +44,7 @@ export const AboutWelcomeUtils = {
const { deviceId, flowId, flowBeginTime } = await response.json();
flowParams = { deviceId, flowId, flowBeginTime };
} else {
console.error("Non-200 response", response); // eslint-disable-line no-console
console.error("Non-200 response", response);
}
} catch (e) {
flowParams = null;

2
browser/components/newtab/content-src/lib/init-store.js
View File

@@ -161,7 +161,7 @@ export function initStore(reducers, initialState) {
try {
store.dispatch(msg.data);
} catch (ex) {
console.error("Content msg:", msg, "Dispatch error: ", ex); // eslint-disable-line no-console
console.error("Content msg:", msg, "Dispatch error: ", ex);
dump(
`Content msg: ${JSON.stringify(msg)}\nDispatch error: ${ex}\n${
ex.stack