corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1328821 - hash completion request for v4 should not depend on table freshness. r=francois,henry

Browse Source 
MozReview-Commit-ID: EIjDrnj1I4S
This commit is contained in:
dimi
2017-01-17 08:33:08 +08:00
parent 18628185f3
commit 9cac186808
9 changed files with 89 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
toolkit/components/url-classifier/LookupCache.cpp
View File

@@ -421,10 +421,10 @@ LookupCacheV2::ClearAll()
nsresult
LookupCacheV2::Has(const Completion& aCompletion,
bool* aHas, bool* aComplete,
uint32_t* aMatchLength)
bool* aHas, uint32_t* aMatchLength,
bool* aFromCache)
{
*aHas = *aComplete = false;
*aHas = *aFromCache = false;
*aMatchLength = 0;
uint32_t prefix = aCompletion.ToUint32();
@@ -443,7 +443,7 @@ LookupCacheV2::Has(const Completion& aCompletion,
if ((mGetHashCache.BinaryIndexOf(aCompletion) != nsTArray<Completion>::NoIndex) ||
(mUpdateCompletions.BinaryIndexOf(aCompletion) != nsTArray<Completion>::NoIndex)) {
LOG(("Complete in %s", mTableName.get()));
*aComplete = true;
*aFromCache = true;
*aHas = true;
*aMatchLength = COMPLETE_SIZE;
}
@@ -451,6 +451,25 @@ LookupCacheV2::Has(const Completion& aCompletion,
return NS_OK;
}
void
LookupCacheV2::IsHashEntryConfirmed(const Completion& aEntry,
const TableFreshnessMap& aTableFreshness,
uint32_t aFreshnessGuarantee,
bool* aConfirmed)
{
int64_t age; // in seconds
bool found = aTableFreshness.Get(mTableName, &age);
if (!found) {
*aConfirmed = false;
} else {
int64_t now = (PR_Now() / PR_USEC_PER_SEC);
MOZ_ASSERT(age <= now);
// Considered completion as unsafe if its table is up-to-date.
*aConfirmed = (now - age) < aFreshnessGuarantee;
}
}
nsresult
LookupCacheV2::Build(AddPrefixArray& aAddPrefixes,
AddCompleteArray& aAddCompletes)