corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1891604 - Change the x sign in the Screenshots overlay to × r=niklas,sfoster,fluent-reviewers,bolsson

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D207480
This commit is contained in:
Itiel
2024-04-16 23:30:45 +00:00
parent b3741c10d2
commit 9c5308cf95
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
browser/components/screenshots/ScreenshotsOverlayChild.sys.mjs
View File

@@ -1387,7 +1387,7 @@ export class ScreenshotsOverlay {
let [selectionSizeTranslation] =
lazy.overlayLocalization.formatMessagesSync([
{
id: "screenshots-overlay-selection-region-size-2",
id: "screenshots-overlay-selection-region-size-3",
args: {
width: Math.floor(width * zoom),
height: Math.floor(height * zoom),

6
browser/components/screenshots/tests/browser/browser_test_selection_size_text.js
View File

@@ -22,7 +22,7 @@ add_task(async function test_selectionSizeTest() {
Assert.equal(
actualText,
`${400 * dpr} x ${400 * dpr}`,
`${400 * dpr} × ${400 * dpr}`,
"The selection size text is the same"
);
}
@@ -50,7 +50,7 @@ add_task(async function test_selectionSizeTestAt1Point5Zoom() {
Assert.equal(
actualText,
`${400 * dpr * zoom} x ${400 * dpr * zoom}`,
`${400 * dpr * zoom} × ${400 * dpr * zoom}`,
"The selection size text is the same"
);
}
@@ -78,7 +78,7 @@ add_task(async function test_selectionSizeTestAtPoint5Zoom() {
Assert.equal(
actualText,
`${400 * dpr * zoom} x ${400 * dpr * zoom}`,
`${400 * dpr * zoom} × ${400 * dpr * zoom}`,
"The selection size text is the same"
);
}

4
browser/locales/en-US/browser/screenshots.ftl
View File

@@ -94,8 +94,8 @@ screenshots-component-copy-key = C
##
# This string represents the selection size area
# "x" here represents "by" (i.e 123 by 456)
# "×" here represents "by" (i.e 123 by 456)
# Variables:
# $width (Number) - The width of the selection region in pixels
# $height (Number) - The height of the selection region in pixels
screenshots-overlay-selection-region-size-2 = { $width } x { $height }
screenshots-overlay-selection-region-size-3 = { $width } × { $height }