Bug 1872229 - Fix minor lint check failures in android-components r=android-reviewers,mcarare,webcompat-reviewers,twisniewski

We have moved more lint checks upstream to AC and these failures are
trivial to solve, rather than try to suppress.

Differential Revision: https://phabricator.services.mozilla.com/D236392
This commit is contained in:
Jonathan Almeida
2025-04-09 22:32:23 +00:00
parent ba490cbb60
commit 9956a54ab3
128 changed files with 1645 additions and 40 deletions

View File

@@ -152,6 +152,13 @@ subprojects {
}
android {
// We can't have one baseline file at the root of android-components because
// this is not a project module and we would have to coordinate every module to
// merge baselines.
lint {
baseline = file("${projectDir}/lint-baseline.xml")
}
buildToolsVersion gradle.mozconfig.substs.ANDROID_BUILD_TOOLS_VERSION
testOptions {

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,48 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/browser/engine/gecko/translate/GeckoTranslateSessionDelegate.kt"
line="3"
column="62"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/browser/engine/gecko/translate/GeckoTranslationUtils.kt"
line="3"
column="62"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/browser/engine/fission/GeckoWebContentIsolationMapper.kt"
line="3"
column="62"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/browser/engine/gecko/mediaquery/PreferredColorScheme.kt"
line="3"
column="62"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,48 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" imageTintList = ContextCompat.getColorStateList(context, tintColorResource)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/browser/menu/item/BrowserMenuImageText.kt"
line="29"
column="25"/>
</issue>
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" imageTintList = ContextCompat.getColorStateList(context, tintColorResource)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/browser/menu/item/BrowserMenuImageText.kt"
line="29"
column="25"/>
</issue>
<issue
id="UnsafeCompatGetDrawable"
message="This call can lead to crashes, replace with AppCompatResources.getDrawable"
errorLine1=" ContextCompat.getDrawable(button.context, primaryStateIconResource)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/browser/menu/item/BrowserMenuImageTextCheckboxButton.kt"
line="82"
column="13"/>
</issue>
<issue
id="UnsafeCompatGetDrawable"
message="This call can lead to crashes, replace with AppCompatResources.getDrawable"
errorLine1=" ContextCompat.getDrawable(button.context, secondaryStateIconResource)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/browser/menu/item/BrowserMenuImageTextCheckboxButton.kt"
line="84"
column="13"/>
</issue>
</issues>

View File

@@ -0,0 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="UnsafeCompatGetDrawable"
message="This call can lead to crashes, replace with AppCompatResources.getDrawable"
errorLine1=" val selectableBackground = ContextCompat.getDrawable("
errorLine2=" ^">
<location
file="src/main/java/mozilla/components/browser/menu2/ext/View.kt"
line="80"
column="36"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/browser/state/ext/PermissionRequest.kt"
line="3"
column="62"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" imageTintList = ContextCompat.getColorStateList(context, tintColorResource)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/browser/toolbar/BrowserToolbar.kt"
line="45"
column="25"/>
</issue>
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" imageTintList = ContextCompat.getColorStateList(context, tintColorResource)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/browser/toolbar/BrowserToolbar.kt"
line="45"
column="25"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" imageTintList = ContextCompat.getColorStateList(context, tintColorResource)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/concept/toolbar/Toolbar.kt"
line="555"
column="25"/>
</issue>
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" imageTintList = ContextCompat.getColorStateList(context, tintColorResource)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/concept/toolbar/Toolbar.kt"
line="555"
column="25"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,103 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1="&lt;Button xmlns:android=&quot;http://schemas.android.com/apk/res/android&quot;"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/mozac_feature_addons_footer_section_item.xml"
line="5"
column="2"/>
</issue>
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/mozac_feature_addons_fragment_dialog_addon_installed.xml"
line="56"
column="6"/>
</issue>
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/mozac_feature_addons_fragment_dialog_addon_permissions.xml"
line="110"
column="10"/>
</issue>
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/mozac_feature_addons_fragment_dialog_addon_permissions.xml"
line="122"
column="10"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/feature/addons/migration/SupportedAddonsChecker.kt"
line="3"
column="62"/>
</issue>
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" ContextCompat.getColorStateList(requireContext(), confirmButtonBackgroundColor)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/feature/addons/ui/AddonInstallationDialogFragment.kt"
line="161"
column="17"/>
</issue>
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" ContextCompat.getColorStateList(requireContext(), backgroundColor)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/feature/addons/ui/PermissionsDialogFragment.kt"
line="375"
column="17"/>
</issue>
<issue
id="UnsafeCompatGetDrawable"
message="This call can lead to crashes, replace with AppCompatResources.getDrawable"
errorLine1=" imageView.setImageDrawable(ContextCompat.getDrawable(imageView.context, it))"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/feature/addons/ui/AddonsManagerAdapter.kt"
line="471"
column="44"/>
</issue>
<issue
id="UnsafeCompatGetDrawable"
message="This call can lead to crashes, replace with AppCompatResources.getDrawable"
errorLine1=" ContextCompat.getDrawable("
errorLine2=" ^">
<location
file="src/main/java/mozilla/components/feature/addons/ui/Extensions.kt"
line="156"
column="9"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="UnsafeCompatGetDrawable"
message="This call can lead to crashes, replace with AppCompatResources.getDrawable"
errorLine1=" return ContextCompat.getDrawable(context, drawable)?.toBitmap()"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/feature/awesomebar/provider/ClipboardSuggestionProvider.kt"
line="84"
column="16"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,81 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/mozac_download_cancel.xml"
line="63"
column="6"/>
</issue>
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/mozac_downloads_prompt.xml"
line="77"
column="6"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/feature/downloads/ui/DownloadAppChooserDialog.kt"
line="3"
column="62"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/feature/downloads/provider/FileProvider.kt"
line="3"
column="62"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/feature/downloads/SimpleDownloadDialogFragment.kt"
line="3"
column="62"/>
</issue>
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" val backgroundTintList = ContextCompat.getColorStateList(requireContext(), it)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/feature/downloads/ui/DownloadCancelDialogFragment.kt"
line="118"
column="46"/>
</issue>
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" val backgroundTintList = ContextCompat.getColorStateList("
errorLine2=" ^">
<location
file="src/main/java/mozilla/components/feature/downloads/SimpleDownloadDialogFragment.kt"
line="100"
column="42"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,81 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/mozac_feature_prompt_save_credit_card_prompt.xml"
line="123"
column="6"/>
</issue>
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/mozac_feature_prompt_save_login_prompt.xml"
line="128"
column="6"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/feature/prompts/dialog/AutofillEditText.kt"
line="3"
column="62"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/feature/prompts/provider/FileProvider.kt"
line="3"
column="62"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/feature/prompts/dialog/TimePickerDialogFragment.kt"
line="3"
column="62"/>
</issue>
<issue
id="UnsafeCompatGetDrawable"
message="This call can lead to crashes, replace with AppCompatResources.getDrawable"
errorLine1=" ContextCompat.getDrawable(itemView.context, R.drawable.color_picker_row_bg)?.getPadding(backgroundPadding)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/feature/prompts/dialog/BasicColorAdapter.kt"
line="90"
column="9"/>
</issue>
<issue
id="UnsafeCompatGetDrawable"
message="This call can lead to crashes, replace with AppCompatResources.getDrawable"
errorLine1=" ContextCompat.getDrawable(itemView.context, R.drawable.color_picker_checkmark)?.apply {"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/feature/prompts/dialog/BasicColorAdapter.kt"
line="93"
column="9"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="InvalidLicenseFormat"
message="The license comment doesn&apos;t have the appropriate format"
errorLine1="/*"
errorLine2="^">
<location
file="src/main/java/mozilla/components/feature/qr/views/AutoFitTextureView.kt"
line="1"
column="1"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment doesn&apos;t have the appropriate format"
errorLine1="/*"
errorLine2="^">
<location
file="src/main/java/mozilla/components/feature/qr/QrFragment.kt"
line="1"
column="1"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="ButtonStyleXmlDetector"
message="All buttons must have a style, try using NeutralButton or similar."
errorLine1=" &lt;Button"
errorLine2=" ~~~~~~">
<location
file="src/main/res/layout/mozac_site_permissions_prompt.xml"
line="113"
column="6"/>
</issue>
<issue
id="UnsafeCompatGetColorStateList"
message="This call can lead to crashes, replace with AppCompatResources.getColorStateList"
errorLine1=" val backgroundTintList = ContextCompat.getColorStateList(requireContext(), positiveButtonBackgroundColor)"
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
<location
file="src/main/java/mozilla/components/feature/sitepermissions/SitePermissionsDialogFragment.kt"
line="186"
column="38"/>
</issue>
</issues>

View File

@@ -0,0 +1,26 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/feature/syncedtabs/ClientTabPair.kt"
line="3"
column="62"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/feature/syncedtabs/SyncedTabsStorageSuggestionProvider.kt"
line="3"
column="62"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,37 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/service/fxa/FxaDeviceSettingsCache.kt"
line="3"
column="62"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/service/fxa/SyncAuthInfoCache.kt"
line="3"
column="62"/>
</issue>
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="src/main/java/mozilla/components/service/fxa/Types.kt"
line="3"
column="62"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -108,6 +108,10 @@ tasks.register("generateComponentEnum") {
file.delete()
file.createNewFile()
file << "/* This Source Code Form is subject to the terms of the Mozilla Public\n" +
" * License, v. 2.0. If a copy of the MPL was not distributed with this\n" +
" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */\n"
file << "package mozilla.components.support.base" << "\n"
file << "\n"
file << "// Automatically generated file. DO NOT MODIFY" << "\n"

View File

@@ -0,0 +1,15 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
<issue
id="InvalidLicenseFormat"
message="The license comment must be followed by a newline character"
errorLine1=" * file, You can obtain one at http://mozilla.org/MPL/2.0/. */"
errorLine2=" ~">
<location
file="build/generated/components/src/main/java/Component.kt"
line="3"
column="62"/>
</issue>
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

View File

@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8"?>
<issues format="6" by="lint 8.9.1" type="baseline" client="gradle" dependencies="false" name="AGP (8.9.1)" variant="all" version="8.9.1">
</issues>

Some files were not shown because too many files have changed in this diff Show More