corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1727458 - Change display list builder APIs to retain/reuse them r=gfx-reviewers,kvark

Browse Source 
This will allow storing state in a display list builder struct
between different display list builds. In time, this will be used
to reduce the size of the serialized display list data, by only
sending delta changes to WR. The extra information made available
by sending deltas will then allow WR to more efficiently cache and
reuse information across different scene/frame builds.

Differential Revision: https://phabricator.services.mozilla.com/D123579
This commit is contained in:
Glenn Watson
2021-08-30 23:10:10 +00:00
parent ef9336d13f
commit 9716dd973c
15 changed files with 205 additions and 104 deletions
Download Patch File Download Diff File Expand all files Collapse all files

42
gfx/layers/wr/WebRenderLayerManager.cpp
View File

@@ -41,8 +41,7 @@ WebRenderLayerManager::WebRenderLayerManager(nsIWidget* aWidget)
mIsFirstPaint(false),
mTarget(nullptr),
mPaintSequenceNumber(0),
mWebRenderCommandBuilder(this),
mLastDisplayListSize{0} {
mWebRenderCommandBuilder(this) {
MOZ_COUNT_CTOR(WebRenderLayerManager);
mStateManager.mLayerManager = this;
@@ -120,6 +119,11 @@ bool WebRenderLayerManager::Initialize(
WrBridge()->IdentifyTextureHost(textureFactoryIdentifier);
WrBridge()->SetNamespace(idNamespace.ref());
*aTextureFactoryIdentifier = textureFactoryIdentifier;
mDLBuilder = MakeUnique<wr::DisplayListBuilder>(
WrBridge()->GetPipeline(), WrBridge()->GetWebRenderBackend(),
&mDisplayItemCache);
hasInitialized = true;
return true;
}
@@ -133,6 +137,8 @@ void WebRenderLayerManager::DoDestroy(bool aIsSync) {
return;
}
mDLBuilder = nullptr;
LayerManager::Destroy();
mStateManager.Destroy();
@@ -339,20 +345,7 @@ void WebRenderLayerManager::EndTransactionWithoutLayer(
LayoutDeviceIntSize size = mWidget->GetClientSize();
// While the first display list after tab-switch can be large, the
// following ones are always smaller thanks to interning (rarely above 0.3MB).
// So don't let the spike of the first allocation make us allocate a large
// contiguous buffer (with some likelihood of OOM, see bug 1531819).
static const size_t kMaxPrealloc = 300000;
mLastDisplayListSize.items_size =
std::min(mLastDisplayListSize.items_size, kMaxPrealloc);
mLastDisplayListSize.cache_size =
std::min(mLastDisplayListSize.cache_size, kMaxPrealloc);
wr::DisplayListBuilder builder(WrBridge()->GetPipeline(),
WrBridge()->GetWebRenderBackend(),
mLastDisplayListSize, &mDisplayItemCache);
mDLBuilder->Begin();
wr::IpcResourceUpdateQueue resourceUpdates(WrBridge());
wr::usize builderDumpIndex = 0;
@@ -367,7 +360,7 @@ void WebRenderLayerManager::EndTransactionWithoutLayer(
if (XRE_IsContentProcess() &&
StaticPrefs::gfx_webrender_dl_dump_content_serialized()) {
builder.DumpSerializedDisplayList();
mDLBuilder->DumpSerializedDisplayList();
}
if (aDisplayList) {
@@ -375,7 +368,7 @@ void WebRenderLayerManager::EndTransactionWithoutLayer(
mDisplayItemCache.SetDisplayList(aDisplayListBuilder, aDisplayList);
mWebRenderCommandBuilder.BuildWebRenderCommands(
builder, resourceUpdates, aDisplayList, aDisplayListBuilder,
*mDLBuilder, resourceUpdates, aDisplayList, aDisplayListBuilder,
mScrollData, std::move(aFilters));
aDisplayListBuilder->NotifyAndClearScrollFrames();
@@ -385,19 +378,19 @@ void WebRenderLayerManager::EndTransactionWithoutLayer(
} else {
// ViewToPaint does not have frame yet, then render only background clolor.
MOZ_ASSERT(!aDisplayListBuilder && aBackground);
aBackground->AddWebRenderCommands(builder);
aBackground->AddWebRenderCommands(*mDLBuilder);
if (dumpEnabled) {
printf_stderr("(no display list; background only)\n");
builderDumpIndex =
builder.Dump(/*indent*/ 1, Some(builderDumpIndex), Nothing());
mDLBuilder->Dump(/*indent*/ 1, Some(builderDumpIndex), Nothing());
}
}
mWidget->AddWindowOverlayWebRenderCommands(WrBridge(), builder,
mWidget->AddWindowOverlayWebRenderCommands(WrBridge(), *mDLBuilder,
resourceUpdates);
if (dumpEnabled) {
printf_stderr("(window overlay)\n");
Unused << builder.Dump(/*indent*/ 1, Some(builderDumpIndex), Nothing());
Unused << mDLBuilder->Dump(/*indent*/ 1, Some(builderDumpIndex), Nothing());
}
if (AsyncPanZoomEnabled()) {
@@ -458,10 +451,7 @@ void WebRenderLayerManager::EndTransactionWithoutLayer(
{
AUTO_PROFILER_TRACING_MARKER("Paint", "ForwardDPTransaction", GRAPHICS);
DisplayListData dlData;
builder.Finalize(dlData);
mLastDisplayListSize.items_size = dlData.mDLItems->mCapacity;
mLastDisplayListSize.cache_size = dlData.mDLCache->mCapacity;
mLastDisplayListSize.spatial_tree_size = dlData.mDLSpatialTree->mCapacity;
mDLBuilder->End(dlData);
resourceUpdates.Flush(dlData.mResourceUpdates, dlData.mSmallShmems,
dlData.mLargeShmems);
dlData.mRect =