corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

bug 250255 : get rid of a redundant check of 'registry type' in GetSourceHomePageURL (addressing reviewer's comment I missed in the previous check-in)

Browse Source
This commit is contained in:
jshin@mailaps.org
2006-09-17 05:35:16 +00:00
parent 93f83b6af5
commit 96f20efd55
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
browser/components/migration/src/nsIEProfileMigrator.cpp
View File

@@ -517,10 +517,7 @@ nsIEProfileMigrator::GetSourceHomePageURL(nsACString& aResult)
// read registry data
NS_NAMED_LITERAL_STRING(homeURLValName, "Start Page");
nsAutoString homeURLVal;
PRUint32 type;
if (NS_SUCCEEDED(regKey->GetValueType(homeURLValName, &type)) &&
type == nsIWindowsRegKey::TYPE_STRING &&
NS_SUCCEEDED(regKey->ReadStringValue(homeURLValName, homeURLVal))) {
if (NS_SUCCEEDED(regKey->ReadStringValue(homeURLValName, homeURLVal))) {
// Do we need this round-about way to get |homePageURL|?
// Perhaps, we do to have the form of URL under our control
// (cf. network.standard-url.escape-utf8)