corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1817203: Introduce go_button in engagement_type r=mak

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D171033
This commit is contained in:
Daisuke Akatsuka
2023-02-28 01:26:49 +00:00
parent b4d694fef0
commit 95dabb81e9
3 changed files with 19 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
browser/components/urlbar/UrlbarController.sys.mjs
View File

@@ -944,8 +944,10 @@ class TelemetryEvent {
startEventInfo.interactionType == "dropped" ? "drop_go" : "paste_go";
} else if (event.type == "blur") {
action = "blur";
} else if (MouseEvent.isInstance(event)) {
action = event.target.id == "urlbar-go-button" ? "go_button" : "click";
} else {
action = MouseEvent.isInstance(event) ? "click" : "enter";
action = "enter";
}
let method = action == "blur" ? "abandonment" : "engagement";
@@ -982,6 +984,11 @@ class TelemetryEvent {
return;
}
if (action == "go_button") {
// Fall back since the conventional telemetry dones't support "go_button" action.
action = "click";
}
let endTime = (event && event.timeStamp) || Cu.now();
let startTime = startEventInfo.timeStamp || endTime;
// Synthesized events in tests may have a bogus timeStamp, causing a

3
browser/components/urlbar/metrics.yaml
View File

@@ -198,7 +198,8 @@ urlbar:
engagement_type:
description: >
Records how the user selected the result. The possible values are:
`click`, `enter`, `drop_go`, `paste_go`, `dismiss`, `help`.
`click`, `enter`, `go_button`, `drop_go`, `paste_go`, `dismiss`,
`help`.
type: string
groups:
description: >

9
browser/components/urlbar/tests/engagementTelemetry/browser/browser_glean_telemetry_engagement_type.js
View File

@@ -28,6 +28,15 @@ add_task(async function engagement_type_enter() {
});
});
add_task(async function engagement_type_go_button() {
await doTest(async browser => {
await openPopup("x");
EventUtils.synthesizeMouseAtCenter(gURLBar.goButton, {});
assertEngagementTelemetry([{ engagement_type: "go_button" }]);
});
});
add_task(async function engagement_type_drop_go() {
await doTest(async browser => {
await doDropAndGo("example.com");