corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1691913 - Rename nsBaseHashtable::Put to InsertOrUpdate. r=xpcom-reviewers,necko-reviewers,jgilbert,dragana,nika

Browse Source 
This makes the naming more consistent with other functions called
Insert and/or Update. Also, it removes the ambiguity whether
Put expects that an entry already exists or not, in particular because
it differed from nsTHashtable::PutEntry in that regard.

Differential Revision: https://phabricator.services.mozilla.com/D105473
This commit is contained in:
Simon Giesecke
2021-02-26 09:11:46 +00:00
parent 7c075f27d9
commit 95c38cc6b8
298 changed files with 884 additions and 815 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
dom/html/HTMLFormElement.cpp
View File

@@ -2025,7 +2025,7 @@ HTMLFormElement::IndexOfControl(nsIFormControl* aControl) {
void HTMLFormElement::SetCurrentRadioButton(const nsAString& aName,
HTMLInputElement* aRadio) {
mSelectedRadioButtons.Put(aName, RefPtr{aRadio});
mSelectedRadioButtons.InsertOrUpdate(aName, RefPtr{aRadio});
}
HTMLInputElement* HTMLFormElement::GetCurrentRadioButton(
@@ -2177,8 +2177,8 @@ uint32_t HTMLFormElement::GetRequiredRadioCount(const nsAString& aName) const {
void HTMLFormElement::RadioRequiredWillChange(const nsAString& aName,
bool aRequiredAdded) {
if (aRequiredAdded) {
mRequiredRadioButtonCounts.Put(aName,
mRequiredRadioButtonCounts.Get(aName) + 1);
mRequiredRadioButtonCounts.InsertOrUpdate(
aName, mRequiredRadioButtonCounts.Get(aName) + 1);
} else {
uint32_t requiredNb = mRequiredRadioButtonCounts.Get(aName);
NS_ASSERTION(requiredNb >= 1,
@@ -2186,7 +2186,7 @@ void HTMLFormElement::RadioRequiredWillChange(const nsAString& aName,
if (requiredNb == 1) {
mRequiredRadioButtonCounts.Remove(aName);
} else {
mRequiredRadioButtonCounts.Put(aName, requiredNb - 1);
mRequiredRadioButtonCounts.InsertOrUpdate(aName, requiredNb - 1);
}
}
}
@@ -2197,7 +2197,7 @@ bool HTMLFormElement::GetValueMissingState(const nsAString& aName) const {
void HTMLFormElement::SetValueMissingState(const nsAString& aName,
bool aValue) {
mValueMissingRadioGroups.Put(aName, aValue);
mValueMissingRadioGroups.InsertOrUpdate(aName, aValue);
}
EventStates HTMLFormElement::IntrinsicState() const {
@@ -2361,7 +2361,7 @@ void HTMLFormElement::AddToPastNamesMap(const nsAString& aName,
// previous entry with the same name, if any.
nsCOMPtr<nsIContent> node = do_QueryInterface(aChild);
if (node) {
mPastNameLookupTable.Put(aName, ToSupports(node));
mPastNameLookupTable.InsertOrUpdate(aName, ToSupports(node));
node->SetFlags(MAY_BE_IN_PAST_NAMES_MAP);
}
}