corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1702678: Handle corner case when opener window is closed from a nested event loop during open. r=nika

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D111179
This commit is contained in:
Kris Maglione
2021-05-07 03:00:13 +00:00
parent c7dc20560e
commit 94b09497de
4 changed files with 88 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
dom/base/nsFrameLoader.cpp
View File

@@ -288,8 +288,23 @@ static already_AddRefed<BrowsingContext> CreateBrowsingContext(
RefPtr<BrowsingContext> opener;
if (aOpenWindowInfo && !aOpenWindowInfo->GetForceNoOpener()) {
opener = aOpenWindowInfo->GetParent();
// Must create BrowsingContext with opener in-process.
MOZ_ASSERT_IF(opener, opener->IsInProcess());
if (opener) {
// Must create BrowsingContext with opener in-process.
MOZ_ASSERT(opener->IsInProcess());
// This can only happen when the opener was closed from a nested event
// loop in the window provider code, and only when the open was triggered
// by a non-e10s tab, and the new tab is being opened in a new browser
// window. Since it is a corner case among corner cases, and the opener
// window will appear to be null to consumers after it is discarded
// anyway, just drop the opener entirely.
if (opener->IsDiscarded()) {
NS_WARNING(
"Opener was closed from a nested event loop in the parent process. "
"Please fix this.");
opener = nullptr;
}
}
}
RefPtr<nsGlobalWindowInner> parentInner =