corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1959139 - Ensure platform-specific tags aren't missing in update-glean-tags r=TravisLong

Browse Source 
Also run ./mach update-glean-tags while we're at it.

Differential Revision: https://phabricator.services.mozilla.com/D247480
This commit is contained in:
Chris H-C
2025-05-01 19:38:06 +00:00
committed by chutten@mozilla.com
parent b567809b88
commit 90458be307
2 changed files with 20 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
toolkit/components/glean/build_scripts/mach_commands.py
View File

@@ -17,6 +17,16 @@ GENERATED_HEADER = """
### DO NOT edit it by hand.
"""
# A list of bug components only present in certain build configurations.
# Include any valid BMO bug component that is missed when you run
# `./mach update-glean-tags` on certain platforms.
PLATFORM_SPECIFIC_COMPONENTS = [
"Toolkit :: Default Browser Agent", # Windows-only
]
DEFAULT_TAG_CONTENT = {
"description": "The Bugzilla component which applies to this object."
}
DATA_REVIEW_HELP = """
Beginning 2024-05-07[1], data reviews for projects in mozilla-central are now
@@ -84,9 +94,14 @@ def update_glean_tags(command_context):
for bug_component in bug_components:
product = bug_component.product.strip()
component = bug_component.component.strip()
tags[f"{product} :: {component}"] = {
"description": "The Bugzilla component which applies to this object."
}
tags[f"{product} :: {component}"] = DEFAULT_TAG_CONTENT
for bug_component in PLATFORM_SPECIFIC_COMPONENTS:
tags[bug_component] = DEFAULT_TAG_CONTENT
# pyyaml will anchor+alias DEFAULT_TAG_CONTENT which would normally be fine,
# but I don't want the whole file to change all at once right now.
yaml.Dumper.ignore_aliases = lambda self, data: True
open(tags_filename, "w").write(
f"{LICENSE_HEADER}\n{GENERATED_HEADER}\n\n"

6
toolkit/components/glean/tags.yaml
View File

@@ -329,6 +329,8 @@ $schema: moz://mozilla.org/schemas/glean/tags/1-0-0
description: The Bugzilla component which applies to this object.
'Firefox :: Bookmarks & History':
description: The Bugzilla component which applies to this object.
'Firefox :: Data Loss Prevention':
description: The Bugzilla component which applies to this object.
'Firefox :: Distributions':
description: The Bugzilla component which applies to this object.
'Firefox :: Downloads Panel':
@@ -407,8 +409,6 @@ $schema: moz://mozilla.org/schemas/glean/tags/1-0-0
description: The Bugzilla component which applies to this object.
'Firefox :: Tours':
description: The Bugzilla component which applies to this object.
'Firefox :: Translation':
description: The Bugzilla component which applies to this object.
'Firefox :: Translations':
description: The Bugzilla component which applies to this object.
'Firefox :: about:logins':
@@ -519,8 +519,6 @@ $schema: moz://mozilla.org/schemas/glean/tags/1-0-0
description: The Bugzilla component which applies to this object.
'Toolkit :: General':
description: The Bugzilla component which applies to this object.
'Toolkit :: IOUtils and PathUtils':
description: The Bugzilla component which applies to this object.
'Toolkit :: Password Manager':
description: The Bugzilla component which applies to this object.
'Toolkit :: Performance Monitoring':