corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1471540 - Make DevTools code compatible with new eslint-plugin-react;r=standard8

Browse Source 
MozReview-Commit-ID: 1flBkghZw9
This commit is contained in:
Julian Descottes
2018-07-20 14:26:45 +02:00
parent 00512ea2f7
commit 8f3d04cda8
3 changed files with 61 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

90
devtools/client/shared/components/tree/TreeView.js
View File

@@ -134,51 +134,6 @@ define(function(require, exports, module) {
return defaultProps;
}
constructor(props) {
super(props);
this.state = {
expandedNodes: props.expandedNodes,
columns: ensureDefaultColumn(props.columns),
selected: props.selected,
lastSelectedIndex: 0
};
this.toggle = this.toggle.bind(this);
this.isExpanded = this.isExpanded.bind(this);
this.onKeyDown = this.onKeyDown.bind(this);
this.onClickRow = this.onClickRow.bind(this);
this.getSelectedRow = this.getSelectedRow.bind(this);
this.selectRow = this.selectRow.bind(this);
this.isSelected = this.isSelected.bind(this);
this.onFilter = this.onFilter.bind(this);
this.onSort = this.onSort.bind(this);
this.getMembers = this.getMembers.bind(this);
this.renderRows = this.renderRows.bind(this);
}
componentWillReceiveProps(nextProps) {
const { expandedNodes, selected } = nextProps;
const state = {
expandedNodes,
lastSelectedIndex: this.getSelectedRowIndex()
};
if (selected) {
state.selected = selected;
}
this.setState(Object.assign({}, this.state, state));
}
componentDidUpdate() {
const selected = this.getSelectedRow();
if (!selected && this.rows.length > 0) {
this.selectRow(this.rows[
Math.min(this.state.lastSelectedIndex, this.rows.length - 1)]);
}
}
static subPath(path, subKey) {
return path + "/" + String(subKey).replace(/[\\/]/g, "\\$&");
}
@@ -226,6 +181,51 @@ define(function(require, exports, module) {
return expandedNodes;
}
constructor(props) {
super(props);
this.state = {
expandedNodes: props.expandedNodes,
columns: ensureDefaultColumn(props.columns),
selected: props.selected,
lastSelectedIndex: 0
};
this.toggle = this.toggle.bind(this);
this.isExpanded = this.isExpanded.bind(this);
this.onKeyDown = this.onKeyDown.bind(this);
this.onClickRow = this.onClickRow.bind(this);
this.getSelectedRow = this.getSelectedRow.bind(this);
this.selectRow = this.selectRow.bind(this);
this.isSelected = this.isSelected.bind(this);
this.onFilter = this.onFilter.bind(this);
this.onSort = this.onSort.bind(this);
this.getMembers = this.getMembers.bind(this);
this.renderRows = this.renderRows.bind(this);
}
componentWillReceiveProps(nextProps) {
const { expandedNodes, selected } = nextProps;
const state = {
expandedNodes,
lastSelectedIndex: this.getSelectedRowIndex()
};
if (selected) {
state.selected = selected;
}
this.setState(Object.assign({}, this.state, state));
}
componentDidUpdate() {
const selected = this.getSelectedRow();
if (!selected && this.rows.length > 0) {
this.selectRow(this.rows[
Math.min(this.state.lastSelectedIndex, this.rows.length - 1)]);
}
}
// Node expand/collapse
toggle(nodePath) {