corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1230034 part 4 - Make FramePropertyDescriptor to be a template. r=froydnj,dbaron

Browse Source 
This patch makes methods of FramePropertyTable and FrameProperties to be
simple template wrapper functions. Then it converts all references to
FramePropertyDescriptor to use "void" parameter to simulate the current
unsafe behavior.

SmallValueHolder is used for storing small values like int32_t, float,
which can fit in the size of a pointer directly, and thus no lifetime
management is needed.
This commit is contained in:
Xidorn Quan
2016-01-28 14:23:59 +11:00
parent 4dccb52f19
commit 8e2ada8719
14 changed files with 231 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
layout/mathml/nsMathMLmtableFrame.cpp
View File

@@ -136,7 +136,7 @@ NS_DECLARE_FRAME_PROPERTY(RowLinesProperty, DeleteValue<nsTArray<int8_t>>)
NS_DECLARE_FRAME_PROPERTY(ColumnAlignProperty, DeleteValue<nsTArray<int8_t>>)
NS_DECLARE_FRAME_PROPERTY(ColumnLinesProperty, DeleteValue<nsTArray<int8_t>>)
static const FramePropertyDescriptor*
static const FramePropertyDescriptor<>*
AttributeToProperty(nsIAtom* aAttribute)
{
if (aAttribute == nsGkAtoms::rowalign_)
@@ -157,7 +157,7 @@ AttributeToProperty(nsIAtom* aAttribute)
*/
static nsTArray<int8_t>*
FindCellProperty(const nsIFrame* aCellFrame,
const FramePropertyDescriptor* aFrameProperty)
const FramePropertyDescriptor<>* aFrameProperty)
{
const nsIFrame* currentFrame = aCellFrame;
nsTArray<int8_t>* propertyData = nullptr;