corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1245424 Part 2 - Stop checking the existence of details frame before toggling. r=bz

Browse Source 
MozReview-Commit-ID: 6Xgyu7DDquy
This commit is contained in:
Ting-Yu Lin
2016-03-24 15:05:29 +08:00
parent 53e6f51184
commit 8a6a995fd8
2 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
dom/html/HTMLSummaryElement.cpp
View File

@@ -62,14 +62,12 @@ HTMLSummaryElement::PostHandleEvent(EventChainPostVisitor& aVisitor)
// When dispatching a synthesized mouse click event to a details element // When dispatching a synthesized mouse click event to a details element
// with 'display: none', both Chrome and Safari do not toggle the 'open' // with 'display: none', both Chrome and Safari do not toggle the 'open'
// attribute. We follow them by checking whether the details element has a // attribute. We had tried to be compatible with this behavior, but found
// frame or not. // more inconsistency in test cases in bug 1245424. So we stop doing that.
if (details->GetPrimaryFrame(Flush_Frames)) {
details->ToggleOpen(); details->ToggleOpen();
aVisitor.mEventStatus = nsEventStatus_eConsumeNoDefault; aVisitor.mEventStatus = nsEventStatus_eConsumeNoDefault;
return NS_OK; return NS_OK;
} }
}
} // event->HasMouseEventMessage() } // event->HasMouseEventMessage()
if (event->HasKeyEventMessage()) { if (event->HasKeyEventMessage()) {

2
layout/reftests/details-summary/reftest.list
View File

@@ -65,7 +65,7 @@ pref(dom.details_element.enabled,true) == mouse-click-overflow-hidden-details.ht
pref(dom.details_element.enabled,true) == mouse-click-twice-overflow-hidden-details.html overflow-hidden-details.html pref(dom.details_element.enabled,true) == mouse-click-twice-overflow-hidden-details.html overflow-hidden-details.html
pref(dom.details_element.enabled,true) == mouse-click-overflow-auto-details.html overflow-auto-open-details.html pref(dom.details_element.enabled,true) == mouse-click-overflow-auto-details.html overflow-auto-open-details.html
pref(dom.details_element.enabled,true) == mouse-click-twice-overflow-auto-details.html overflow-auto-details.html pref(dom.details_element.enabled,true) == mouse-click-twice-overflow-auto-details.html overflow-auto-details.html
pref(dom.details_element.enabled,true) == mouse-click-display-none-details.html single-summary.html pref(dom.details_element.enabled,true) == mouse-click-display-none-details.html open-single-summary.html
# Dispatch mouse click to out-of-flow details or summary # Dispatch mouse click to out-of-flow details or summary
pref(dom.details_element.enabled,true) == mouse-click-fixed-summary.html open-fixed-summary.html pref(dom.details_element.enabled,true) == mouse-click-fixed-summary.html open-fixed-summary.html