corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1913090 - Remove unused mTransformInDevSpace member from AnimationTransform struct r=gregp,tnikkel

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D219196
This commit is contained in:
Shashi Sugrim
2024-08-16 20:14:46 +00:00
parent eb5a77dbe1
commit 89c1102d2a
2 changed files with 5 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
gfx/layers/CompositorAnimationStorage.cpp
View File

@@ -152,8 +152,8 @@ void CompositorAnimationStorage::SetAnimatedValue(
if (!aPreviousValue) { if (!aPreviousValue) {
MOZ_ASSERT(!mAnimatedValues.Contains(aId)); MOZ_ASSERT(!mAnimatedValues.Contains(aId));
mAnimatedValues.InsertOrUpdate( mAnimatedValues.InsertOrUpdate(
aId, MakeUnique<AnimatedValue>(gfx::Matrix4x4(), aFrameTransform, aData, aId,
std::move(aValue))); MakeUnique<AnimatedValue>(aFrameTransform, aData, std::move(aValue)));
return; return;
} }
MOZ_ASSERT(aPreviousValue->Is<AnimationTransform>()); MOZ_ASSERT(aPreviousValue->Is<AnimationTransform>());

13
gfx/layers/CompositorAnimationStorage.h
View File

@@ -28,11 +28,6 @@ using AnimationArray = nsTArray<layers::Animation>;
using SampledAnimationArray = AutoTArray<RefPtr<StyleAnimationValue>, 1>; using SampledAnimationArray = AutoTArray<RefPtr<StyleAnimationValue>, 1>;
struct AnimationTransform { struct AnimationTransform {
/*
* This transform is calculated from sampleanimation in device pixel
* and used for layers (i.e. non WebRender)
*/
gfx::Matrix4x4 mTransformInDevSpace;
/* /*
* This transform is calculated from frame used for WebRender and used by * This transform is calculated from frame used for WebRender and used by
* getOMTAStyle() for OMTA testing. * getOMTAStyle() for OMTA testing.
@@ -64,12 +59,10 @@ struct AnimatedValue final {
return mValue.is<T>(); return mValue.is<T>();
} }
AnimatedValue(const gfx::Matrix4x4& aTransformInDevSpace, AnimatedValue(const gfx::Matrix4x4& aFrameTransform,
const gfx::Matrix4x4& aFrameTransform,
const TransformData& aData, SampledAnimationArray&& aValue) const TransformData& aData, SampledAnimationArray&& aValue)
: mValue(AsVariant(AnimationTransform{ : mValue(AsVariant(
aTransformInDevSpace, aFrameTransform, aData, std::move(aValue)})) { AnimationTransform{aFrameTransform, aData, std::move(aValue)})) {}
}
explicit AnimatedValue(const float& aValue) : mValue(AsVariant(aValue)) {} explicit AnimatedValue(const float& aValue) : mValue(AsVariant(aValue)) {}