corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1299727 - Rename NS_WARN_IF_FALSE as NS_WARNING_ASSERTION. r=erahm.

Browse Source 
The new name makes the sense of the condition much clearer. E.g. compare:

  NS_WARN_IF_FALSE(!rv.Failed());

with:

  NS_WARNING_ASSERTION(!rv.Failed());

The new name also makes it clearer that it only has effect in debug builds,
because that's standard for assertions.
This commit is contained in:
Nicholas Nethercote
2016-09-01 15:01:16 +10:00
parent 9adec6015b
commit 887efe04d5
139 changed files with 438 additions and 357 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
xpcom/base/nsMessageLoop.cpp
View File

@@ -133,7 +133,7 @@ MessageLoopTimerCallback::Notify(nsITimer* aTimer)
// We don't expect to hit the case when the timer fires but mTask has been
// deleted, because mTask should cancel the timer before the mTask is
// deleted. But you never know...
NS_WARN_IF_FALSE(mTask, "This timer shouldn't have fired.");
NS_WARNING_ASSERTION(mTask, "This timer shouldn't have fired.");
if (mTask) {
mTask->Run();