corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1579876 - Add telemetry to estimate the benefit of a streaming parser for JS. data-review=mlopatka r=jorendorff

Browse Source 
Differential Revision: https://phabricator.services.mozilla.com/D45551
This commit is contained in:
Nicolas B. Pierron
2019-09-19 12:42:51 +00:00
parent 0d1c1a20f7
commit 80845efe82
9 changed files with 153 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
dom/script/ScriptLoader.cpp
View File

@@ -2572,6 +2572,29 @@ class MOZ_RAII AutoSetProcessingScriptTag {
~AutoSetProcessingScriptTag() { mContext->SetProcessingScriptTag(mOldTag); }
};
static void ReportStreamAndParseTelemetry(JS::Handle<JSScript*> aScript,
TimeDuration aStreamingTime) {
using namespace mozilla::Telemetry;
if (!aStreamingTime) {
Accumulate(DOM_SCRIPT_IS_STREAMED, false);
return;
}
Accumulate(DOM_SCRIPT_IS_STREAMED, true);
TimeDuration parseTime;
TimeDuration emitTime;
JS_ReportFirstCompileTime(aScript, parseTime, emitTime);
double st = aStreamingTime.ToMilliseconds();
double pt = parseTime.ToMilliseconds();
double et = emitTime.ToMilliseconds();
double total = st + pt + et;
double spt = st + std::max(pt - st, double(0)) + et;
Accumulate(DOM_SCRIPT_LOAD_STREAM_TIME_PERCENT, 100 * st / total);
Accumulate(DOM_SCRIPT_LOAD_PARSE_TIME_PERCENT, 100 * pt / total);
Accumulate(DOM_SCRIPT_LOAD_EMIT_TIME_PERCENT, 100 * et / total);
Accumulate(DOM_SCRIPT_LOAD_STREAMPARSE_ESTIMATE_PERCENT, 100 * spt / total);
}
static nsresult ExecuteCompiledScript(JSContext* aCx,
ScriptLoadRequest* aRequest,
nsJSUtils::ExecutionContext& aExec) {
@@ -2582,6 +2605,11 @@ static nsresult ExecuteCompiledScript(JSContext* aCx,
return NS_OK;
}
// Report telemetry about streaming, parsing and emitting code for the given
// script. These telemetry are used to analyze whether it would be beneficial
// to use a streaming parser.
ReportStreamAndParseTelemetry(script, aRequest->mStreamingTime);
// Create a ClassicScript object and associate it with the JSScript.
RefPtr<ClassicScript> classicScript =
new ClassicScript(aRequest->mFetchOptions, aRequest->mBaseURL);