corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1890427 - Part 7: Use an observer to regenerate backups on data sanitization. r=backup-reviewers,kpatenio

Browse Source 
This also reorganizes things a bit in BackupService so that uninitBackupScheduler
also disarms the debouncer and any queued debounced jobs end up being inert.

Differential Revision: https://phabricator.services.mozilla.com/D218877
This commit is contained in:
Mike Conley
2024-09-04 17:56:58 +00:00
parent 2d3cbfc487
commit 7ca5c1c77a
2 changed files with 28 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
browser/components/backup/BackupService.sys.mjs
View File

@@ -948,8 +948,10 @@ export class BackupService extends EventTarget {
this.#postRecoveryResolver = resolve;
this.#backupWriteAbortController = new AbortController();
this.#regenerationDebouncer = new lazy.DeferredTask(async () => {
await this.deleteLastBackup();
await this.createBackupOnIdleDispatch();
if (!this.#backupWriteAbortController.signal.aborted) {
await this.deleteLastBackup();
await this.createBackupOnIdleDispatch();
}
}, BackupService.REGENERATION_DEBOUNCE_RATE_MS);
}
@@ -3164,6 +3166,7 @@ export class BackupService extends EventTarget {
Services.obs.addObserver(this.#observer, "passwordmgr-storage-changed");
Services.obs.addObserver(this.#observer, "formautofill-storage-changed");
Services.obs.addObserver(this.#observer, "sanitizer-sanitization-complete");
Services.obs.addObserver(this.#observer, "quit-application-granted");
}
@@ -3196,6 +3199,9 @@ export class BackupService extends EventTarget {
Services.obs.removeObserver(this.#observer, "formautofill-storage-changed");
Services.obs.removeObserver(this.#observer, "quit-application-granted");
this.#observer = null;
this.#regenerationDebouncer.disarm();
this.#backupWriteAbortController.abort();
}
/**
@@ -3219,7 +3225,6 @@ export class BackupService extends EventTarget {
}
case "quit-application-granted": {
this.uninitBackupScheduler();
this.#backupWriteAbortController.abort();
break;
}
case "passwordmgr-storage-changed": {
@@ -3238,6 +3243,10 @@ export class BackupService extends EventTarget {
}
break;
}
case "sanitizer-sanitization-complete": {
this.#debounceRegeneration();
break;
}
}
}