corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Bug 1865154 - Add check for activeIndex in tabState.entries r=sessionstore-reviewers,sfoster

Browse Source 
* Only add previously open tabs to the newWindowState in _prepDataForDeferredRestore
if they have entries

Differential Revision: https://phabricator.services.mozilla.com/D196157
This commit is contained in:
Sarah Clements
2023-12-18 16:55:11 +00:00
parent 5b4510041c
commit 7bc0261e9d
1 changed files with 21 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
browser/components/sessionstore/SessionStore.sys.mjs
View File

@@ -6532,27 +6532,29 @@ var SessionStoreInternal = {
activeIndex = Math.min(activeIndex, tabState.entries.length - 1); activeIndex = Math.min(activeIndex, tabState.entries.length - 1);
activeIndex = Math.max(activeIndex, 0); activeIndex = Math.max(activeIndex, 0);
let title = if (activeIndex in tabState.entries) {
tabState.entries[activeIndex].title || let title =
tabState.entries[activeIndex].url; tabState.entries[activeIndex].title ||
tabState.entries[activeIndex].url;
let tabData = { let tabData = {
state: tabState, state: tabState,
title, title,
image: tabState.image, image: tabState.image,
pos: tIndex, pos: tIndex,
closedAt: Date.now(), closedAt: Date.now(),
closedInGroup: false, closedInGroup: false,
removeAfterRestore: true, removeAfterRestore: true,
}; };
if (this._shouldSaveTabState(tabState)) { if (this._shouldSaveTabState(tabState)) {
this.saveClosedTabData( this.saveClosedTabData(
window, window,
newWindowState._closedTabs, newWindowState._closedTabs,
tabData, tabData,
false false
); );
}
} }
} }
tIndex++; tIndex++;